You are viewing a plain text version of this content. The canonical link for it is here.
Posted to codereview@trafodion.apache.org by andyyangcn <gi...@git.apache.org> on 2018/03/22 01:11:37 UTC
[GitHub] trafodion pull request #1492: [TRAFODION-3007] update statistics report erro...
GitHub user andyyangcn opened a pull request:
https://github.com/apache/trafodion/pull/1492
[TRAFODION-3007] update statistics report error on volatile table
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/andyyangcn/incubator-trafodion fix6237
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafodion/pull/1492.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1492
----
----
---
[GitHub] trafodion pull request #1492: [TRAFODION-3007] update statistics report erro...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/trafodion/pull/1492
---
[GitHub] trafodion pull request #1492: [TRAFODION-3007] update statistics report erro...
Posted by DaveBirdsall <gi...@git.apache.org>.
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1492#discussion_r176563291
--- Diff: core/sql/ustat/hs_parser.cpp ---
@@ -243,13 +243,6 @@ Lng32 AddTableName( const hs_table_type type
}
else
{
- // This is for UPDATE STATISTICS; the volatile schema name exists.
- // For now, UPDATE STATISTICS is not supported. (See also JIRA Trafodion-2004.)
-
- HSFuncMergeDiags(-UERR_VOLATILE_TABLES_NOT_SUPPORTED);
- retcode = -1;
- HSHandleError(retcode); // causes a return from this function
-
// The code below is old code that will be needed once we turn on
// support for UPDATE STATISTICS on volatile tables. We leave it here
--- End diff --
We could delete the comments "The code below is old code..." since we are turning support back on.
---
[GitHub] trafodion pull request #1492: [TRAFODION-3007] update statistics report erro...
Posted by andyyangcn <gi...@git.apache.org>.
Github user andyyangcn commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1492#discussion_r176620828
--- Diff: core/sql/ustat/hs_parser.cpp ---
@@ -243,13 +243,6 @@ Lng32 AddTableName( const hs_table_type type
}
else
{
- // This is for UPDATE STATISTICS; the volatile schema name exists.
- // For now, UPDATE STATISTICS is not supported. (See also JIRA Trafodion-2004.)
-
- HSFuncMergeDiags(-UERR_VOLATILE_TABLES_NOT_SUPPORTED);
- retcode = -1;
- HSHandleError(retcode); // causes a return from this function
-
// The code below is old code that will be needed once we turn on
// support for UPDATE STATISTICS on volatile tables. We leave it here
--- End diff --
Thanks Dave. SB_HISTOGRAM* table in the volatile schema gets dropped when the schema gets dropped. I had tested that.
---