You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/03/20 09:20:27 UTC
[GitHub] [incubator-shardingsphere] codecov-io edited a comment on issue
#4850: #4460, fix order by string column exception
codecov-io edited a comment on issue #4850: #4460, fix order by string column exception
URL: https://github.com/apache/incubator-shardingsphere/pull/4850#issuecomment-601545150
# [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4850?src=pr&el=h1) Report
> Merging [#4850](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4850?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/6f9294f0afea087673dbbc6d96b7894e086ba26f&el=desc) will **decrease** coverage by `1.15%`.
> The diff coverage is `46.66%`.
[](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4850?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4850 +/- ##
============================================
- Coverage 56.19% 55.04% -1.16%
+ Complexity 448 436 -12
============================================
Files 1163 1136 -27
Lines 20895 20344 -551
Branches 3880 3760 -120
============================================
- Hits 11742 11198 -544
- Misses 8424 8437 +13
+ Partials 729 709 -20
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4850?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...sphere/encrypt/metadata/EncryptColumnMetaData.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4850/diff?src=pr&el=tree#diff-ZW5jcnlwdC1jb3JlL2VuY3J5cHQtY29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VuY3J5cHQvbWV0YWRhdGEvRW5jcnlwdENvbHVtbk1ldGFEYXRhLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...r/binder/metadata/column/ColumnMetaDataLoader.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4850/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWJpbmRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9iaW5kZXIvbWV0YWRhdGEvY29sdW1uL0NvbHVtbk1ldGFEYXRhTG9hZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [.../execute/sql/execute/result/MemoryQueryResult.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4850/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWV4ZWN1dGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL2V4ZWN1dGUvc3FsL2V4ZWN1dGUvcmVzdWx0L01lbW9yeVF1ZXJ5UmVzdWx0LmphdmE=) | `96.07% <50.00%> (-1.97%)` | `0.00 <0.00> (ø)` | |
| [.../execute/sql/execute/result/StreamQueryResult.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4850/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWV4ZWN1dGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL2V4ZWN1dGUvc3FsL2V4ZWN1dGUvcmVzdWx0L1N0cmVhbVF1ZXJ5UmVzdWx0LmphdmE=) | `92.30% <50.00%> (-1.93%)` | `0.00 <0.00> (ø)` | |
| [...phere/sharding/merge/dql/orderby/OrderByValue.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4850/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLW1lcmdlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZy9tZXJnZS9kcWwvb3JkZXJieS9PcmRlckJ5VmFsdWUuamF2YQ==) | `83.67% <72.72%> (-9.88%)` | `0.00 <0.00> (ø)` | |
| [...re/sharding/merge/dql/ShardingDQLResultMerger.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4850/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLW1lcmdlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZy9tZXJnZS9kcWwvU2hhcmRpbmdEUUxSZXN1bHRNZXJnZXIuamF2YQ==) | `69.23% <75.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/merge/dql/groupby/GroupByMemoryMergedResult.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4850/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLW1lcmdlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZy9tZXJnZS9kcWwvZ3JvdXBieS9Hcm91cEJ5TWVtb3J5TWVyZ2VkUmVzdWx0LmphdmE=) | `93.10% <75.00%> (-2.82%)` | `1.00 <1.00> (ø)` | |
| [...g/merge/dql/groupby/GroupByStreamMergedResult.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4850/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLW1lcmdlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZy9tZXJnZS9kcWwvZ3JvdXBieS9Hcm91cEJ5U3RyZWFtTWVyZ2VkUmVzdWx0LmphdmE=) | `94.11% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/merge/dql/orderby/OrderByStreamMergedResult.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4850/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLW1lcmdlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZy9tZXJnZS9kcWwvb3JkZXJieS9PcmRlckJ5U3RyZWFtTWVyZ2VkUmVzdWx0LmphdmE=) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lying/common/config/TypeBasedSPIConfiguration.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4850/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtdW5kZXJseWluZy9zaGFyZGluZ3NwaGVyZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3VuZGVybHlpbmcvY29tbW9uL2NvbmZpZy9UeXBlQmFzZWRTUElDb25maWd1cmF0aW9uLmphdmE=) | `0.00% <0.00%> (-85.72%)` | `0.00% <0.00%> (ø%)` | |
| ... and [112 more](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4850/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4850?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4850?src=pr&el=footer). Last update [6f9294f...b8bdad7](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4850?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services