You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/01/29 17:13:02 UTC
[GitHub] [ozone] adoroszlai opened a new pull request #1856: HDDS-4765. Update close-pending workflow for new repo
adoroszlai opened a new pull request #1856:
URL: https://github.com/apache/ozone/pull/1856
## What changes were proposed in this pull request?
`close-pending` workflow currently [does not execute the script](https://github.com/apache/ozone/runs/1788356301?check_suite_focus=true) due to mismatch in [repository name](https://github.com/apache/ozone/actions/runs/519574297/workflow#L29).
This PR just updates the workflow with the new repo name.
https://issues.apache.org/jira/browse/HDDS-4765
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ayushtkn merged pull request #1856: HDDS-4765. Update close-pending workflow for new repo
Posted by GitBox <gi...@apache.org>.
ayushtkn merged pull request #1856:
URL: https://github.com/apache/ozone/pull/1856
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ayushtkn commented on a change in pull request #1856: HDDS-4765. Update close-pending workflow for new repo
Posted by GitBox <gi...@apache.org>.
ayushtkn commented on a change in pull request #1856:
URL: https://github.com/apache/ozone/pull/1856#discussion_r567202997
##########
File path: .github/workflows/close-pending.yaml
##########
@@ -26,7 +26,7 @@ jobs:
- name: Checkout code
uses: actions/checkout@master
- name: Execute close-pending script
- if: github.repository == 'apache/hadoop-ozone'
+ if: github.repository == 'apache/ozone'
run: ./.github/close-pending.sh
Review comment:
`close-pending.sh` too has mentions of `hadoop-ozone` should we change there as well.
Like
```
"https://api.github.com/search/issues?q=repo:apache/hadoop-ozone+type:pr+updated:<$(date -d "-21 days" +%Y-%m-%d)+label:pending+is:open" \
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ayushtkn commented on pull request #1856: HDDS-4765. Update close-pending workflow for new repo
Posted by GitBox <gi...@apache.org>.
ayushtkn commented on pull request #1856:
URL: https://github.com/apache/ozone/pull/1856#issuecomment-770369949
Thanx @adoroszlai for the contribution!!!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #1856: HDDS-4765. Update close-pending workflow for new repo
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #1856:
URL: https://github.com/apache/ozone/pull/1856#issuecomment-770444553
Thanks @ayushtkn for reviewing and merging it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ayushtkn commented on a change in pull request #1856: HDDS-4765. Update close-pending workflow for new repo
Posted by GitBox <gi...@apache.org>.
ayushtkn commented on a change in pull request #1856:
URL: https://github.com/apache/ozone/pull/1856#discussion_r567202997
##########
File path: .github/workflows/close-pending.yaml
##########
@@ -26,7 +26,7 @@ jobs:
- name: Checkout code
uses: actions/checkout@master
- name: Execute close-pending script
- if: github.repository == 'apache/hadoop-ozone'
+ if: github.repository == 'apache/ozone'
run: ./.github/close-pending.sh
Review comment:
`close-pending.sh` to has mentions of `hadoop-ozone` should we change there as well.
Like
```
"https://api.github.com/search/issues?q=repo:apache/hadoop-ozone+type:pr+updated:<$(date -d "-21 days" +%Y-%m-%d)+label:pending+is:open" \
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on a change in pull request #1856: HDDS-4765. Update close-pending workflow for new repo
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on a change in pull request #1856:
URL: https://github.com/apache/ozone/pull/1856#discussion_r567213523
##########
File path: .github/workflows/close-pending.yaml
##########
@@ -26,7 +26,7 @@ jobs:
- name: Checkout code
uses: actions/checkout@master
- name: Execute close-pending script
- if: github.repository == 'apache/hadoop-ozone'
+ if: github.repository == 'apache/ozone'
run: ./.github/close-pending.sh
Review comment:
Nice catch, thanks. I think it might work due to the redirect, but it's better to change it anyway.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org