You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/04/28 17:41:31 UTC
[GitHub] [apisix-docker] tao12345666333 opened a new pull request #165: feat: build multi arch image
tao12345666333 opened a new pull request #165:
URL: https://github.com/apache/apisix-docker/pull/165
Signed-off-by: Jintao Zhang <zh...@gmail.com>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-docker] gxthrj commented on a change in pull request #165: feat: build multi arch image
Posted by GitBox <gi...@apache.org>.
gxthrj commented on a change in pull request #165:
URL: https://github.com/apache/apisix-docker/pull/165#discussion_r631131965
##########
File path: .github/workflows/apisix_push_docker_hub.yaml
##########
@@ -15,10 +15,27 @@ jobs:
- name: Check out the repo
uses: actions/checkout@v2
+ # Setup Buildx builder
+ - name: Setup Docker Buildx
+ uses: docker/setup-buildx-action@v1
+
+ # Login
- name: Login
- run: echo ${{ secrets.DOCKER_PASSWORD }} | docker login --username=${{ secrets.DOCKER_USERNAME }} --password-stdin
+ uses: docker/login-action@v1
+ with:
+ username: ${{ secrets.DOCKER_USERNAME }}
+ password: ${{ secrets.DOCKER_PASSWORD }}
Review comment:
Thanks for reminding. I applied to them to add secrets.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-docker] Yiyiyimu commented on a change in pull request #165: feat: build multi arch image
Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on a change in pull request #165:
URL: https://github.com/apache/apisix-docker/pull/165#discussion_r630682339
##########
File path: .github/workflows/apisix_push_docker_hub.yaml
##########
@@ -15,10 +15,27 @@ jobs:
- name: Check out the repo
uses: actions/checkout@v2
+ # Setup Buildx builder
+ - name: Setup Docker Buildx
+ uses: docker/setup-buildx-action@v1
+
+ # Login
- name: Login
- run: echo ${{ secrets.DOCKER_PASSWORD }} | docker login --username=${{ secrets.DOCKER_USERNAME }} --password-stdin
+ uses: docker/login-action@v1
+ with:
+ username: ${{ secrets.DOCKER_USERNAME }}
+ password: ${{ secrets.DOCKER_PASSWORD }}
Review comment:
Just notice INFRA has replied and they allow us to set those secrets
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-docker] tao12345666333 commented on pull request #165: feat: build multi arch image
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on pull request #165:
URL: https://github.com/apache/apisix-docker/pull/165#issuecomment-884020218
@Yiyiyimu should I close this one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-docker] tao12345666333 commented on pull request #165: feat: build multi arch image
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on pull request #165:
URL: https://github.com/apache/apisix-docker/pull/165#issuecomment-840200057
> BTW, the CI was failed.
This task is not related to this PR https://github.com/apache/apisix-docker/pull/165/checks?check_run_id=2562574181
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-docker] tao12345666333 commented on pull request #165: feat: build multi arch image
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on pull request #165:
URL: https://github.com/apache/apisix-docker/pull/165#issuecomment-840195969
sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-docker] Yiyiyimu commented on pull request #165: feat: build multi arch image
Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on pull request #165:
URL: https://github.com/apache/apisix-docker/pull/165#issuecomment-878829101
@tao12345666333 Sorry I totally forgot about this PR 🤣
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-docker] gxthrj commented on pull request #165: feat: build multi arch image
Posted by GitBox <gi...@apache.org>.
gxthrj commented on pull request #165:
URL: https://github.com/apache/apisix-docker/pull/165#issuecomment-839854121
I applied to them to add secrets. The ASF will help to add secrets.
ref: https://issues.apache.org/jira/browse/INFRA-21756
BTW, the CI was failed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-docker] Yiyiyimu commented on pull request #165: feat: build multi arch image
Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on pull request #165:
URL: https://github.com/apache/apisix-docker/pull/165#issuecomment-884419184
> @Yiyiyimu should I close this one?
Good to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-docker] tao12345666333 closed pull request #165: feat: build multi arch image
Posted by GitBox <gi...@apache.org>.
tao12345666333 closed pull request #165:
URL: https://github.com/apache/apisix-docker/pull/165
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-docker] gxthrj commented on a change in pull request #165: feat: build multi arch image
Posted by GitBox <gi...@apache.org>.
gxthrj commented on a change in pull request #165:
URL: https://github.com/apache/apisix-docker/pull/165#discussion_r631541761
##########
File path: .github/workflows/apisix_push_docker_hub.yaml
##########
@@ -14,11 +14,30 @@ jobs:
steps:
- name: Check out the repo
uses: actions/checkout@v2
+ with:
+ submodules: recursive
+ # Setup Buildx builder
+ - name: Setup Docker Buildx
+ uses: ./.github/actions/setup-buildx-action
+
+ # Login
- name: Login
- run: echo ${{ secrets.DOCKER_PASSWORD }} | docker login --username=${{ secrets.DOCKER_USERNAME }} --password-stdin
+ uses: ./.github/actions/login-action
+ with:
+ username: ${{ secrets.DOCKER_USERNAME }}
Review comment:
As the [infra](https://issues.apache.org/jira/browse/INFRA-21756) says, need to use as below
secrets.DOCKERHUB_USER
secrets.DOCKERHUB_TOKEN
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-docker] tao12345666333 commented on pull request #165: feat: build multi arch image
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on pull request #165:
URL: https://github.com/apache/apisix-docker/pull/165#issuecomment-839422965
@Yiyiyimu Addressed. PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-docker] tao12345666333 commented on pull request #165: feat: build multi arch image
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on pull request #165:
URL: https://github.com/apache/apisix-docker/pull/165#issuecomment-878803098
@Yiyiyimu Will #197 replace this one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-docker] Yiyiyimu commented on pull request #165: feat: build multi arch image
Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on pull request #165:
URL: https://github.com/apache/apisix-docker/pull/165#issuecomment-828892611
Hi @tao12345666333 we need to use submodule for non-official (not from github or apache) actions ([ref](https://cwiki.apache.org/confluence/display/BUILDS/GitHub+Actions+status#GitHubActionsstatus-Security) and [example](https://github.com/apache/apisix-dashboard/pull/1795))
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-docker] tao12345666333 commented on a change in pull request #165: feat: build multi arch image
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on a change in pull request #165:
URL: https://github.com/apache/apisix-docker/pull/165#discussion_r631542014
##########
File path: .github/workflows/apisix_push_docker_hub.yaml
##########
@@ -14,11 +14,30 @@ jobs:
steps:
- name: Check out the repo
uses: actions/checkout@v2
+ with:
+ submodules: recursive
+ # Setup Buildx builder
+ - name: Setup Docker Buildx
+ uses: ./.github/actions/setup-buildx-action
+
+ # Login
- name: Login
- run: echo ${{ secrets.DOCKER_PASSWORD }} | docker login --username=${{ secrets.DOCKER_USERNAME }} --password-stdin
+ uses: ./.github/actions/login-action
+ with:
+ username: ${{ secrets.DOCKER_USERNAME }}
Review comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-docker] gxthrj commented on a change in pull request #165: feat: build multi arch image
Posted by GitBox <gi...@apache.org>.
gxthrj commented on a change in pull request #165:
URL: https://github.com/apache/apisix-docker/pull/165#discussion_r622685333
##########
File path: .github/workflows/apisix_push_docker_hub.yaml
##########
@@ -15,10 +15,27 @@ jobs:
- name: Check out the repo
uses: actions/checkout@v2
+ # Setup Buildx builder
+ - name: Setup Docker Buildx
+ uses: docker/setup-buildx-action@v1
+
+ # Login
- name: Login
- run: echo ${{ secrets.DOCKER_PASSWORD }} | docker login --username=${{ secrets.DOCKER_USERNAME }} --password-stdin
+ uses: docker/login-action@v1
+ with:
+ username: ${{ secrets.DOCKER_USERNAME }}
+ password: ${{ secrets.DOCKER_PASSWORD }}
Review comment:
Can't set this secret in the apache project for now
We have discussed it before.
https://issues.apache.org/jira/browse/INFRA-21756
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-docker] Yiyiyimu commented on a change in pull request #165: feat: build multi arch image
Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on a change in pull request #165:
URL: https://github.com/apache/apisix-docker/pull/165#discussion_r631340887
##########
File path: .github/workflows/apisix_push_docker_hub.yaml
##########
@@ -14,11 +14,30 @@ jobs:
steps:
- name: Check out the repo
uses: actions/checkout@v2
+ with:
+ submodules: recursive
+ # Setup Buildx builder
+ - name: Setup Docker Buildx
+ uses: ./.github/actions/setup-buildx-action
+
+ # Login
- name: Login
- run: echo ${{ secrets.DOCKER_PASSWORD }} | docker login --username=${{ secrets.DOCKER_USERNAME }} --password-stdin
+ uses: ./.github/actions/login-action
+ with:
+ username: ${{ secrets.DOCKER_USERNAME }}
+ password: ${{ secrets.DOCKER_PASSWORD }}
+
+ # For docker multi arch build
+ - name: Setup QEMU
+ uses: ./.github/actions/setup-qemu-action
- - name: Push apisix image to Docker Hub
- run:
- make build-on-${{ matrix.platform }}
- make push-on-${{ matrix.platform }}
+ - name: Build and push
+ id: docker_build
+ uses: ./.github/actions/build-push-action
+ with:
+ context: .
+ file: ./${{ matrix.platform }}/Dockerfile
+ platforms: linux/amd64,linux/arm64
Review comment:
Why do we need another amd64 image here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-docker] gxthrj commented on pull request #165: feat: build multi arch image
Posted by GitBox <gi...@apache.org>.
gxthrj commented on pull request #165:
URL: https://github.com/apache/apisix-docker/pull/165#issuecomment-840272218
> > BTW, the CI was failed.
>
> This task is not related to this PR https://github.com/apache/apisix-docker/pull/165/checks?check_run_id=2562574181
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org