You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/10/17 23:03:36 UTC
[GitHub] [lucene] janhoy opened a new pull request #391: LUCENE-9997 Second pass smoketester fixes for 9.0
janhoy opened a new pull request #391:
URL: https://github.com/apache/lucene/pull/391
https://issues.apache.org/jira/browse/LUCENE-9997
This is the second pass of changes to smoketester for the new gradle build.
* Adapt to the new source-tgz file layout
* Tested gradlew commands
* Change `--test-java12` with `--test-java17`
* Make Lucene Demo work with new `-Dsmoketester=true`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] janhoy commented on pull request #391: LUCENE-9997 Second pass smoketester fixes for 9.0
Posted by GitBox <gi...@apache.org>.
janhoy commented on pull request #391:
URL: https://github.com/apache/lucene/pull/391#issuecomment-946453138
@mocobeta I got the same as you - looks like LICENSE and NOTICE are not copied into the maven jars. Strange, since they exist in the binary-release jars. Looks like maven task re-build the jars.. Could not the maven task use the pre-built jars that already have NOTICE and LICENSE?
I also notice that `MANIFEST.MF` is empty in the maven jars, simply one line, which is also wrong:
```
Manifest-Version: 1.0
```
I created https://issues.apache.org/jira/browse/LUCENE-10186 for maven artifacts.
Re-opened LUCENE-10174 for the buildAndPushRelease changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] janhoy commented on pull request #391: LUCENE-9997 Second pass smoketester fixes for 9.0
Posted by GitBox <gi...@apache.org>.
janhoy commented on pull request #391:
URL: https://github.com/apache/lucene/pull/391#issuecomment-945210830
The smoketester is tested locally and currently stops at **verify maven artifact sigs**
```
command "gpg --homedir /tmp/smoke_lucene_9.0.0_537d435f5ee7c884221371a59673b878d82f6ffa_18/lucene.gpg --verify /tmp/smoke_lucene_9.0.0_537d435f5ee7c884221371a59673b878d82f6ffa_18/maven/org/apache/lucene/lucene-analysis-common/9.0.0/lucene-analysis-common-9.0.0-javadoc.jar.asc /tmp/smoke_lucene_9.0.0_537d435f5ee7c884221371a59673b878d82f6ffa_18/maven/org/apache/lucene/lucene-analysis-common/9.0.0/lucene-analysis-common-9.0.0-javadoc.jar" failed:
gpg: can't open '/tmp/smoke_lucene_9.0.0_537d435f5ee7c884221371a59673b878d82f6ffa_18/maven/org/apache/lucene/lucene-analysis-common/9.0.0/lucene-analysis-common-9.0.0-javadoc.jar.asc': No such file or directory
gpg: verify signatures failed: No such file or directory
```
Looks like the gradle build does not sign the maven artifacts? @dweiss do you know?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] dweiss commented on pull request #391: LUCENE-9997 Second pass smoketester fixes for 9.0
Posted by GitBox <gi...@apache.org>.
dweiss commented on pull request #391:
URL: https://github.com/apache/lucene/pull/391#issuecomment-946437537
> Or the script could run the main build in parallel and then run just the signing serially.
Sure. Split in two - I also suggested removing "clean" because just rebuilding from scratch should always yield correct task outputs (this isn't ant). So this sequence:
```
gradlew assembleRelease
gradlew assembleRelease -Psign --max-workers 1
```
will rerun some tasks but will sign in a single worker.
We could also order all signing tasks within gradle code (so that they can't run in parallel, no matter what) but it seems like an unnecessary complexity given the infrequent use of the script. I'd rather do the above (or fall back to just specifying --max-workers X, where X is small-ish for gpg signing).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] janhoy merged pull request #391: LUCENE-9997 Second pass smoketester fixes for 9.0
Posted by GitBox <gi...@apache.org>.
janhoy merged pull request #391:
URL: https://github.com/apache/lucene/pull/391
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mocobeta edited a comment on pull request #391: LUCENE-9997 Second pass smoketester fixes for 9.0
Posted by GitBox <gi...@apache.org>.
mocobeta edited a comment on pull request #391:
URL: https://github.com/apache/lucene/pull/391#issuecomment-946544474
@janhoy @dweiss
Commands with `./` do not work on Windows. Yesterday I just tested it on my Windows OS; I saw Command Prompt and PowerShell do not support `./gradlew`, and Python didn't interpret them for Windows.
After I noticed this comment in the file, I deleted the comment... sorry for the noise.
https://github.com/apache/lucene/blob/6c21862a552cccbb8509e4383ac8c6d10c68137f/dev-tools/scripts/smokeTestRelease.py#L43-L45
I think it could be labor to make the scripts OS-agnostic. As for Windows, instead of fully supporting Windows perhaps we could test it on WSL2 then throw away Cygwin? I have little experience with it, but it seems to work just as plain Ubuntu and it's easier to install than Cygwin (its I/O performance was terrible a few years ago, but it should have improved...).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] janhoy edited a comment on pull request #391: LUCENE-9997 Second pass smoketester fixes for 9.0
Posted by GitBox <gi...@apache.org>.
janhoy edited a comment on pull request #391:
URL: https://github.com/apache/lucene/pull/391#issuecomment-946453138
@mocobeta I got the same as you - looks like LICENSE and NOTICE are not copied into the maven jars. Strange, since they exist in the binary-release jars. Looks like maven task re-build the jars.. Could not the maven task use the pre-built jars that already have NOTICE and LICENSE?
I also notice that `MANIFEST.MF` is empty in the maven jars, simply one line, which is also wrong:
```
Manifest-Version: 1.0
```
I created https://issues.apache.org/jira/browse/LUCENE-10186 for maven artifacts.
Re-opened LUCENE-10174 for the buildAndPushRelease changes, https://github.com/apache/lucene/pull/396.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] janhoy commented on pull request #391: LUCENE-9997 Second pass smoketester fixes for 9.0
Posted by GitBox <gi...@apache.org>.
janhoy commented on pull request #391:
URL: https://github.com/apache/lucene/pull/391#issuecomment-945212495
Reporoduce like this
```
git checkout -b janhoy-lucene9997-smoketester-part-2 main
git pull https://github.com/janhoy/lucene.git lucene9997-smoketester-part-2
python3 -u dev-tools/scripts/buildAndPushRelease.py \
--push-local "/tmp/lucene-release" \
--rc-num 1 \
--sign YOUR-KEY-ID \
--gpg-pass-noprompt \
--dev-mode
```
Then run the smoketester command line provided.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] dweiss commented on pull request #391: LUCENE-9997 Second pass smoketester fixes for 9.0
Posted by GitBox <gi...@apache.org>.
dweiss commented on pull request #391:
URL: https://github.com/apache/lucene/pull/391#issuecomment-946072163
I merged with main where the artifact-signing changes landed. The buildAndPushRelease.py works for me (although it does create that stray file so I suspect it won't run properly unless in dev mode).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] janhoy commented on pull request #391: LUCENE-9997 Second pass smoketester fixes for 9.0
Posted by GitBox <gi...@apache.org>.
janhoy commented on pull request #391:
URL: https://github.com/apache/lucene/pull/391#issuecomment-947035468
```
verify maven artifact sigs ................................................................................................................................
unpack lucene-9.0.0.tgz...
verify that Maven artifacts are same as in the binary distribution...
verify JAR metadata/identity/no javax.* or java.* classes...
SUCCESS! [0:09:23.758716]
```
I also added the `--no-daemon` arg to all gradlew commands here.
I'll merge this in now. Then feel free to open further PRs against LUCENE-9997 for smoke tester improvements, such as WSL support etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mocobeta edited a comment on pull request #391: LUCENE-9997 Second pass smoketester fixes for 9.0
Posted by GitBox <gi...@apache.org>.
mocobeta edited a comment on pull request #391:
URL: https://github.com/apache/lucene/pull/391#issuecomment-946304048
With skipping the sign verification (`--not-signed`), smoketester stopped here for me.
```
unpack lucene-9.0.0.tgz...
verify that Maven artifacts are same as in the binary distribution...
verify JAR metadata/identity/no javax.* or java.* classes...
Traceback (most recent call last):
File "/mnt/hdd/repo/lucene/dev-tools/scripts/smokeTestRelease.py", line 134, in checkJARMetaData
if z.getinfo(name) is None:
File "/usr/lib64/python3.9/zipfile.py", line 1429, in getinfo
raise KeyError(
KeyError: "There is no item named 'META-INF/NOTICE.txt' in the archive"
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/mnt/hdd/repo/lucene/dev-tools/scripts/smokeTestRelease.py", line 1180, in <module>
main()
File "/mnt/hdd/repo/lucene/dev-tools/scripts/smokeTestRelease.py", line 1119, in main
smokeTest(c.java, c.url, c.revision, c.version, c.tmp_dir, c.is_signed, c.local_keys, ' '.join(c.test_args),
File "/mnt/hdd/repo/lucene/dev-tools/scripts/smokeTestRelease.py", line 1171, in smokeTest
checkMaven(baseURL, tmpDir, gitRevision, version, isSigned, keysFile)
File "/mnt/hdd/repo/lucene/dev-tools/scripts/smokeTestRelease.py", line 710, in checkMaven
checkAllJARs('%s/maven/org/apache/lucene' % tmpDir, gitRevision, version)
File "/mnt/hdd/repo/lucene/dev-tools/scripts/smokeTestRelease.py", line 206, in checkAllJARs
checkJARMetaData('JAR file "%s"' % fullPath, fullPath, gitRevision, version)
File "/mnt/hdd/repo/lucene/dev-tools/scripts/smokeTestRelease.py", line 137, in checkJARMetaData
raise RuntimeError('%s is missing %s' % (desc, name))
RuntimeError: JAR file "/tmp/smoke_lucene_9.0.0_6f67e8287f19c4b3fedfaacc0312f987fcd2d5b7/maven/org/apache/lucene/lucene-test-framework/9.0.0/lucene-test-framework-9.0.0-sources.jar" is missing META-INF/NOTICE.txt
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mocobeta commented on a change in pull request #391: LUCENE-9997 Second pass smoketester fixes for 9.0
Posted by GitBox <gi...@apache.org>.
mocobeta commented on a change in pull request #391:
URL: https://github.com/apache/lucene/pull/391#discussion_r731013013
##########
File path: dev-tools/scripts/smokeTestRelease.py
##########
@@ -1033,7 +1030,7 @@ def confirmAllReleasesAreTestedForBackCompat(smokeVersion, unpackPath):
os.chdir(unpackPath)
print(' run TestBackwardsCompatibility..')
- command = 'gradlew test -p lucene/backward-codecs --tests TestBackwardsCompatibility --max-workers=1 ' \
+ command = './gradlew test -p lucene/backward-codecs --tests TestBackwardsCompatibility --max-workers=1 ' \
Review comment:
Does this work on Windows?
I haven't tried it on Windows but just noticed this script doesn't append `./` to commands in branch_8x.
For example:
https://github.com/apache/lucene-solr/blob/277e1e064559117ccbc3004be88160bf24380d55/dev-tools/scripts/smokeTestRelease.py#L1326
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] janhoy commented on pull request #391: LUCENE-9997 Second pass smoketester fixes for 9.0
Posted by GitBox <gi...@apache.org>.
janhoy commented on pull request #391:
URL: https://github.com/apache/lucene/pull/391#issuecomment-946481179
@mocobeta I think you asked whether the `./gradlew` commands are windows safe. I really don't know. I see tons of `/` in that script so perhaps python translates it? I don't use Windows so cannot test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] dweiss commented on pull request #391: LUCENE-9997 Second pass smoketester fixes for 9.0
Posted by GitBox <gi...@apache.org>.
dweiss commented on pull request #391:
URL: https://github.com/apache/lucene/pull/391#issuecomment-946494828
I use Windows - these scripts are not compatible. I don't think we have to make it a priority to make them compatible. Too many variables to think of.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mocobeta commented on pull request #391: LUCENE-9997 Second pass smoketester fixes for 9.0
Posted by GitBox <gi...@apache.org>.
mocobeta commented on pull request #391:
URL: https://github.com/apache/lucene/pull/391#issuecomment-946544474
@janhoy @dweiss
Commands with `./` do not work on Windows. Yesterday I just tested it on my Windows OS; I saw Command Prompt and PowerShell do not support `./gradlew`.
After I noticed this comment in the file, I deleted the comment... sorry for the noise.
https://github.com/apache/lucene/blob/6c21862a552cccbb8509e4383ac8c6d10c68137f/dev-tools/scripts/smokeTestRelease.py#L43-L45
I think it could be labor to make the scripts OS-agnostic. As for Windows, instead of fully supporting Windows perhaps we could test it on WSL2 then throw away Cygwin? I have little experience with it, but it seems to work just as plain Ubuntu and it's easier to install than Cygwin (its I/O performance was terrible a few years ago, but it should have improved...).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] janhoy commented on pull request #391: LUCENE-9997 Second pass smoketester fixes for 9.0
Posted by GitBox <gi...@apache.org>.
janhoy commented on pull request #391:
URL: https://github.com/apache/lucene/pull/391#issuecomment-946219082
> I merged with main where the artifact-signing changes landed. The buildAndPushRelease.py works for me (although it does create that stray file so I suspect it won't run properly unless in dev mode).
Thanks. I get the `gpg: signing failed: Cannot allocate memory` error with gpg, caused by gpg daemon running out of mem during many parallell signing commands. I found a workaround by adding `auto-expand-secmem` to `~/.gnupg/gpg-agent.conf` and then running `gpg-connect-agent killagent /bye` to restart the agent, and it works. This could perhaps be documented as a prerequisite for using gpg, if you don't want to run serially. Or the script could run the main build in parallel and then run just the signing serially.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] dweiss commented on pull request #391: LUCENE-9997 Second pass smoketester fixes for 9.0
Posted by GitBox <gi...@apache.org>.
dweiss commented on pull request #391:
URL: https://github.com/apache/lucene/pull/391#issuecomment-946571894
I'm really fine with these scripts working just on Unix-ish systems. If you really want to, WSL or a virtual machines is a fine workaround for Windows users (like you or me). Like I said - to many variables to consider (file permissions are notoriously annoying to get right).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mocobeta commented on a change in pull request #391: LUCENE-9997 Second pass smoketester fixes for 9.0
Posted by GitBox <gi...@apache.org>.
mocobeta commented on a change in pull request #391:
URL: https://github.com/apache/lucene/pull/391#discussion_r731013013
##########
File path: dev-tools/scripts/smokeTestRelease.py
##########
@@ -1033,7 +1030,7 @@ def confirmAllReleasesAreTestedForBackCompat(smokeVersion, unpackPath):
os.chdir(unpackPath)
print(' run TestBackwardsCompatibility..')
- command = 'gradlew test -p lucene/backward-codecs --tests TestBackwardsCompatibility --max-workers=1 ' \
+ command = './gradlew test -p lucene/backward-codecs --tests TestBackwardsCompatibility --max-workers=1 ' \
Review comment:
Is this work on Windows?
I haven't tried it on Windows but just noticed this script doesn't append `./` to commands in branch_8x.
For example:
https://github.com/apache/lucene-solr/blob/277e1e064559117ccbc3004be88160bf24380d55/dev-tools/scripts/smokeTestRelease.py#L1326
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mocobeta commented on a change in pull request #391: LUCENE-9997 Second pass smoketester fixes for 9.0
Posted by GitBox <gi...@apache.org>.
mocobeta commented on a change in pull request #391:
URL: https://github.com/apache/lucene/pull/391#discussion_r731075943
##########
File path: dev-tools/scripts/smokeTestRelease.py
##########
@@ -539,58 +529,72 @@ def unpackAndVerify(java, tmpDir, artifact, gitRevision, version, testArgs):
LUCENE_LICENSE = None
+def is_in_list(in_folder, files, indent=4):
Review comment:
nice refactoring!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] dweiss edited a comment on pull request #391: LUCENE-9997 Second pass smoketester fixes for 9.0
Posted by GitBox <gi...@apache.org>.
dweiss edited a comment on pull request #391:
URL: https://github.com/apache/lucene/pull/391#issuecomment-946437537
> Or the script could run the main build in parallel and then run just the signing serially.
Sure. Split in two - I also suggested removing "clean" because rebuilding from any state should always yield correct task outputs (this isn't ant where you have to clean leftovers over and over). So this sequence:
```
gradlew assembleRelease
gradlew assembleRelease -Psign --max-workers 1
```
will rerun some tasks but will sign in a single worker.
We could also order all signing tasks within gradle code (so that they can't run in parallel, no matter what) but it seems like an unnecessary complexity given the infrequent use of the script. I'd rather do the above (or fall back to just specifying --max-workers X, where X is small-ish for gpg signing).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mocobeta commented on pull request #391: LUCENE-9997 Second pass smoketester fixes for 9.0
Posted by GitBox <gi...@apache.org>.
mocobeta commented on pull request #391:
URL: https://github.com/apache/lucene/pull/391#issuecomment-946304048
With skipping sthe ign verification (`--not-signed`), smoketester stopped here for me.
```
unpack lucene-9.0.0.tgz...
verify that Maven artifacts are same as in the binary distribution...
verify JAR metadata/identity/no javax.* or java.* classes...
Traceback (most recent call last):
File "/mnt/hdd/repo/lucene/dev-tools/scripts/smokeTestRelease.py", line 134, in checkJARMetaData
if z.getinfo(name) is None:
File "/usr/lib64/python3.9/zipfile.py", line 1429, in getinfo
raise KeyError(
KeyError: "There is no item named 'META-INF/NOTICE.txt' in the archive"
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/mnt/hdd/repo/lucene/dev-tools/scripts/smokeTestRelease.py", line 1180, in <module>
main()
File "/mnt/hdd/repo/lucene/dev-tools/scripts/smokeTestRelease.py", line 1119, in main
smokeTest(c.java, c.url, c.revision, c.version, c.tmp_dir, c.is_signed, c.local_keys, ' '.join(c.test_args),
File "/mnt/hdd/repo/lucene/dev-tools/scripts/smokeTestRelease.py", line 1171, in smokeTest
checkMaven(baseURL, tmpDir, gitRevision, version, isSigned, keysFile)
File "/mnt/hdd/repo/lucene/dev-tools/scripts/smokeTestRelease.py", line 710, in checkMaven
checkAllJARs('%s/maven/org/apache/lucene' % tmpDir, gitRevision, version)
File "/mnt/hdd/repo/lucene/dev-tools/scripts/smokeTestRelease.py", line 206, in checkAllJARs
checkJARMetaData('JAR file "%s"' % fullPath, fullPath, gitRevision, version)
File "/mnt/hdd/repo/lucene/dev-tools/scripts/smokeTestRelease.py", line 137, in checkJARMetaData
raise RuntimeError('%s is missing %s' % (desc, name))
RuntimeError: JAR file "/tmp/smoke_lucene_9.0.0_6f67e8287f19c4b3fedfaacc0312f987fcd2d5b7/maven/org/apache/lucene/lucene-test-framework/9.0.0/lucene-test-framework-9.0.0-sources.jar" is missing META-INF/NOTICE.txt
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org