You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2020/03/11 15:11:16 UTC
[kudu-CR] [build] Fix relocate binaries for mini cluster.py on Python 3
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15405
Change subject: [build] Fix relocate_binaries_for_mini_cluster.py on Python 3
......................................................................
[build] Fix relocate_binaries_for_mini_cluster.py on Python 3
This patch fixes relocate_binaries_for_mini_cluster.py on Python 3
by ignoring decode failures on string like objects.
This keeps Python 2 compatibility as well.
Change-Id: I792edd867546315baa05b15c711c72f456bb5bd3
---
M build-support/mini-cluster/relocate_binaries_for_mini_cluster.py
1 file changed, 13 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/05/15405/1
--
To view, visit http://gerrit.cloudera.org:8080/15405
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I792edd867546315baa05b15c711c72f456bb5bd3
Gerrit-Change-Number: 15405
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] [build] Fix relocate binaries for mini cluster.py on Python 3
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15405 )
Change subject: [build] Fix relocate_binaries_for_mini_cluster.py on Python 3
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15405/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/15405/1//COMMIT_MSG@10
PS1, Line 10: by ignoring decode failures on string like objects.
Are such failures expected? If not, why not let the exception percolate up and kill the script?
--
To view, visit http://gerrit.cloudera.org:8080/15405
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I792edd867546315baa05b15c711c72f456bb5bd3
Gerrit-Change-Number: 15405
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 11 Mar 2020 16:04:50 +0000
Gerrit-HasComments: Yes
[kudu-CR] [build] Fix relocate binaries for mini cluster.py on Python 3
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15405 )
Change subject: [build] Fix relocate_binaries_for_mini_cluster.py on Python 3
......................................................................
[build] Fix relocate_binaries_for_mini_cluster.py on Python 3
This patch fixes relocate_binaries_for_mini_cluster.py on Python 3
by ignoring decode failures on string like objects.
This keeps Python 2 compatibility as well.
Change-Id: I792edd867546315baa05b15c711c72f456bb5bd3
Reviewed-on: http://gerrit.cloudera.org:8080/15405
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M build-support/mini-cluster/relocate_binaries_for_mini_cluster.py
1 file changed, 13 insertions(+), 2 deletions(-)
Approvals:
Kudu Jenkins: Verified
Adar Dembo: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/15405
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I792edd867546315baa05b15c711c72f456bb5bd3
Gerrit-Change-Number: 15405
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [build] Fix relocate binaries for mini cluster.py on Python 3
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15405 )
Change subject: [build] Fix relocate_binaries_for_mini_cluster.py on Python 3
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15405/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/15405/1//COMMIT_MSG@10
PS1, Line 10: by ignoring decode failures on string like objects.
> Are such failures expected? If not, why not let the exception percolate up
In Python 2 the objects are binary like, in Python 3 they are string like. It seems the most widely accepted way to handle this is to try and decode to get a string like oject and ignore the failure since the object is already string like.
--
To view, visit http://gerrit.cloudera.org:8080/15405
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I792edd867546315baa05b15c711c72f456bb5bd3
Gerrit-Change-Number: 15405
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 11 Mar 2020 16:08:08 +0000
Gerrit-HasComments: Yes