You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/06/25 13:23:52 UTC

[GitHub] [incubator-tvm] giuseros opened a new pull request #5925: Fix small typo in nn.conv2d_gemm_weight_transform

giuseros opened a new pull request #5925:
URL: https://github.com/apache/incubator-tvm/pull/5925


   This is fixing a small typo in `conv2d_gemm_weight_transform` which causes the compilation to fail for AArch64 (NHWC) targets. 
   
   Change-Id: I7844d898ebf82592f78f478982262ef95f83cc3e
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] giuseros commented on pull request #5925: Fix small typo in nn.conv2d_gemm_weight_transform

Posted by GitBox <gi...@apache.org>.
giuseros commented on pull request #5925:
URL: https://github.com/apache/incubator-tvm/pull/5925#issuecomment-650521530


   Hi @tqchen,
   I was off yesterday. Is it ok if I work on this on Monday?
   Sorry about that


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] giuseros edited a comment on pull request #5925: Fix small typo in nn.conv2d_gemm_weight_transform

Posted by GitBox <gi...@apache.org>.
giuseros edited a comment on pull request #5925:
URL: https://github.com/apache/incubator-tvm/pull/5925#issuecomment-651082114


   Hi @tqchen ,
   I followed the same approach for the other conv2ds. I added a `test_conv2d_nhwc` in the `test_topi_conv2d_int8.py`. This would have caught the typo we are discussing, and I was able also to fix another small typo in `conv2d_gemm.py` (which had to do with wrong TIR operator precedence). 
   
   Please, let me know what do you think. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] tqchen commented on pull request #5925: Fix small typo in nn.conv2d_gemm_weight_transform

Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #5925:
URL: https://github.com/apache/incubator-tvm/pull/5925#issuecomment-649753751


   Thanks @giuseros can you add a regression test case as per https://tvm.apache.org/docs/contribute/code_review.html#ensure-test-coverage? 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] tqchen commented on pull request #5925: Fix small typo in nn.conv2d_gemm_weight_transform

Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #5925:
URL: https://github.com/apache/incubator-tvm/pull/5925#issuecomment-650457793


   ping @giuseros 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] giuseros commented on pull request #5925: Fix small typo in nn.conv2d_gemm_weight_transform

Posted by GitBox <gi...@apache.org>.
giuseros commented on pull request #5925:
URL: https://github.com/apache/incubator-tvm/pull/5925#issuecomment-651718265


   Hi @tqchen , 
   Any update on this?
   
   Thanks a lot


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] giuseros commented on pull request #5925: Fix small typo in nn.conv2d_gemm_weight_transform

Posted by GitBox <gi...@apache.org>.
giuseros commented on pull request #5925:
URL: https://github.com/apache/incubator-tvm/pull/5925#issuecomment-651082114


   Hi @tqchen ,
   I followed the same approach for the other conv2ds. I added a `test_conv2d_nhwc` in the `test_topi_conv2d_int8.py`. This would have caught the typo we are discussing, and I was able also to fix another small typo in `conv2d_gemm.py` (which had to do with wrong operator precedence). 
   
   Please, let me know what do you think. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] giuseros commented on pull request #5925: Fix small typo in nn.conv2d_gemm_weight_transform

Posted by GitBox <gi...@apache.org>.
giuseros commented on pull request #5925:
URL: https://github.com/apache/incubator-tvm/pull/5925#issuecomment-649539144


   cc @anijain2305 @FrozenGene @u99127 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] tqchen commented on pull request #5925: Fix small typo in nn.conv2d_gemm_weight_transform

Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #5925:
URL: https://github.com/apache/incubator-tvm/pull/5925#issuecomment-650575919


   feel free to take your time


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org