You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "gavinchou (via GitHub)" <gi...@apache.org> on 2024/01/14 04:01:14 UTC

[PR] [chore](Fix) Fix uninitilized buffer in read_cluster_id() [doris]

gavinchou opened a new pull request, #29949:
URL: https://github.com/apache/doris/pull/29949

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [chore](Fix) Fix uninitilized buffer in read_cluster_id() [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29949:
URL: https://github.com/apache/doris/pull/29949#issuecomment-1890846676

   (From new machine)TeamCity pipeline, clickbench performance test result:
    the sum of best hot time: 46.65 seconds
    stream load tsv:          561 seconds loaded 74807831229 Bytes, about 127 MB/s
    stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
    stream load orc:          65 seconds loaded 1101869774 Bytes, about 16 MB/s
    stream load parquet:          32 seconds loaded 861443392 Bytes, about 25 MB/s
    insert into select:          21.7 seconds inserted 10000000 Rows, about 460K ops/s
    storage size: 17183867786 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [chore](Fix) Fix uninitilized buffer in read_cluster_id() [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29949:
URL: https://github.com/apache/doris/pull/29949#issuecomment-1890846325

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 179300 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit bdffc330a5b1fbf2a0d0d4c39f8c9342c749062c, data reload: false
   
   query1	937	332	324	324
   query2	6717	1845	1910	1845
   query3	6725	223	209	209
   query4	30240	22226	21973	21973
   query5	6961	549	572	549
   query6	266	191	188	188
   query7	4621	286	273	273
   query8	227	198	198	198
   query9	9089	2737	2745	2737
   query10	600	248	244	244
   query11	17144	15269	15312	15269
   query12	125	70	70	70
   query13	1704	375	390	375
   query14	11213	7403	7395	7395
   query15	207	182	184	182
   query16	4620	253	258	253
   query17	1013	488	476	476
   query18	1797	268	258	258
   query19	184	148	150	148
   query20	79	79	75	75
   query21	207	124	123	123
   query22	5259	4967	4888	4888
   query23	31728	31069	30952	30952
   query24	12754	2864	2804	2804
   query25	574	328	331	328
   query26	1834	163	157	157
   query27	3571	276	283	276
   query28	7429	1850	1832	1832
   query29	2220	707	707	707
   query30	291	142	142	142
   query31	944	754	768	754
   query32	88	65	60	60
   query33	720	244	246	244
   query34	1332	465	483	465
   query35	878	781	755	755
   query36	1368	1225	1242	1225
   query37	182	69	73	69
   query38	3391	3286	3307	3286
   query39	1316	1259	1263	1259
   query40	345	107	99	99
   query41	44	36	36	36
   query42	101	102	98	98
   query43	549	457	475	457
   query44	1116	700	717	700
   query45	202	185	186	185
   query46	1076	636	656	636
   query47	1674	1655	1591	1591
   query48	389	326	314	314
   query49	1249	324	313	313
   query50	710	323	328	323
   query51	5270	5192	5189	5189
   query52	109	94	100	94
   query53	355	301	283	283
   query54	890	448	463	448
   query55	95	91	88	88
   query56	226	196	192	192
   query57	1041	940	981	940
   query58	224	193	192	192
   query59	2875	2780	2661	2661
   query60	231	238	233	233
   query61	86	92	87	87
   query62	669	410	400	400
   query63	320	294	295	294
   query64	6258	1680	1687	1680
   query65	3351	3250	3252	3250
   query66	1458	339	313	313
   query67	15847	15643	15434	15434
   query68	11509	522	528	522
   query69	622	340	335	335
   query70	1701	1522	1532	1522
   query71	492	236	252	236
   query72	4815	2837	2856	2837
   query73	2621	333	321	321
   query74	7185	6451	6551	6451
   query75	4647	2374	2318	2318
   query76	5850	955	988	955
   query77	659	294	269	269
   query78	9120	8950	8740	8740
   query79	1009	533	513	513
   query80	524	342	355	342
   query81	446	203	205	203
   query82	207	92	89	89
   query83	149	124	123	123
   query84	282	75	81	75
   query85	1043	341	325	325
   query86	388	350	380	350
   query87	3561	3400	3387	3387
   query88	2939	2292	2287	2287
   query89	475	389	385	385
   query90	1988	211	203	203
   query91	162	128	124	124
   query92	66	56	56	56
   query93	1409	432	433	432
   query94	1222	177	181	177
   query95	522	491	468	468
   query96	629	323	329	323
   query97	4319	4149	4131	4131
   query98	221	192	191	191
   query99	1069	753	713	713
   Total cold run time: 299166 ms
   Total hot run time: 179300 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [chore](Fix) Fix uninitilized buffer in read_cluster_id() [doris]

Posted by "gavinchou (via GitHub)" <gi...@apache.org>.
gavinchou commented on PR #29949:
URL: https://github.com/apache/doris/pull/29949#issuecomment-1890839406

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [chore](Fix) Fix uninitilized buffer in read_cluster_id() [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #29949:
URL: https://github.com/apache/doris/pull/29949#issuecomment-1890840994

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [chore](Fix) Fix uninitilized buffer in read_cluster_id() [doris]

Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #29949:
URL: https://github.com/apache/doris/pull/29949


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [chore](Fix) Fix uninitilized buffer in read_cluster_id() [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29949:
URL: https://github.com/apache/doris/pull/29949#issuecomment-1890844484

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 39985 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit bdffc330a5b1fbf2a0d0d4c39f8c9342c749062c, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	17988	5805	5740	5740
   q2	2045	152	133	133
   q3	10860	1113	1112	1112
   q4	10501	826	845	826
   q5	7844	3167	3150	3150
   q6	204	124	124	124
   q7	897	507	491	491
   q8	9272	2012	2013	2012
   q9	7294	6421	6384	6384
   q10	8216	3089	3085	3085
   q11	413	214	224	214
   q12	359	200	202	200
   q13	18118	3443	3413	3413
   q14	252	220	219	219
   q15	549	514	511	511
   q16	431	385	383	383
   q17	951	513	530	513
   q18	7699	7101	7058	7058
   q19	1637	1353	1332	1332
   q20	576	336	304	304
   q21	2901	2461	2454	2454
   q22	392	327	327	327
   Total cold run time: 109399 ms
   Total hot run time: 39985 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	5831	5659	5758	5659
   q2	353	239	226	226
   q3	3369	3060	3157	3060
   q4	2207	2138	2044	2044
   q5	6050	6026	5981	5981
   q6	204	123	117	117
   q7	2437	2009	1984	1984
   q8	3534	3956	3655	3655
   q9	9680	21589	9797	9797
   q10	7840	3739	3844	3739
   q11	607	459	457	457
   q12	1221	663	668	663
   q13	19131	3379	3248	3248
   q14	366	272	310	272
   q15	599	534	522	522
   q16	608	505	516	505
   q17	6434	2138	2105	2105
   q18	9929	12513	10010	10010
   q19	13969	1659	1652	1652
   q20	3943	1994	1919	1919
   q21	17143	6644	5701	5701
   q22	1084	617	614	614
   Total cold run time: 116539 ms
   Total hot run time: 63930 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [chore](Fix) Fix uninitilized buffer in read_cluster_id() [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29949:
URL: https://github.com/apache/doris/pull/29949#issuecomment-1890853708

   TeamCity be ut coverage result:
    Function Coverage: 36.69% (8646/23566) 
    Line Coverage: 28.71% (70425/245311)
    Region Coverage: 27.61% (36389/131776)
    Branch Coverage: 24.34% (18616/76480)
    Coverage Report: http://coverage.selectdb-in.cc/coverage/bdffc330a5b1fbf2a0d0d4c39f8c9342c749062c_bdffc330a5b1fbf2a0d0d4c39f8c9342c749062c/report/index.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [chore](Fix) Fix uninitilized buffer in read_cluster_id() [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29949:
URL: https://github.com/apache/doris/pull/29949#issuecomment-1890847507

   
   Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   ```
   Load test result on commit bdffc330a5b1fbf2a0d0d4c39f8c9342c749062c with default session variables
   Stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
   Stream load orc:          58 seconds loaded 1101869774 Bytes, about 18 MB/s
   Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
   Insert into select:       12.7 seconds inserted 10000000 Rows, about 787K ops/s
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [chore](Fix) Fix uninitilized buffer in read_cluster_id() [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #29949:
URL: https://github.com/apache/doris/pull/29949#issuecomment-1890844571

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [chore](Fix) Fix uninitilized buffer in read_cluster_id() [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29949:
URL: https://github.com/apache/doris/pull/29949#issuecomment-1890847074

   
   <details>
   <summary>ClickBench: <b>Total hot run time: 30.68 s</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit bdffc330a5b1fbf2a0d0d4c39f8c9342c749062c, data reload: false
   
   query1	0.06	0.05	0.06
   query2	0.06	0.02	0.02
   query3	0.25	0.12	0.11
   query4	1.76	0.12	0.12
   query5	0.53	0.53	0.53
   query6	1.36	0.65	0.66
   query7	0.02	0.01	0.01
   query8	0.03	0.02	0.02
   query9	0.56	0.50	0.51
   query10	0.55	0.56	0.56
   query11	0.12	0.09	0.09
   query12	0.12	0.10	0.09
   query13	0.60	0.61	0.60
   query14	0.78	0.80	0.80
   query15	0.79	0.78	0.77
   query16	0.37	0.37	0.38
   query17	1.01	1.04	1.02
   query18	0.22	0.24	0.25
   query19	1.86	1.78	1.80
   query20	0.02	0.01	0.01
   query21	15.40	0.58	0.56
   query22	2.56	3.18	1.88
   query23	17.04	0.89	0.75
   query24	16.46	0.59	0.58
   query25	2.16	0.16	0.15
   query26	0.14	0.13	0.13
   query27	0.14	0.15	0.16
   query28	5.72	0.82	0.78
   query29	12.54	3.12	3.07
   query30	0.52	0.54	0.49
   query31	2.78	0.33	0.35
   query32	3.37	0.48	0.50
   query33	3.22	3.21	3.22
   query34	15.76	4.24	4.28
   query35	4.22	4.21	4.28
   query36	1.12	1.09	1.08
   query37	0.07	0.05	0.04
   query38	0.03	0.02	0.02
   query39	0.03	0.02	0.01
   query40	0.16	0.13	0.13
   query41	0.07	0.02	0.02
   query42	0.03	0.02	0.01
   query43	0.03	0.02	0.02
   Total cold run time: 114.64 s
   Total hot run time: 30.68 s
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [chore](Fix) Fix uninitilized buffer in read_cluster_id() [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #29949:
URL: https://github.com/apache/doris/pull/29949#issuecomment-1890844577

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org