You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Henri Yandell (JIRA)" <ji...@apache.org> on 2008/05/11 07:01:55 UTC

[jira] Created: (LANG-437) Complaints that the IE fix for StringEscapeUtils.escapeJavaScript is causing problems elsewhere. Rollback?

Complaints that the IE fix for StringEscapeUtils.escapeJavaScript is causing problems elsewhere. Rollback?
----------------------------------------------------------------------------------------------------------

                 Key: LANG-437
                 URL: https://issues.apache.org/jira/browse/LANG-437
             Project: Commons Lang
          Issue Type: Bug
    Affects Versions: 2.4
            Reporter: Henri Yandell
             Fix For: 3.0


Need to decide if we should roll LANG-363 back or not. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (LANG-437) Complaints that the IE fix for StringEscapeUtils.escapeJavaScript is causing problems elsewhere. Rollback?

Posted by "Niall Pemberton (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LANG-437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Niall Pemberton updated LANG-437:
---------------------------------

    Fix Version/s:     (was: 3.0)
                   2.5

> Complaints that the IE fix for StringEscapeUtils.escapeJavaScript is causing problems elsewhere. Rollback?
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: LANG-437
>                 URL: https://issues.apache.org/jira/browse/LANG-437
>             Project: Commons Lang
>          Issue Type: Bug
>          Components: lang.*
>    Affects Versions: 2.4
>            Reporter: Henri Yandell
>             Fix For: 2.5
>
>
> Need to decide if we should roll LANG-363 back or not. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (LANG-437) Complaints that the IE fix for StringEscapeUtils.escapeJavaScript is causing problems elsewhere. Rollback?

Posted by "Henri Yandell (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LANG-437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12635206#action_12635206 ] 

Henri Yandell commented on LANG-437:
------------------------------------

Does LANG-421 not fix this for you?

> Complaints that the IE fix for StringEscapeUtils.escapeJavaScript is causing problems elsewhere. Rollback?
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: LANG-437
>                 URL: https://issues.apache.org/jira/browse/LANG-437
>             Project: Commons Lang
>          Issue Type: Bug
>    Affects Versions: 2.4
>            Reporter: Henri Yandell
>             Fix For: 3.0
>
>
> Need to decide if we should roll LANG-363 back or not. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (LANG-437) Complaints that the IE fix for StringEscapeUtils.escapeJavaScript is causing problems elsewhere. Rollback?

Posted by "Henri Yandell (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LANG-437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Henri Yandell closed LANG-437.
------------------------------

    Resolution: Duplicate

Problems are because the escapeJavaScript change leaked into escapeJava due to shared code. Fixed in LANG-421.

> Complaints that the IE fix for StringEscapeUtils.escapeJavaScript is causing problems elsewhere. Rollback?
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: LANG-437
>                 URL: https://issues.apache.org/jira/browse/LANG-437
>             Project: Commons Lang
>          Issue Type: Bug
>    Affects Versions: 2.4
>            Reporter: Henri Yandell
>             Fix For: 3.0
>
>
> Need to decide if we should roll LANG-363 back or not. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (LANG-437) Complaints that the IE fix for StringEscapeUtils.escapeJavaScript is causing problems elsewhere. Rollback?

Posted by "Bob Fields (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LANG-437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12633917#action_12633917 ] 

Bob Fields commented on LANG-437:
---------------------------------

This change broke our application www.andromda.org. We use StringEscapeUtils to fix documentation contained in Strings for inclusion in Java files and then compile those java files, resulting in the error:

Invalid escape sequence (valid ones are  \b  \t  \n  \f  \r  \"  \'  \\ )

Note that \/ is not a valid String escape sequence.

Should use escapeJavaScript if String is meant to be used in html or XML environment rather than in a Java environment.

See also https://issues.apache.org/jira/browse/LANG-421.

> Complaints that the IE fix for StringEscapeUtils.escapeJavaScript is causing problems elsewhere. Rollback?
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: LANG-437
>                 URL: https://issues.apache.org/jira/browse/LANG-437
>             Project: Commons Lang
>          Issue Type: Bug
>    Affects Versions: 2.4
>            Reporter: Henri Yandell
>             Fix For: 3.0
>
>
> Need to decide if we should roll LANG-363 back or not. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.