You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@lucene.apache.org by "Robert Muir (JIRA)" <ji...@apache.org> on 2014/05/02 18:36:15 UTC

[jira] [Created] (LUCENE-5638) Default Attributes are expensive

Robert Muir created LUCENE-5638:
-----------------------------------

             Summary: Default Attributes are expensive
                 Key: LUCENE-5638
                 URL: https://issues.apache.org/jira/browse/LUCENE-5638
             Project: Lucene - Core
          Issue Type: Bug
          Components: modules/analysis
            Reporter: Robert Muir


Changes like LUCENE-5634 make it clear that the default AttributeFactory stuff has a very high cost: weakmaps/reflection/etc.

Additionally I think clearAttributes() is more expensive than it should be: it has to traverse a linked-list, calling clear() per token.

Operations like cloning (save/restoreState) have a high cost tll.

Maybe we can have a better Default? In other words, rename DEFAULT_ATTRIBUTE_FACTORY to REFLECTION_ATTRIBUTE_FACTORY, and instead have a faster default factory that just has one AttributeImpl with the "core ones" that 95% of users are dealing with (TOKEN_ATTRIBUTE_FACTORY?): anything outside of that falls back to reflection.




--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org