You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@beam.apache.org by GitBox <gi...@apache.org> on 2020/03/13 22:57:31 UTC

[GitHub] [beam] lukecwik edited a comment on issue #9758: [BEAM-8374] Enable returning missing PublishResult fields in SnsIO.Write

lukecwik edited a comment on issue #9758: [BEAM-8374] Enable returning missing PublishResult fields in SnsIO.Write
URL: https://github.com/apache/beam/pull/9758#issuecomment-598964756
 
 
   > One last question @lukecwik, would you prefer to apply these changes in amazon-web-services2 in this PR? Or should we take that to a separate PR? That might be a good opportunity to discuss making some improvements to how errors are handled in this IO. In my opinion it's somewhat suboptimal that `IOException`s and the like are handled in the IO but HTTP error responses have to be handled in the caller, for example.
   
   I would prefer a separate PR so that people can start using this sooner then later. Also smaller PRs are easier to review.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services