You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "liquanfeng (via GitHub)" <gi...@apache.org> on 2023/05/26 07:54:14 UTC

[GitHub] [tvm] liquanfeng opened a new pull request, #14963: [Bugfix][PyTorch] Support use_input_stats in instance_norm

liquanfeng opened a new pull request, #14963:
URL: https://github.com/apache/tvm/pull/14963

   Fix #14926 .
   The input should be normalized with the provided running mean and running variance instead of computing the mean and variance from the input data when use_input_stats is set to false.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] liquanfeng commented on a diff in pull request #14963: [Bugfix][PyTorch] Support use_input_stats in instance_norm

Posted by "liquanfeng (via GitHub)" <gi...@apache.org>.
liquanfeng commented on code in PR #14963:
URL: https://github.com/apache/tvm/pull/14963#discussion_r1207851860


##########
python/tvm/relay/frontend/pytorch.py:
##########
@@ -1385,6 +1385,9 @@ def instance_norm(self, inputs, input_types):
         data = inputs[0]
         data_type = input_types[0]
         channels = self.infer_shape(data)
+        running_mean = inputs[3]

Review Comment:
   The latter I think. The "track_running_stats" has been ignored in the unit test.
   By the way, there will be another PR later about BC, also on a similar issue.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tvm-bot commented on pull request #14963: [Bugfix][PyTorch] Support use_input_stats in instance_norm

Posted by "tvm-bot (via GitHub)" <gi...@apache.org>.
tvm-bot commented on PR #14963:
URL: https://github.com/apache/tvm/pull/14963#issuecomment-1563963262

   <!---bot-comment-->
   
   Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
   
   <!--bot-comment-ccs-start-->
    * cc @shingjan, @yelite <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
   
   <sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] shingjan commented on a diff in pull request #14963: [Bugfix][PyTorch] Support use_input_stats in instance_norm

Posted by "shingjan (via GitHub)" <gi...@apache.org>.
shingjan commented on code in PR #14963:
URL: https://github.com/apache/tvm/pull/14963#discussion_r1207192485


##########
python/tvm/relay/frontend/pytorch.py:
##########
@@ -1385,6 +1385,9 @@ def instance_norm(self, inputs, input_types):
         data = inputs[0]
         data_type = input_types[0]
         channels = self.infer_shape(data)
+        running_mean = inputs[3]

Review Comment:
   Is this a most recent api change from pytorch or a long ignored params on our side? The former will need us to think about BC.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] masahi merged pull request #14963: [Bugfix][PyTorch] Support use_input_stats in instance_norm

Posted by "masahi (via GitHub)" <gi...@apache.org>.
masahi merged PR #14963:
URL: https://github.com/apache/tvm/pull/14963


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org