You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by st...@apache.org on 2014/02/11 00:23:09 UTC
[03/15] git commit: Remove _alive from InAppBrowser.js since it
didn't catch the case where the browser is closed by the user.
Remove _alive from InAppBrowser.js since it didn't catch the case where the browser is closed by the user.
Project: http://git-wip-us.apache.org/repos/asf/cordova-plugin-inappbrowser/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugin-inappbrowser/commit/3f9af4fd
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugin-inappbrowser/tree/3f9af4fd
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugin-inappbrowser/diff/3f9af4fd
Branch: refs/heads/master
Commit: 3f9af4fd88ebcb7b29487d26768e3f392d5d9285
Parents: 57d14da
Author: Andrew Grieve <ag...@chromium.org>
Authored: Tue Jan 7 10:52:44 2014 -0500
Committer: Andrew Grieve <ag...@chromium.org>
Committed: Tue Jan 7 10:52:44 2014 -0500
----------------------------------------------------------------------
www/InAppBrowser.js | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cordova-plugin-inappbrowser/blob/3f9af4fd/www/InAppBrowser.js
----------------------------------------------------------------------
diff --git a/www/InAppBrowser.js b/www/InAppBrowser.js
index 3fe9261..ebcfa24 100644
--- a/www/InAppBrowser.js
+++ b/www/InAppBrowser.js
@@ -31,7 +31,6 @@ function InAppBrowser() {
'loaderror' : channel.create('loaderror'),
'exit' : channel.create('exit')
};
- this._alive = true;
}
InAppBrowser.prototype = {
@@ -41,10 +40,7 @@ InAppBrowser.prototype = {
}
},
close: function (eventname) {
- if (this._alive) {
- this._alive = false;
- exec(null, null, "InAppBrowser", "close", []);
- }
+ exec(null, null, "InAppBrowser", "close", []);
},
show: function (eventname) {
exec(null, null, "InAppBrowser", "show", []);