[jira] [Commented] (FINERACT-1256) Bulk Import Template generation should not fail for (office) names containing hyphens and other characters invalid as Sheet Range Names

["Michael Vorburger (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FINERACT-1256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17227835#comment-17227835 ] 

Michael Vorburger commented on FINERACT-1256:
---------------------------------------------

[https://github.com/apache/fineract/pull/1498] has a fix addressing the underlying problem in ALL *WorkbookPopulator (20 files modified). The same commit is also part of https://github.com/apache/fineract/pull/1494.

> Bulk Import Template generation should not fail for (office) names containing hyphens and other characters invalid as Sheet Range Names
> ---------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: FINERACT-1256
>                 URL: https://issues.apache.org/jira/browse/FINERACT-1256
>             Project: Apache Fineract
>          Issue Type: Bug
>            Reporter: Michael Vorburger
>            Assignee: Michael Vorburger
>            Priority: Major
>             Fix For: 1.5.0
>
>
> https://travis-ci.org/github/apache/fineract/builds/741992238 for https://github.com/apache/fineract/pull/1494 failed with:
> SavingsWorkbookPopulateTest > testSavingsWorkbookPopulate() FAILED
>     java.lang.AssertionError: 1 expectation failed.
>     Expected status code <200> but was <500>.
> I suspect that is NOT due to a change in that PR, but that test is just "flaky".



--
This message was sent by Atlassian Jira
(v8.3.4#803005)