You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/07/12 11:52:44 UTC
[GitHub] [shardingsphere] azexcy opened a new pull request, #19071: Fixed scaling incremental failure due to the null column value
azexcy opened a new pull request, #19071:
URL: https://github.com/apache/shardingsphere/pull/19071
Fixed #19070
Changes proposed in this pull request:
- Add null check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] TeslaCN commented on a diff in pull request #19071: Fixed scaling incremental failure due to the null column value
Posted by GitBox <gi...@apache.org>.
TeslaCN commented on code in PR #19071:
URL: https://github.com/apache/shardingsphere/pull/19071#discussion_r919616468
##########
shardingsphere-kernel/shardingsphere-data-pipeline/shardingsphere-data-pipeline-dialect/shardingsphere-data-pipeline-opengauss/src/main/java/org/apache/shardingsphere/data/pipeline/opengauss/ingest/wal/decode/MppdbDecodingPlugin.java:
##########
@@ -138,6 +139,9 @@ private List<Object> getDeleteColumnDataFromMppDataEvent(final MppTableData data
}
private Object readColumnData(final String data, final String columnType) {
+ if (Objects.equals(data, "null")) {
Review Comment:
Why not `"null".equals(data)`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] azexcy commented on a diff in pull request #19071: Fixed scaling incremental failure due to the null column value
Posted by GitBox <gi...@apache.org>.
azexcy commented on code in PR #19071:
URL: https://github.com/apache/shardingsphere/pull/19071#discussion_r919664283
##########
shardingsphere-kernel/shardingsphere-data-pipeline/shardingsphere-data-pipeline-dialect/shardingsphere-data-pipeline-opengauss/src/main/java/org/apache/shardingsphere/data/pipeline/opengauss/ingest/wal/decode/MppdbDecodingPlugin.java:
##########
@@ -138,6 +139,9 @@ private List<Object> getDeleteColumnDataFromMppDataEvent(final MppTableData data
}
private Object readColumnData(final String data, final String columnType) {
+ if (Objects.equals(data, "null")) {
Review Comment:
Just getting used to using this method, do I need to change it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #19071: Fixed scaling incremental failure due to the null column value
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #19071:
URL: https://github.com/apache/shardingsphere/pull/19071#issuecomment-1182813555
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/19071?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19071](https://codecov.io/gh/apache/shardingsphere/pull/19071?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (00f28a2) into [master](https://codecov.io/gh/apache/shardingsphere/commit/6268b91dd08b8d8a1ca2e03368c3a119cf7b85ce?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6268b91) will **decrease** coverage by `0.00%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #19071 +/- ##
============================================
- Coverage 59.38% 59.38% -0.01%
- Complexity 2320 2321 +1
============================================
Files 3804 3804
Lines 54710 54720 +10
Branches 9225 9229 +4
============================================
+ Hits 32491 32494 +3
- Misses 19500 19504 +4
- Partials 2719 2722 +3
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/19071?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...engauss/ingest/wal/decode/MppdbDecodingPlugin.java](https://codecov.io/gh/apache/shardingsphere/pull/19071/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUvc2hhcmRpbmdzcGhlcmUtZGF0YS1waXBlbGluZS1kaWFsZWN0L3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUtb3BlbmdhdXNzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kYXRhL3BpcGVsaW5lL29wZW5nYXVzcy9pbmdlc3Qvd2FsL2RlY29kZS9NcHBkYkRlY29kaW5nUGx1Z2luLmphdmE=) | `73.87% <0.00%> (-1.36%)` | :arrow_down: |
| [...roxy/frontend/mysql/err/MySQLErrPacketFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/19071/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Byb3h5L2Zyb250ZW5kL215c3FsL2Vyci9NeVNRTEVyclBhY2tldEZhY3RvcnkuamF2YQ==) | `55.93% <0.00%> (-1.97%)` | :arrow_down: |
| [...end/postgresql/err/PostgreSQLErrPacketFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/19071/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQtcG9zdGdyZXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvZnJvbnRlbmQvcG9zdGdyZXNxbC9lcnIvUG9zdGdyZVNRTEVyclBhY2tldEZhY3RvcnkuamF2YQ==) | `31.57% <0.00%> (-1.76%)` | :arrow_down: |
| [.../shardingsphere/infra/check/SQLCheckException.java](https://codecov.io/gh/apache/shardingsphere/pull/19071/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9jaGVjay9TUUxDaGVja0V4Y2VwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...dingsphere/driver/executor/DriverJDBCExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/19071/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RyaXZlci9leGVjdXRvci9Ecml2ZXJKREJDRXhlY3V0b3IuamF2YQ==) | `87.50% <0.00%> (ø)` | |
| [...ingsphere/infra/exception/NoDatabaseException.java](https://codecov.io/gh/apache/shardingsphere/pull/19071/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9leGNlcHRpb24vTm9EYXRhYmFzZUV4Y2VwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...ate/circuit/statement/CircuitBreakerStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/19071/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RyaXZlci9zdGF0ZS9jaXJjdWl0L3N0YXRlbWVudC9DaXJjdWl0QnJlYWtlclN0YXRlbWVudC5qYXZh) | `2.70% <0.00%> (ø)` | |
| [.../shardingsphere/authority/model/PrivilegeType.java](https://codecov.io/gh/apache/shardingsphere/pull/19071/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLWF1dGhvcml0eS9zaGFyZGluZ3NwaGVyZS1hdXRob3JpdHktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9hdXRob3JpdHkvbW9kZWwvUHJpdmlsZWdlVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [.../protocol/mysql/constant/MySQLServerErrorCode.java](https://codecov.io/gh/apache/shardingsphere/pull/19071/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RiL3Byb3RvY29sL215c3FsL2NvbnN0YW50L015U1FMU2VydmVyRXJyb3JDb2RlLmphdmE=) | `100.00% <0.00%> (ø)` | |
| [...uit/statement/CircuitBreakerPreparedStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/19071/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RyaXZlci9zdGF0ZS9jaXJjdWl0L3N0YXRlbWVudC9DaXJjdWl0QnJlYWtlclByZXBhcmVkU3RhdGVtZW50LmphdmE=) | `1.69% <0.00%> (ø)` | |
| ... and [136 more](https://codecov.io/gh/apache/shardingsphere/pull/19071/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/19071?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/19071?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6268b91...00f28a2](https://codecov.io/gh/apache/shardingsphere/pull/19071?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] menghaoranss commented on pull request #19071: Fixed scaling incremental failure due to the null column value
Posted by GitBox <gi...@apache.org>.
menghaoranss commented on PR #19071:
URL: https://github.com/apache/shardingsphere/pull/19071#issuecomment-1182611425
please fix ci
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] sandynz merged pull request #19071: Fixed scaling incremental failure due to the null column value
Posted by GitBox <gi...@apache.org>.
sandynz merged PR #19071:
URL: https://github.com/apache/shardingsphere/pull/19071
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org