You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/06/27 22:43:44 UTC
[GitHub] [arrow] wesm opened a new pull request #7560: ARROW-9252: [Integration] Factor out IPC integration tests into script, add back 0.14.1 "gold" files
wesm opened a new pull request #7560:
URL: https://github.com/apache/arrow/pull/7560
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm commented on pull request #7560: ARROW-9252: [Integration] Factor out IPC integration tests into script, add back 0.14.1 "gold" files
Posted by GitBox <gi...@apache.org>.
wesm commented on pull request #7560:
URL: https://github.com/apache/arrow/pull/7560#issuecomment-650789278
Sure, that sounds good
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm commented on pull request #7560: ARROW-9252: [Integration] Factor out IPC integration tests into script, add back 0.14.1 "gold" files
Posted by GitBox <gi...@apache.org>.
wesm commented on pull request #7560:
URL: https://github.com/apache/arrow/pull/7560#issuecomment-651458622
Yahtzee
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] emkornfield commented on pull request #7560: ARROW-9252: [Integration] Factor out IPC integration tests into script, add back 0.14.1 "gold" files
Posted by GitBox <gi...@apache.org>.
emkornfield commented on pull request #7560:
URL: https://github.com/apache/arrow/pull/7560#issuecomment-650789140
No, IIRC I think I hacked integration tests to generate smaller files then looped over them with one of the binaries. I can try to come up with something to update the json files and submit a PR to the test data repo?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm commented on pull request #7560: ARROW-9252: [Integration] Factor out IPC integration tests into script, add back 0.14.1 "gold" files
Posted by GitBox <gi...@apache.org>.
wesm commented on pull request #7560:
URL: https://github.com/apache/arrow/pull/7560#issuecomment-650774989
@emkornfield looks like almost none of the 0.14.1 "gold" files can be read anymore because of the change to represent int64 values as strings. We should prepare a set of gold files from after the int64 changes but before any patches that alter the MetadataVersion etc. Do you have a script that you used to create the gold files?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on a change in pull request #7560: ARROW-9252: [Integration] Factor out IPC integration tests into script, add back 0.14.1 "gold" files
Posted by GitBox <gi...@apache.org>.
pitrou commented on a change in pull request #7560:
URL: https://github.com/apache/arrow/pull/7560#discussion_r447134548
##########
File path: ci/scripts/integration_arrow.sh
##########
@@ -0,0 +1,29 @@
+#!/usr/bin/env bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+set -ex
+
+arrow_dir=${1}
+source_dir=${1}/cpp
+build_dir=${2}/cpp
+gold_dir_0_14_1=${1}/testing/data/arrow-ipc-stream/integration/0.14.1
+
+pip install -e /arrow/dev/archery
Review comment:
Use `$source_dir` here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7560: ARROW-9252: [Integration] Factor out IPC integration tests into script, add back 0.14.1 "gold" files
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7560:
URL: https://github.com/apache/arrow/pull/7560#issuecomment-650643241
https://issues.apache.org/jira/browse/ARROW-9252
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm commented on pull request #7560: ARROW-9252: [Integration] Factor out IPC integration tests into script, add back 0.14.1 "gold" files
Posted by GitBox <gi...@apache.org>.
wesm commented on pull request #7560:
URL: https://github.com/apache/arrow/pull/7560#issuecomment-650650589
Looks like the int64 tests must be removed from the "gold" corpus as the JSON files cannot be parsed anymore
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm closed pull request #7560: ARROW-9252: [Integration] Factor out IPC integration tests into script, add back 0.14.1 "gold" files
Posted by GitBox <gi...@apache.org>.
wesm closed pull request #7560:
URL: https://github.com/apache/arrow/pull/7560
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm commented on pull request #7560: ARROW-9252: [Integration] Factor out IPC integration tests into script, add back 0.14.1 "gold" files
Posted by GitBox <gi...@apache.org>.
wesm commented on pull request #7560:
URL: https://github.com/apache/arrow/pull/7560#issuecomment-651423838
Will merge this if the build passes with the arrow-testing changes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org