You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by "mbeckerle (via GitHub)" <gi...@apache.org> on 2023/06/21 21:22:39 UTC
[GitHub] [daffodil-vscode] mbeckerle opened a new issue, #672: launch wizard text layout - can't read some things
mbeckerle opened a new issue, #672:
URL: https://github.com/apache/daffodil-vscode/issues/672
Look at the Daffodil Debugger Classpath in the image. This is not readable.
(Tested 1.3.0-RC3)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] mbeckerle commented on issue #672: launch wizard text layout - can't read some things
Posted by "mbeckerle (via GitHub)" <gi...@apache.org>.
mbeckerle commented on issue #672:
URL: https://github.com/apache/daffodil-vscode/issues/672#issuecomment-1603347120
With very short paths, if they fit in the black oval, it looks ok. But those are not realistic paths.
And note that the Data absolute path to the input data file oval is a long file name that doesn't fit, but it doesn't become unreadable.
So something specific is going on with the Daffodil Debugger Classpath entries.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] shanedell commented on issue #672: launch wizard text layout - can't read some things
Posted by "shanedell (via GitHub)" <gi...@apache.org>.
shanedell commented on issue #672:
URL: https://github.com/apache/daffodil-vscode/issues/672#issuecomment-1603377527
@mbeckerle So I have an update to CSS I think will work, how does something like this look?
<img width="720" alt="Screenshot 2023-06-22 at 6 07 47 PM" src="https://github.com/apache/daffodil-vscode/assets/32347414/22c5dcd2-ffb7-4925-9f53-37d98079e9f9">
Basically what will now happen is the width and height of the item will fit to the content for each item. In the case of height needing adjusted the text will wrap so it doesn't look as bad.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] shanedell commented on issue #672: launch wizard text layout - can't read some things
Posted by "shanedell (via GitHub)" <gi...@apache.org>.
shanedell commented on issue #672:
URL: https://github.com/apache/daffodil-vscode/issues/672#issuecomment-1603343976
@mbeckerle Uh yeah it should allow you, I will see if I can reproduce that. But for the GUI, does those paths always look that bad or only whenever its a longer path?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] mbeckerle commented on issue #672: launch wizard text layout - can't read some things
Posted by "mbeckerle (via GitHub)" <gi...@apache.org>.
mbeckerle commented on issue #672:
URL: https://github.com/apache/daffodil-vscode/issues/672#issuecomment-1603342317
@shanedell I definitely cannot select a jar file. I can only get down to the directory that contains the jar. It won't let me choose the jar to add to the classpath.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] mbeckerle commented on issue #672: launch wizard text layout - can't read some things
Posted by "mbeckerle (via GitHub)" <gi...@apache.org>.
mbeckerle commented on issue #672:
URL: https://github.com/apache/daffodil-vscode/issues/672#issuecomment-1601735475
Changing this to an absolute pathname allows vscode to find the jar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] mbeckerle commented on issue #672: launch wizard text layout - can't read some things
Posted by "mbeckerle (via GitHub)" <gi...@apache.org>.
mbeckerle commented on issue #672:
URL: https://github.com/apache/daffodil-vscode/issues/672#issuecomment-1601723701
I added this to the DaffodilDebugClasspath
${workspaceFolder}/lib_managed/jars/com.owlcyberdefense/dfdl-ethernetip/dfdl-ethernetip-1.2.0.jar
This file does exist. I cut/pasted it into emacs and opened the jar.
However, VScode just complains it does not exist with a little dialog.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] shanedell commented on issue #672: launch wizard text layout - can't read some things
Posted by "shanedell (via GitHub)" <gi...@apache.org>.
shanedell commented on issue #672:
URL: https://github.com/apache/daffodil-vscode/issues/672#issuecomment-1603212466
@mbeckerle I actually found the issue, it was with us validating paths. Whenever we are validating paths currently we forget to replace `${workspaceFolder}` with the actual path causing the issue you mentioned. Will add this to 1.3.0 as this is something it should have.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] shanedell commented on issue #672: launch wizard text layout - can't read some things
Posted by "shanedell (via GitHub)" <gi...@apache.org>.
shanedell commented on issue #672:
URL: https://github.com/apache/daffodil-vscode/issues/672#issuecomment-1601851912
So you couldn't select a single JAR file only the directory? That is something we want to allow the user to do so I will look into that.
As for the full pathname and using `${workspaceFolder}`. The issue there might be that you needed some additional folders after `${workspaceFolder}`. `${workspaceFolder}` is the directory that holds the `.vscode` folder. So if you have `/home/mbeckerle/thisWorkspace/.vscode/launch.json`, the `${workspaceFolder}` is `/home/mbeckerle/thisWorkspace/`. Not sure if that helps at all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] shanedell commented on issue #672: launch wizard text layout - can't read some things
Posted by "shanedell (via GitHub)" <gi...@apache.org>.
shanedell commented on issue #672:
URL: https://github.com/apache/daffodil-vscode/issues/672#issuecomment-1601860588
@mbeckerle would you like this in 1.3.0 or 1.3.1?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] mbeckerle commented on issue #672: launch wizard text layout - can't read some things
Posted by "mbeckerle (via GitHub)" <gi...@apache.org>.
mbeckerle commented on issue #672:
URL: https://github.com/apache/daffodil-vscode/issues/672#issuecomment-1601711123
In addition, when trying to add a jar file from under lib_managed, I am unable to actually select the jar file itself. It only lets me select the directory containing the jar file. I had to edit the launch.json directly to type in the file name+extension manually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] shanedell commented on issue #672: launch wizard text layout - can't read some things
Posted by "shanedell (via GitHub)" <gi...@apache.org>.
shanedell commented on issue #672:
URL: https://github.com/apache/daffodil-vscode/issues/672#issuecomment-1603277238
@mbeckerle Can you double check the issue with selecting a single JAR? I was able to do this in the launch wizard you just have to drill down all the directory to be able to select it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] shanedell closed issue #672: launch wizard text layout - can't read some things
Posted by "shanedell (via GitHub)" <gi...@apache.org>.
shanedell closed issue #672: launch wizard text layout - can't read some things
URL: https://github.com/apache/daffodil-vscode/issues/672
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org