You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Erik Huelsmann <eh...@gmail.com> on 2006/11/18 11:01:18 UTC
[PATCH] support for progress information in ra_svn
On 9/16/06, Stefan Küng <to...@gmail.com> wrote:
> Mark Phippard wrote:
> > "Erik Huelsmann" <eh...@gmail.com> wrote on 09/16/2006 03:03:43 AM:
> >
> >> The latest API docs are here: http://svn.collab.net/svn-doxygen/
> >>
> >> The TSVN guys could have told you that it's because of lack of support
> >> for it in the neon llibrary, because we have told them before that our
> >> libraries don't support it because our dependencies don't...
> >
> > Is that a valid excuse? You guys enhance and fix problems in APR all the
> > time, why not Neon? This is a legitimate feature that would also improve
> > the command line client.
> >
> > Also, Neon does at least have API to say the bytes transferred and it was
> > the TSVN guys that enhanced SVN to support this in the API. None of the
>
> And that's all that's required of neon. It can't do more. To get more
> detailed progress information, the Subversion library has to add that
> part. Neon only knows about transferred bytes.
>
> > SVN developers have stepped up to add equivalent support to the svn:// and
> > file:// protocols which are completely in your control.
>
> FYI: issue 901 (http://subversion.tigris.org/issues/show_bug.cgi?id=901)
> was opened four(!) years ago.
>
> > I wouldn't have even posted to this thread, but I did not really like the
> > finger-pointing. Yes, the libraries you use do not have support for this
> > feature currently, but if users do not repeatedly ask you for it, then how
> > are you ever going to know people want it?
>
> Even worse: even for new libraries this feature is ignored. Serf (a
> replacement for neon, written by Subversion developers does not provide
> such information. While I can understand that adding such a feature is a
> lot of work, I can't understand why it wasn't added for a library
> written from scratch.
Well, I took your comments to hart: before adding progress support, I
found out our network activity can't be canceled, so, last week, I
added cancellation support. I guess that's what all users expect, but
GUI users even more than others.
The attached patch should add progress support at the same basic level
as currently supported by ra_dav to ra_svn, but since our client
doesn't install a progress callback, there's no way testing it for me.
Could you test the patch with subclipse/TSVN for me please?
Thanks in advance!
bye,
Erik.
Re: [PATCH] support for progress information in ra_svn
Posted by Daniel Rall <dl...@collab.net>.
On Sat, 18 Nov 2006, Mark Phippard wrote:
> Erik Huelsmann wrote:
> >
> >Well, I took your comments to hart: before adding progress support, I
> >found out our network activity can't be canceled, so, last week, I
> >added cancellation support. I guess that's what all users expect, but
> >GUI users even more than others.
> >
> >The attached patch should add progress support at the same basic level
> >as currently supported by ra_dav to ra_svn, but since our client
> >doesn't install a progress callback, there's no way testing it for me.
> >
> >Could you test the patch with subclipse/TSVN for me please?
>
> The progress API is not exposed via JavaHL yet, so we are not using
> it in Subclipse. I am sure that Stefan will test this though.
With the progress API now quite useful with all of Erik's
improvements, I'm working up JavaHL bindings for it. Please see the
attached patch (untested).
- Dan
Re: [PATCH] support for progress information in ra_svn
Posted by Stefan Küng <to...@gmail.com>.
Mark Phippard wrote:
> Erik Huelsmann wrote:
>>
>> Well, I took your comments to hart: before adding progress support, I
>> found out our network activity can't be canceled, so, last week, I
>> added cancellation support. I guess that's what all users expect, but
>> GUI users even more than others.
>>
>> The attached patch should add progress support at the same basic level
>> as currently supported by ra_dav to ra_svn, but since our client
>> doesn't install a progress callback, there's no way testing it for me.
>>
>> Could you test the patch with subclipse/TSVN for me please?
>
> The progress API is not exposed via JavaHL yet, so we are not using it
> in Subclipse. I am sure that Stefan will test this though.
I'm on it. But it's saturday, so don't expect immediate result :)
Stefan
--
___
oo // \\ "De Chelonian Mobile"
(_,\/ \_/ \ TortoiseSVN
\ \_/_\_/> The coolest Interface to (Sub)Version Control
/_/ \_\ http://tortoisesvn.net
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] support for progress information in ra_svn
Posted by Mark Phippard <ma...@gmail.com>.
Erik Huelsmann wrote:
>
> Well, I took your comments to hart: before adding progress support, I
> found out our network activity can't be canceled, so, last week, I
> added cancellation support. I guess that's what all users expect, but
> GUI users even more than others.
>
> The attached patch should add progress support at the same basic level
> as currently supported by ra_dav to ra_svn, but since our client
> doesn't install a progress callback, there's no way testing it for me.
>
> Could you test the patch with subclipse/TSVN for me please?
The progress API is not exposed via JavaHL yet, so we are not using it
in Subclipse. I am sure that Stefan will test this though.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] support for progress information in ra_svn
Posted by Erik Huelsmann <eh...@gmail.com>.
On 11/18/06, Stefan Küng <to...@gmail.com> wrote:
> Erik Huelsmann wrote:
>
> > Well, I took your comments to hart: before adding progress support, I
> > found out our network activity can't be canceled, so, last week, I
> > added cancellation support. I guess that's what all users expect, but
> > GUI users even more than others.
> >
> > The attached patch should add progress support at the same basic level
> > as currently supported by ra_dav to ra_svn, but since our client
> > doesn't install a progress callback, there's no way testing it for me.
> >
> > Could you test the patch with subclipse/TSVN for me please?
>
> Tested your patch with TSVN built against the Subversion trunk. Works
> perfect!
r22340.
> One thing I noticed while compiling Subversion trunk: even with all
> networking disabled, I need to link against zlib. Is there a reason for
> this? Before, zlib was not required (only if using the ra layers).
Yes, we were wrong before: libsvn_subr has a compressing stream.
Before, when no zlib was used, it wouldn't compress. This however
would mean you couldn't count on it being able to read back data off
it you had written to it with a different version... (ie total
brokenness).
We decided to make it a requirement because of it, but also, the new
svndiff1 code uses zlib for self-compressing fulltexts.
bye,
Erik.
Re: [PATCH] support for progress information in ra_svn
Posted by Ivan Zhakov <ch...@gmail.com>.
On 11/18/06, Stefan Küng <to...@gmail.com> wrote:
> One thing I noticed while compiling Subversion trunk: even with all
> networking disabled, I need to link against zlib. Is there a reason for
> this? Before, zlib was not required (only if using the ra layers).
>
Now zlib is required for new svndiff format.
--
Ivan Zhakov
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] support for progress information in ra_svn
Posted by Stefan Küng <to...@gmail.com>.
Erik Huelsmann wrote:
> Well, I took your comments to hart: before adding progress support, I
> found out our network activity can't be canceled, so, last week, I
> added cancellation support. I guess that's what all users expect, but
> GUI users even more than others.
>
> The attached patch should add progress support at the same basic level
> as currently supported by ra_dav to ra_svn, but since our client
> doesn't install a progress callback, there's no way testing it for me.
>
> Could you test the patch with subclipse/TSVN for me please?
Tested your patch with TSVN built against the Subversion trunk. Works
perfect!
One thing I noticed while compiling Subversion trunk: even with all
networking disabled, I need to link against zlib. Is there a reason for
this? Before, zlib was not required (only if using the ra layers).
Stefan
--
___
oo // \\ "De Chelonian Mobile"
(_,\/ \_/ \ TortoiseSVN
\ \_/_\_/> The coolest Interface to (Sub)Version Control
/_/ \_\ http://tortoisesvn.net
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org