You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2021/07/22 14:59:53 UTC
[GitHub] [incubator-yunikorn-scheduler-interface] updown321 opened a new pull request #40: YUNIKORN-760. resolve makefile error PROTOC_VER 3.16 to 3.16.0
updown321 opened a new pull request #40:
URL: https://github.com/apache/incubator-yunikorn-scheduler-interface/pull/40
### What is this PR for?
Fix the makefile in interface
### What type of PR is it?
* [x] - Bug Fix
* [ ] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
* [ ] - Task
### What is the Jira issue?
* Open an issue on Jira https://issues.apache.org/jira/browse/YUNIKORN-760/
* [YUNIKORN-760] Fix Makefile in Yunikorn interface
### How should this be tested?
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-scheduler-interface] yangwwei commented on pull request #40: YUNIKORN-760. Fix Makefile in Yunikorn interface
Posted by GitBox <gi...@apache.org>.
yangwwei commented on pull request #40:
URL: https://github.com/apache/incubator-yunikorn-scheduler-interface/pull/40#issuecomment-885407407
Good findings @updown321 , thanks for working on this.
Based on your investigation, this seems to be broken by https://issues.apache.org/jira/browse/YUNIKORN-488.
@wilfred-s , @manirajv06 could you please take a look at this one, and make sure we are good?
BTW, I think we need to have some safe-guards for scheduler-interface repo as well, to prevent such issues. Let me create a JIRA to add some github action pipeline for this repo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-scheduler-interface] wilfred-s commented on pull request #40: YUNIKORN-760. Fix Makefile in Yunikorn interface
Posted by GitBox <gi...@apache.org>.
wilfred-s commented on pull request #40:
URL: https://github.com/apache/incubator-yunikorn-scheduler-interface/pull/40#issuecomment-890694230
This was superseded by #42 to fix more issues found.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-scheduler-interface] wilfred-s commented on pull request #40: YUNIKORN-760. Fix Makefile in Yunikorn interface
Posted by GitBox <gi...@apache.org>.
wilfred-s commented on pull request #40:
URL: https://github.com/apache/incubator-yunikorn-scheduler-interface/pull/40#issuecomment-889613609
There is more broken. When I do a `make clobber` and then a `make` it all falls apart.
Yes we should have a better way of testing this. A pre-commit run of just a simple make would suffice and the right thing to do.
I have added a fully fixed make procedure which now works on a clean checkout of the repo. See: #42
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-scheduler-interface] wilfred-s closed pull request #40: YUNIKORN-760. Fix Makefile in Yunikorn interface
Posted by GitBox <gi...@apache.org>.
wilfred-s closed pull request #40:
URL: https://github.com/apache/incubator-yunikorn-scheduler-interface/pull/40
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org