[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1298: SOLR-14289 Skip ZkChroot check when not necessary

[GitBox <gi...@apache.org>]

dsmiley commented on a change in pull request #1298: SOLR-14289 Skip ZkChroot check when not necessary
URL: https://github.com/apache/lucene-solr/pull/1298#discussion_r389891175
 
 

 ##########
 File path: solr/core/src/java/org/apache/solr/servlet/SolrDispatchFilter.java
 ##########
 @@ -285,7 +285,7 @@ public static NodeConfig loadNodeConfig(Path solrHome, Properties nodeProperties
           if (zkClient.exists("/solr.xml", true)) {
             log.info("solr.xml found in ZooKeeper. Loading...");
             byte[] data = zkClient.getData("/solr.xml", null, null, true);
-            return SolrXmlConfig.fromInputStream(loader, new ByteArrayInputStream(data));
+            return SolrXmlConfig.fromInputStream(loader, new ByteArrayInputStream(data), "zookeeper");
 
 Review comment:
   So, what other than "zookeeper" is used here?  Do we just need a boolean if this is the only value?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org