You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "yunfan123 (via GitHub)" <gi...@apache.org> on 2023/11/08 02:46:10 UTC

[PR] [FLINK-33478][hive] Enable foldExpr by default in filter condition [flink]

yunfan123 opened a new pull request, #23682:
URL: https://github.com/apache/flink/pull/23682

   ## What is the purpose of the change
   Use foldExpr config as default to fix NPE problem when use unix_timestamp() in filter condition.
   And it is already the default value in hive project.
   
   
   ## Brief change log
   Change foldExpr config default as true in filter condition
   
   ## Verifying this change
   This change is verified by added test
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-33478][hive] Enable foldExpr by default in filter condition [flink]

Posted by "luoyuxia (via GitHub)" <gi...@apache.org>.
luoyuxia merged PR #23682:
URL: https://github.com/apache/flink/pull/23682


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-33478][hive] Enable foldExpr by default in filter condition [flink]

Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #23682:
URL: https://github.com/apache/flink/pull/23682#issuecomment-1800926621

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "3b3b2097aa9048640f76a67f031e6bc4e884e5dc",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "3b3b2097aa9048640f76a67f031e6bc4e884e5dc",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 3b3b2097aa9048640f76a67f031e6bc4e884e5dc UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org