You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Michael Park <mp...@apache.org> on 2016/01/27 23:48:43 UTC
Review Request 42876: Disallowed non-`const` iteration over
`Resources`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42876/
-----------------------------------------------------------
Review request for mesos, Jie Yu and Joris Van Remoortere.
Bugs: MESOS-4534
https://issues.apache.org/jira/browse/MESOS-4534
Repository: mesos
Description
-------
See summary.
Diffs
-----
include/mesos/resources.hpp cc8fef9470d779078aa408ed03e747e5a492deaa
include/mesos/v1/resources.hpp f4892977f8d7b0439db6e9cf7921334f606a496c
src/master/allocator/mesos/hierarchical.cpp dbc77a2d0ce797eea2287b0242f5d2da81c16455
src/master/http.cpp 12c1fe5a514903f657911302e8770e9b245fdbb7
src/slave/resource_estimators/fixed.cpp aedd08df8db59be49b374e61eb268a947d35acea
src/tests/resources_tests.cpp 54a4fa88bfdcff3c0a7e89cbf3a1674c954b7f23
Diff: https://reviews.apache.org/r/42876/diff/
Testing
-------
`make check`
Thanks,
Michael Park
Re: Review Request 42876: Disallowed non-`const` iteration over
`Resources`.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42876/#review116711
-----------------------------------------------------------
Bad patch!
Reviews applied: [42876]
Failed command: ./support/apply-review.sh -n -r 42876
Error:
...<truncated>...
2016-01-28 03:26:10 URL:https://reviews.apache.org/r/42876/diff/raw/ [5874/5874] -> "42876.patch" [1]
error: patch failed: include/mesos/resources.hpp:317
error: include/mesos/resources.hpp: patch does not apply
error: patch failed: include/mesos/v1/resources.hpp:317
error: include/mesos/v1/resources.hpp: patch does not apply
error: patch failed: src/master/allocator/mesos/hierarchical.cpp:1160
error: src/master/allocator/mesos/hierarchical.cpp: patch does not apply
error: patch failed: src/master/http.cpp:708
error: src/master/http.cpp: patch does not apply
error: patch failed: src/slave/resource_estimators/fixed.cpp:68
error: src/slave/resource_estimators/fixed.cpp: patch does not apply
error: patch failed: src/tests/resources_tests.cpp:351
error: src/tests/resources_tests.cpp: patch does not apply
Full log: https://builds.apache.org/job/mesos-reviewbot/11083/console
- Mesos ReviewBot
On Jan. 27, 2016, 10:50 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42876/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2016, 10:50 p.m.)
>
>
> Review request for mesos, Jie Yu and Joris Van Remoortere.
>
>
> Bugs: MESOS-4534
> https://issues.apache.org/jira/browse/MESOS-4534
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/resources.hpp cc8fef9470d779078aa408ed03e747e5a492deaa
> include/mesos/v1/resources.hpp f4892977f8d7b0439db6e9cf7921334f606a496c
> src/master/allocator/mesos/hierarchical.cpp dbc77a2d0ce797eea2287b0242f5d2da81c16455
> src/master/http.cpp 12c1fe5a514903f657911302e8770e9b245fdbb7
> src/slave/resource_estimators/fixed.cpp aedd08df8db59be49b374e61eb268a947d35acea
> src/tests/resources_tests.cpp 54a4fa88bfdcff3c0a7e89cbf3a1674c954b7f23
>
> Diff: https://reviews.apache.org/r/42876/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 42876: Disallowed non-`const` iteration over
`Resources`.
Posted by Klaus Ma <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42876/#review116661
-----------------------------------------------------------
Ship it!
Ship It!
- Klaus Ma
On Jan. 28, 2016, 6:50 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42876/
> -----------------------------------------------------------
>
> (Updated Jan. 28, 2016, 6:50 a.m.)
>
>
> Review request for mesos, Jie Yu and Joris Van Remoortere.
>
>
> Bugs: MESOS-4534
> https://issues.apache.org/jira/browse/MESOS-4534
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/resources.hpp cc8fef9470d779078aa408ed03e747e5a492deaa
> include/mesos/v1/resources.hpp f4892977f8d7b0439db6e9cf7921334f606a496c
> src/master/allocator/mesos/hierarchical.cpp dbc77a2d0ce797eea2287b0242f5d2da81c16455
> src/master/http.cpp 12c1fe5a514903f657911302e8770e9b245fdbb7
> src/slave/resource_estimators/fixed.cpp aedd08df8db59be49b374e61eb268a947d35acea
> src/tests/resources_tests.cpp 54a4fa88bfdcff3c0a7e89cbf3a1674c954b7f23
>
> Diff: https://reviews.apache.org/r/42876/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 42876: Disallowed non-`const` iteration over
`Resources`.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42876/#review116656
-----------------------------------------------------------
Ship it!
Ship It!
- Joris Van Remoortere
On Jan. 27, 2016, 10:50 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42876/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2016, 10:50 p.m.)
>
>
> Review request for mesos, Jie Yu and Joris Van Remoortere.
>
>
> Bugs: MESOS-4534
> https://issues.apache.org/jira/browse/MESOS-4534
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/resources.hpp cc8fef9470d779078aa408ed03e747e5a492deaa
> include/mesos/v1/resources.hpp f4892977f8d7b0439db6e9cf7921334f606a496c
> src/master/allocator/mesos/hierarchical.cpp dbc77a2d0ce797eea2287b0242f5d2da81c16455
> src/master/http.cpp 12c1fe5a514903f657911302e8770e9b245fdbb7
> src/slave/resource_estimators/fixed.cpp aedd08df8db59be49b374e61eb268a947d35acea
> src/tests/resources_tests.cpp 54a4fa88bfdcff3c0a7e89cbf3a1674c954b7f23
>
> Diff: https://reviews.apache.org/r/42876/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 42876: Disallowed non-`const` iteration over
`Resources`.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42876/
-----------------------------------------------------------
(Updated Jan. 27, 2016, 10:50 p.m.)
Review request for mesos, Jie Yu and Joris Van Remoortere.
Bugs: MESOS-4534
https://issues.apache.org/jira/browse/MESOS-4534
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
include/mesos/resources.hpp cc8fef9470d779078aa408ed03e747e5a492deaa
include/mesos/v1/resources.hpp f4892977f8d7b0439db6e9cf7921334f606a496c
src/master/allocator/mesos/hierarchical.cpp dbc77a2d0ce797eea2287b0242f5d2da81c16455
src/master/http.cpp 12c1fe5a514903f657911302e8770e9b245fdbb7
src/slave/resource_estimators/fixed.cpp aedd08df8db59be49b374e61eb268a947d35acea
src/tests/resources_tests.cpp 54a4fa88bfdcff3c0a7e89cbf3a1674c954b7f23
Diff: https://reviews.apache.org/r/42876/diff/
Testing
-------
`make check`
Thanks,
Michael Park