You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by hyunsik <gi...@git.apache.org> on 2015/07/13 04:57:28 UTC

[GitHub] tajo pull request: TAJO-1679: Client APIs should validate identifi...

GitHub user hyunsik opened a pull request:

    https://github.com/apache/tajo/pull/627

    TAJO-1679: Client APIs should validate identifiers for database object names.

    See https://issues.apache.org/jira/browse/TAJO-1679.
    
    For example, the current API accepts wrong object names as follows:
    ```java
    client.createDatabase("12345");
    ```
    
    This patch does not include the unit tests because the current error propagation system just causes exceptions in TajoMaster and cannot catch this kind of errors. This problem will be solved in TAJO-1670 and failure unit tests will be added in that jira too.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/hyunsik/tajo TAJO-1679

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tajo/pull/627.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #627
    
----
commit 3a737dd446b3975f0eca6afabf8358686a3548fc
Author: Hyunsik Choi <hy...@apache.org>
Date:   2015-07-13T02:42:10Z

    TAJO-1679: Client APIs should validate identifiers for database object names.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1679: Client APIs should validate identifi...

Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik closed the pull request at:

    https://github.com/apache/tajo/pull/627


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1679: Client APIs should validate identifi...

Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:

    https://github.com/apache/tajo/pull/627#issuecomment-120819104
  
    this is an invalid issue. I'll close it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---