[jira] [Commented] (BEAM-25) Add user-ready API for interacting with state

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-25?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15634920#comment-15634920 ] 

ASF GitHub Bot commented on BEAM-25:
------------------------------------

GitHub user kennknowles opened a pull request:

    https://github.com/apache/incubator-beam/pull/1281

    [BEAM-25] Generalized extra context factory

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    R: @jkff 
    
    Only the last commit is new. This makes it so each "extra" parameter gets to return a wholly arbitrary stack manipulation. This will be needed to pass the parameters for state and timers. I am proposing it now because it also cleans up the type casting, and will make downcasting of the window type a trivial act in parallel with other developments.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/incubator-beam Generalized-ExtraContextFactory

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1281.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1281
    
----
commit 880a538f4ad43d6399bd873c7b6cb7a786a13b6a
Author: Kenneth Knowles <kl...@google.com>
Date:   2016-11-01T22:38:01Z

    Add TypeDescriptor#getTypes

commit 340d922503c06d3a82e964ef0fdf1e04713e40b9
Author: Kenneth Knowles <kl...@google.com>
Date:   2016-11-01T21:48:54Z

    Switch DoFnSignature, etc, from TypeToken to TypeDescriptor

commit 3061436c8719b073a3d5176566ea5e6493224e9c
Author: Kenneth Knowles <kl...@google.com>
Date:   2016-11-01T21:50:24Z

    DoFnSignature: Make TypeDescriptor-returning methods public

commit e117ac82cfabcb8b9729e13c98647c799ea7caf3
Author: Kenneth Knowles <kl...@google.com>
Date:   2016-11-01T04:30:40Z

    Refactor and reuse parameter analysis in DoFnSignatures

commit 8610daa593cd4113ef033391c0d95e77dd513922
Author: Kenneth Knowles <kl...@google.com>
Date:   2016-11-04T01:42:25Z

    Generalize extraction of DoFn parameters from context

----


> Add user-ready API for interacting with state
> ---------------------------------------------
>
>                 Key: BEAM-25
>                 URL: https://issues.apache.org/jira/browse/BEAM-25
>             Project: Beam
>          Issue Type: Sub-task
>          Components: sdk-java-core
>            Reporter: Kenneth Knowles
>            Assignee: Kenneth Knowles
>              Labels: State
>
> Our current state API is targeted at runner implementers, not pipeline authors. As such it has many capabilities that are not necessary nor desirable for simple use cases of stateful ParDo (such as dynamic state tag creation). Implement a simple state intended for user access.
> (Details of our current thoughts in forthcoming design doc)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)