You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@plc4x.apache.org by GitBox <gi...@apache.org> on 2022/06/28 21:43:14 UTC

[GitHub] [plc4x] tvormweg opened a new pull request, #416: fixed copy-paste error in s7 config options

tvormweg opened a new pull request, #416:
URL: https://github.com/apache/plc4x/pull/416

   There has been a copy-paste bug in s7 options factory. "local-rack" option has been used for rack & slot variable. same with "remote-rack". 
   
   I'm not a big go developer, auto formatter messed up formatting in import statement...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [plc4x] sruehl merged pull request #416: fixed copy-paste error in s7 config options

Posted by GitBox <gi...@apache.org>.
sruehl merged PR #416:
URL: https://github.com/apache/plc4x/pull/416


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [plc4x] sruehl commented on pull request #416: fixed copy-paste error in s7 config options

Posted by GitBox <gi...@apache.org>.
sruehl commented on PR #416:
URL: https://github.com/apache/plc4x/pull/416#issuecomment-1173955406

   Indeed good catch, thanks for the PR 👍🏼 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org