You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by Scott Gray <sc...@hotwaxmedia.com> on 2010/02/03 04:46:07 UTC

Re: svn commit: r905876 [1/7] - in /ofbiz/trunk: applications/commonext/documents/ specialpurpose/ specialpurpose/ebay/ specialpurpose/ebay/config/ specialpurpose/ebay/data/ specialpurpose/ebay/data/helpdata/ specialpurpose/ebay/entitydef/ specialpurpose/e...

Okay so once I saw this I took the 5 minutes necessary to look at eBay's services and start thinking that this commit is a bad idea.
Please correct me if any of the following is wrong:
- When you originally brought this up, you described the problem as one of XML vs. API but I think what you actually meant is eBay SDK vs. using XML directly?
- You mentioned that the API (SDK) provides additional functionality but it appears to me that it simply abstracts the use of raw SOAP or XML when interacting with the actual API?

Based on this I'm not sure that we should have separate components but that the XML based component should just be moved to using the SDK (assuming there are only advantages and no disadvantages in doing so).  Doing anything else will just result in twice as much code to maintain with both components doing the same thing (or worse yet, similar things but with huge differences in implementation from the user's perspective).  Converting the existing XML integration to use the SDK will ensure that we have a single solution in place and that no functionality in the existing component is lost.

Regards
Scott

HotWax Media
http://www.hotwaxmedia.com

On 2/02/2010, at 7:16 PM, hansbak@apache.org wrote:

> Author: hansbak
> Date: Wed Feb  3 03:16:07 2010
> New Revision: 905876
> 
> URL: http://svn.apache.org/viewvc?rev=905876&view=rev
> Log:
> move the java api functions from the existing ebay component to the new ebaystore component: no functional changes
> 


Re: svn commit: r905876 [1/7] - in /ofbiz/trunk: applications/commonext/documents/ specialpurpose/ specialpurpose/ebay/ specialpurpose/ebay/config/ specialpurpose/ebay/data/ specialpurpose/ebay/data/helpdata/ specialpurpose/ebay/entitydef/ specialpurpose/e...

Posted by Scott Gray <sc...@hotwaxmedia.com>.
Hi Hans,

Don't get me wrong, if the SDK simplifies the integration then I am all for it.  I don't however think that your approach is a good one, IMO the most likely outcome will be that your implementation will be substantially different from what is currently available and because of that we will end up with both implementations in the trunk for a very long time and anyone who wants to integrate eBay will be faced with the task of assessing both.  To be frank, I think you're taking the path that is easiest for you but much more difficult for the community going forward.

Regards
Scott

On 2/02/2010, at 8:05 PM, Hans Bakker wrote:

> Hi Scott,
> 
> I am also not sure if we need 2 components. That can only be decided by
> the users of the original Ebay component isn't it? I do not know the
> user requirements of the original ebay component.
> 
> Now we moved the new functionality to a separate component it is getting
> more clear if the old component is still required or not.
> 
> Let us first complete the new component and get it fully tested and then
> restart this discussion.
> 
> Regards,
> Hans
> 
> On Tue, 2010-02-02 at 19:46 -0800, Scott Gray wrote:
>> Okay so once I saw this I took the 5 minutes necessary to look at eBay's services and start thinking that this commit is a bad idea.
>> Please correct me if any of the following is wrong:
>> - When you originally brought this up, you described the problem as one of XML vs. API but I think what you actually meant is eBay SDK vs. using XML directly?
>> - You mentioned that the API (SDK) provides additional functionality but it appears to me that it simply abstracts the use of raw SOAP or XML when interacting with the actual API?
>> 
>> Based on this I'm not sure that we should have separate components but that the XML based component should just be moved to using the SDK (assuming there are only advantages and no disadvantages in doing so).  Doing anything else will just result in twice as much code to maintain with both components doing the same thing (or worse yet, similar things but with huge differences in implementation from the user's perspective).  Converting the existing XML integration to use the SDK will ensure that we have a single solution in place and that no functionality in the existing component is lost.
>> 
>> Regards
>> Scott
>> 
>> HotWax Media
>> http://www.hotwaxmedia.com
>> 
>> On 2/02/2010, at 7:16 PM, hansbak@apache.org wrote:
>> 
>>> Author: hansbak
>>> Date: Wed Feb  3 03:16:07 2010
>>> New Revision: 905876
>>> 
>>> URL: http://svn.apache.org/viewvc?rev=905876&view=rev
>>> Log:
>>> move the java api functions from the existing ebay component to the new ebaystore component: no functional changes
>>> 
>> 
> -- 
> Antwebsystems.com: Quality OFBiz services for competitive rates
> 


Re: svn commit: r905876 [1/7] - in /ofbiz/trunk: applications/commonext/documents/ specialpurpose/ specialpurpose/ebay/ specialpurpose/ebay/config/ specialpurpose/ebay/data/ specialpurpose/ebay/data/helpdata/ specialpurpose/ebay/entitydef/ specialpurpose/e...

Posted by Hans Bakker <ma...@antwebsystems.com>.
Scott,

You see the number of messages here? You think like us that everybody
reads this? (Stupid us :-) )

i propose a "work in progress" wiki page and somebody who will push
publication on this list, just what Jacques does well on the "what is
new" list. 

Actually the "work in progress" page could be the input for the "what is
new" page....

Regards,
Hans

On Tue, 2010-02-02 at 23:53 -0800, Scott Gray wrote:
> On 2/02/2010, at 11:43 PM, Hans Bakker wrote:
> 
> > Jacopo,
> > 
> > what we need is a wiki page where people can announce activities and
> > plans. Not only from committers but also from contributors and perhaps
> > even users.
> > 
> > I have proposed this before. 
> 
> That's what we use the dev list for though right?  What would a wiki page have achieved that simple discussions on the mailing list wouldn't have?



Re: svn commit: r905876 [1/7] - in /ofbiz/trunk: applications/commonext/documents/ specialpurpose/ specialpurpose/ebay/ specialpurpose/ebay/config/ specialpurpose/ebay/data/ specialpurpose/ebay/data/helpdata/ specialpurpose/ebay/entitydef/ specialpurpose/e

Posted by Jacques Le Roux <ja...@free.fr>.
From: "Scott Gray" <sc...@hotwaxmedia.com>
On 2/02/2010, at 11:43 PM, Hans Bakker wrote:
> Jacopo,
>
> what we need is a wiki page where people can announce activities and
> plans. Not only from committers but also from contributors and perhaps
> even users.
>
> I have proposed this before.

Scott: That's what we use the dev list for though right?  What would a wiki page have achieved that simple discussions on the 
mailing list wouldn't have?

I totally agree with Scott, and actually this has been stated many times before. The dev ML has a far wider scope than a page in the 
Wiki. However I agree that at some point in the discussion a page may be needed. Please guys keep things simple, this is only good 
sense.

I don't want to be quibbling (though I'm sure I'd love it, a new word for me BTW ;o) but here is how I think we suppose things 
should go

Simple vs complex or big

* Simple: no need to discuss, this would else make things more clompicated than it needs.Of course here good sense may be tripped up 
(another new phrase, great day)
* Complex or big: discuss it on dev ML, may need a page in Wiki and/or  a Jira issue

Hans, sorry to say that, if I'm not wrong, you did not copy your propositions on private to the dev ML. So many interested persons 
are not aware of what you speak about

My 2cts

Jacques 


Re: svn commit: r905876 [1/7] - in /ofbiz/trunk: applications/commonext/documents/ specialpurpose/ specialpurpose/ebay/ specialpurpose/ebay/config/ specialpurpose/ebay/data/ specialpurpose/ebay/data/helpdata/ specialpurpose/ebay/entitydef/ specialpurpose/e...

Posted by Scott Gray <sc...@hotwaxmedia.com>.
On 2/02/2010, at 11:43 PM, Hans Bakker wrote:

> Jacopo,
> 
> what we need is a wiki page where people can announce activities and
> plans. Not only from committers but also from contributors and perhaps
> even users.
> 
> I have proposed this before. 

That's what we use the dev list for though right?  What would a wiki page have achieved that simple discussions on the mailing list wouldn't have?

> 
> In this case we tried to extend the existing ebay component but found
> out that the xml interface could never support the required functions as
> we needed them. Please also remember that not all required functions
> were known from the start.

As I mentioned earlier, it is my understanding that the SDK is just a tool for using the XML or SOAP interfaces, so I'm interested to know what wasn't possible via the XML interface?

Regards
Scott

> 
> Regards,
> Hans
> 
> 
> On Wed, 2010-02-03 at 08:30 +0100, Jacopo Cappellato wrote:
>> Hi Hans,
>> 
>> first of all, thank you for contributing this big amount of code.
>> 
>> On Feb 3, 2010, at 5:05 AM, Hans Bakker wrote:
>> 
>>> Hi Scott,
>>> 
>>> I am also not sure if we need 2 components. That can only be decided by
>>> the users of the original Ebay component isn't it? I do not know the
>>> user requirements of the original ebay component.
>>> 
>> 
>> Having two components with potentially overlapping features for the same integration in the official trunk will cause maintenance problems and confusion; I guess we will all agree on this.
>> I am not asking you to redo your job, it is too late, but... can we agree that from now on, before implementing a new feature in the trunk (or, even worst, before adding a new component) we have to study and understand what already exists and do our best to enhance the existing stuff?
>> 
>>> Now we moved the new functionality to a separate component it is getting
>>> more clear if the old component is still required or not.
>>> 
>> 
>> This is a pain, but we will do this, I can't see another solution now, as soon as you have completed your work: instead of you studying the original ebay component we will have to study your new work and verify if the new component implements all the features covered by the old one and in the same way; if this will not be true... I don't know what we will do.
>> 
>> Kind regards,
>> 
>> Jacopo
>> 
>> 
>>> Let us first complete the new component and get it fully tested and then
>>> restart this discussion.
>>> 
>>> Regards,
>>> Hans
>>> 
>>> On Tue, 2010-02-02 at 19:46 -0800, Scott Gray wrote:
>>>> Okay so once I saw this I took the 5 minutes necessary to look at eBay's services and start thinking that this commit is a bad idea.
>>>> Please correct me if any of the following is wrong:
>>>> - When you originally brought this up, you described the problem as one of XML vs. API but I think what you actually meant is eBay SDK vs. using XML directly?
>>>> - You mentioned that the API (SDK) provides additional functionality but it appears to me that it simply abstracts the use of raw SOAP or XML when interacting with the actual API?
>>>> 
>>>> Based on this I'm not sure that we should have separate components but that the XML based component should just be moved to using the SDK (assuming there are only advantages and no disadvantages in doing so).  Doing anything else will just result in twice as much code to maintain with both components doing the same thing (or worse yet, similar things but with huge differences in implementation from the user's perspective).  Converting the existing XML integration to use the SDK will ensure that we have a single solution in place and that no functionality in the existing component is lost.
>>>> 
>>>> Regards
>>>> Scott
>>>> 
>>>> HotWax Media
>>>> http://www.hotwaxmedia.com
>>>> 
>>>> On 2/02/2010, at 7:16 PM, hansbak@apache.org wrote:
>>>> 
>>>>> Author: hansbak
>>>>> Date: Wed Feb  3 03:16:07 2010
>>>>> New Revision: 905876
>>>>> 
>>>>> URL: http://svn.apache.org/viewvc?rev=905876&view=rev
>>>>> Log:
>>>>> move the java api functions from the existing ebay component to the new ebaystore component: no functional changes
>>>>> 
>>>> 
>>> -- 
>>> Antwebsystems.com: Quality OFBiz services for competitive rates
>>> 
>> 
> -- 
> Antwebsystems.com: Quality OFBiz services for competitive rates
> 


Re: svn commit: r905876 [1/7] - in /ofbiz/trunk: applications/commonext/documents/ specialpurpose/ specialpurpose/ebay/ specialpurpose/ebay/config/ specialpurpose/ebay/data/ specialpurpose/ebay/data/helpdata/ specialpurpose/ebay/entitydef/ specialpurpose/e...

Posted by Hans Bakker <ma...@antwebsystems.com>.
Hi Scott,

I only wondering why you send this email, can you explain that to me?

Anyway, thanks for asking, i still think it is required. It showed with
the ebay component:

1. creators of the original component would have liked to discuss it. 
2. a non committer had already developed a component as we just did.

so a lot of effort could have been saved here.....

However if nobody wants it, sure i will give up.

don't worry about that.

Regards,
Hans

On Wed, 2010-02-03 at 22:40 -0800, Scott Gray wrote:
> Hi Hans,
> 
> Based on your recent commits I guess your considering this discussion over?
> 
> Regards
> Scott
> 
> On 3/02/2010, at 1:01 AM, Jacopo Cappellato wrote:
> 
> > 
> > On Feb 3, 2010, at 8:43 AM, Hans Bakker wrote:
> > 
> >> Jacopo,
> >> 
> >> what we need is a wiki page where people can announce activities and
> >> plans. Not only from committers but also from contributors and perhaps
> >> even users.
> >> 
> >> I have proposed this before. 
> >> 
> > 
> > I think we already have something similar:
> > 
> > http://cwiki.apache.org/confluence/display/OFBADMIN/New+Features+Roadmap+-+Living+Document
> > 
> >> In this case we tried to extend the existing ebay component but found
> >> out that the xml interface could never support the required functions as
> >> we needed them.
> > 
> > This is not a good reason for stopping your research about supported features and building a new component.
> > The valid options I see are:
> > 1) adding *new* features to the original component using the different technology
> > 2) and enhancing the existing features, where needed, using the XML approach or
> > 3) reimplement the existing features in the original component with the new technology before enhancing them
> > 
> > Jacopo
> > 
> >> Please also remember that not all required functions
> >> were known from the start.
> >> 
> >> Regards,
> >> Hans
> >> 
> >> 
> >> On Wed, 2010-02-03 at 08:30 +0100, Jacopo Cappellato wrote:
> >>> Hi Hans,
> >>> 
> >>> first of all, thank you for contributing this big amount of code.
> >>> 
> >>> On Feb 3, 2010, at 5:05 AM, Hans Bakker wrote:
> >>> 
> >>>> Hi Scott,
> >>>> 
> >>>> I am also not sure if we need 2 components. That can only be decided by
> >>>> the users of the original Ebay component isn't it? I do not know the
> >>>> user requirements of the original ebay component.
> >>>> 
> >>> 
> >>> Having two components with potentially overlapping features for the same integration in the official trunk will cause maintenance problems and confusion; I guess we will all agree on this.
> >>> I am not asking you to redo your job, it is too late, but... can we agree that from now on, before implementing a new feature in the trunk (or, even worst, before adding a new component) we have to study and understand what already exists and do our best to enhance the existing stuff?
> >>> 
> >>>> Now we moved the new functionality to a separate component it is getting
> >>>> more clear if the old component is still required or not.
> >>>> 
> >>> 
> >>> This is a pain, but we will do this, I can't see another solution now, as soon as you have completed your work: instead of you studying the original ebay component we will have to study your new work and verify if the new component implements all the features covered by the old one and in the same way; if this will not be true... I don't know what we will do.
> >>> 
> >>> Kind regards,
> >>> 
> >>> Jacopo
> >>> 
> >>> 
> >>>> Let us first complete the new component and get it fully tested and then
> >>>> restart this discussion.
> >>>> 
> >>>> Regards,
> >>>> Hans
> >>>> 
> >>>> On Tue, 2010-02-02 at 19:46 -0800, Scott Gray wrote:
> >>>>> Okay so once I saw this I took the 5 minutes necessary to look at eBay's services and start thinking that this commit is a bad idea.
> >>>>> Please correct me if any of the following is wrong:
> >>>>> - When you originally brought this up, you described the problem as one of XML vs. API but I think what you actually meant is eBay SDK vs. using XML directly?
> >>>>> - You mentioned that the API (SDK) provides additional functionality but it appears to me that it simply abstracts the use of raw SOAP or XML when interacting with the actual API?
> >>>>> 
> >>>>> Based on this I'm not sure that we should have separate components but that the XML based component should just be moved to using the SDK (assuming there are only advantages and no disadvantages in doing so).  Doing anything else will just result in twice as much code to maintain with both components doing the same thing (or worse yet, similar things but with huge differences in implementation from the user's perspective).  Converting the existing XML integration to use the SDK will ensure that we have a single solution in place and that no functionality in the existing component is lost.
> >>>>> 
> >>>>> Regards
> >>>>> Scott
> >>>>> 
> >>>>> HotWax Media
> >>>>> http://www.hotwaxmedia.com
> >>>>> 
> >>>>> On 2/02/2010, at 7:16 PM, hansbak@apache.org wrote:
> >>>>> 
> >>>>>> Author: hansbak
> >>>>>> Date: Wed Feb  3 03:16:07 2010
> >>>>>> New Revision: 905876
> >>>>>> 
> >>>>>> URL: http://svn.apache.org/viewvc?rev=905876&view=rev
> >>>>>> Log:
> >>>>>> move the java api functions from the existing ebay component to the new ebaystore component: no functional changes
> >>>>>> 
> >>>>> 
> >>>> -- 
> >>>> Antwebsystems.com: Quality OFBiz services for competitive rates
> >>>> 
> >>> 
> >> -- 
> >> Antwebsystems.com: Quality OFBiz services for competitive rates
> >> 
> > 
> 
-- 
Antwebsystems.com: Quality OFBiz services for competitive rates


Re: svn commit: r905876 [1/7] - in /ofbiz/trunk: applications/commonext/documents/ specialpurpose/ specialpurpose/ebay/ specialpurpose/ebay/config/ specialpurpose/ebay/data/ specialpurpose/ebay/data/helpdata/ specialpurpose/ebay/entitydef/ specialpurpose/e...

Posted by Scott Gray <sc...@hotwaxmedia.com>.
Hi Hans,

Based on your recent commits I guess your considering this discussion over?

Regards
Scott

On 3/02/2010, at 1:01 AM, Jacopo Cappellato wrote:

> 
> On Feb 3, 2010, at 8:43 AM, Hans Bakker wrote:
> 
>> Jacopo,
>> 
>> what we need is a wiki page where people can announce activities and
>> plans. Not only from committers but also from contributors and perhaps
>> even users.
>> 
>> I have proposed this before. 
>> 
> 
> I think we already have something similar:
> 
> http://cwiki.apache.org/confluence/display/OFBADMIN/New+Features+Roadmap+-+Living+Document
> 
>> In this case we tried to extend the existing ebay component but found
>> out that the xml interface could never support the required functions as
>> we needed them.
> 
> This is not a good reason for stopping your research about supported features and building a new component.
> The valid options I see are:
> 1) adding *new* features to the original component using the different technology
> 2) and enhancing the existing features, where needed, using the XML approach or
> 3) reimplement the existing features in the original component with the new technology before enhancing them
> 
> Jacopo
> 
>> Please also remember that not all required functions
>> were known from the start.
>> 
>> Regards,
>> Hans
>> 
>> 
>> On Wed, 2010-02-03 at 08:30 +0100, Jacopo Cappellato wrote:
>>> Hi Hans,
>>> 
>>> first of all, thank you for contributing this big amount of code.
>>> 
>>> On Feb 3, 2010, at 5:05 AM, Hans Bakker wrote:
>>> 
>>>> Hi Scott,
>>>> 
>>>> I am also not sure if we need 2 components. That can only be decided by
>>>> the users of the original Ebay component isn't it? I do not know the
>>>> user requirements of the original ebay component.
>>>> 
>>> 
>>> Having two components with potentially overlapping features for the same integration in the official trunk will cause maintenance problems and confusion; I guess we will all agree on this.
>>> I am not asking you to redo your job, it is too late, but... can we agree that from now on, before implementing a new feature in the trunk (or, even worst, before adding a new component) we have to study and understand what already exists and do our best to enhance the existing stuff?
>>> 
>>>> Now we moved the new functionality to a separate component it is getting
>>>> more clear if the old component is still required or not.
>>>> 
>>> 
>>> This is a pain, but we will do this, I can't see another solution now, as soon as you have completed your work: instead of you studying the original ebay component we will have to study your new work and verify if the new component implements all the features covered by the old one and in the same way; if this will not be true... I don't know what we will do.
>>> 
>>> Kind regards,
>>> 
>>> Jacopo
>>> 
>>> 
>>>> Let us first complete the new component and get it fully tested and then
>>>> restart this discussion.
>>>> 
>>>> Regards,
>>>> Hans
>>>> 
>>>> On Tue, 2010-02-02 at 19:46 -0800, Scott Gray wrote:
>>>>> Okay so once I saw this I took the 5 minutes necessary to look at eBay's services and start thinking that this commit is a bad idea.
>>>>> Please correct me if any of the following is wrong:
>>>>> - When you originally brought this up, you described the problem as one of XML vs. API but I think what you actually meant is eBay SDK vs. using XML directly?
>>>>> - You mentioned that the API (SDK) provides additional functionality but it appears to me that it simply abstracts the use of raw SOAP or XML when interacting with the actual API?
>>>>> 
>>>>> Based on this I'm not sure that we should have separate components but that the XML based component should just be moved to using the SDK (assuming there are only advantages and no disadvantages in doing so).  Doing anything else will just result in twice as much code to maintain with both components doing the same thing (or worse yet, similar things but with huge differences in implementation from the user's perspective).  Converting the existing XML integration to use the SDK will ensure that we have a single solution in place and that no functionality in the existing component is lost.
>>>>> 
>>>>> Regards
>>>>> Scott
>>>>> 
>>>>> HotWax Media
>>>>> http://www.hotwaxmedia.com
>>>>> 
>>>>> On 2/02/2010, at 7:16 PM, hansbak@apache.org wrote:
>>>>> 
>>>>>> Author: hansbak
>>>>>> Date: Wed Feb  3 03:16:07 2010
>>>>>> New Revision: 905876
>>>>>> 
>>>>>> URL: http://svn.apache.org/viewvc?rev=905876&view=rev
>>>>>> Log:
>>>>>> move the java api functions from the existing ebay component to the new ebaystore component: no functional changes
>>>>>> 
>>>>> 
>>>> -- 
>>>> Antwebsystems.com: Quality OFBiz services for competitive rates
>>>> 
>>> 
>> -- 
>> Antwebsystems.com: Quality OFBiz services for competitive rates
>> 
> 


Re: svn commit: r905876 [1/7] - in /ofbiz/trunk: applications/commonext/documents/ specialpurpose/ specialpurpose/ebay/ specialpurpose/ebay/config/ specialpurpose/ebay/data/ specialpurpose/ebay/data/helpdata/ specialpurpose/ebay/entitydef/ specialpurpose/e...

Posted by Jacopo Cappellato <ja...@hotwaxmedia.com>.
On Feb 3, 2010, at 8:43 AM, Hans Bakker wrote:

> Jacopo,
> 
> what we need is a wiki page where people can announce activities and
> plans. Not only from committers but also from contributors and perhaps
> even users.
> 
> I have proposed this before. 
> 

I think we already have something similar:

http://cwiki.apache.org/confluence/display/OFBADMIN/New+Features+Roadmap+-+Living+Document

> In this case we tried to extend the existing ebay component but found
> out that the xml interface could never support the required functions as
> we needed them.

This is not a good reason for stopping your research about supported features and building a new component.
The valid options I see are:
1) adding *new* features to the original component using the different technology
2) and enhancing the existing features, where needed, using the XML approach or
3) reimplement the existing features in the original component with the new technology before enhancing them

Jacopo

> Please also remember that not all required functions
> were known from the start.
> 
> Regards,
> Hans
> 
> 
> On Wed, 2010-02-03 at 08:30 +0100, Jacopo Cappellato wrote:
>> Hi Hans,
>> 
>> first of all, thank you for contributing this big amount of code.
>> 
>> On Feb 3, 2010, at 5:05 AM, Hans Bakker wrote:
>> 
>>> Hi Scott,
>>> 
>>> I am also not sure if we need 2 components. That can only be decided by
>>> the users of the original Ebay component isn't it? I do not know the
>>> user requirements of the original ebay component.
>>> 
>> 
>> Having two components with potentially overlapping features for the same integration in the official trunk will cause maintenance problems and confusion; I guess we will all agree on this.
>> I am not asking you to redo your job, it is too late, but... can we agree that from now on, before implementing a new feature in the trunk (or, even worst, before adding a new component) we have to study and understand what already exists and do our best to enhance the existing stuff?
>> 
>>> Now we moved the new functionality to a separate component it is getting
>>> more clear if the old component is still required or not.
>>> 
>> 
>> This is a pain, but we will do this, I can't see another solution now, as soon as you have completed your work: instead of you studying the original ebay component we will have to study your new work and verify if the new component implements all the features covered by the old one and in the same way; if this will not be true... I don't know what we will do.
>> 
>> Kind regards,
>> 
>> Jacopo
>> 
>> 
>>> Let us first complete the new component and get it fully tested and then
>>> restart this discussion.
>>> 
>>> Regards,
>>> Hans
>>> 
>>> On Tue, 2010-02-02 at 19:46 -0800, Scott Gray wrote:
>>>> Okay so once I saw this I took the 5 minutes necessary to look at eBay's services and start thinking that this commit is a bad idea.
>>>> Please correct me if any of the following is wrong:
>>>> - When you originally brought this up, you described the problem as one of XML vs. API but I think what you actually meant is eBay SDK vs. using XML directly?
>>>> - You mentioned that the API (SDK) provides additional functionality but it appears to me that it simply abstracts the use of raw SOAP or XML when interacting with the actual API?
>>>> 
>>>> Based on this I'm not sure that we should have separate components but that the XML based component should just be moved to using the SDK (assuming there are only advantages and no disadvantages in doing so).  Doing anything else will just result in twice as much code to maintain with both components doing the same thing (or worse yet, similar things but with huge differences in implementation from the user's perspective).  Converting the existing XML integration to use the SDK will ensure that we have a single solution in place and that no functionality in the existing component is lost.
>>>> 
>>>> Regards
>>>> Scott
>>>> 
>>>> HotWax Media
>>>> http://www.hotwaxmedia.com
>>>> 
>>>> On 2/02/2010, at 7:16 PM, hansbak@apache.org wrote:
>>>> 
>>>>> Author: hansbak
>>>>> Date: Wed Feb  3 03:16:07 2010
>>>>> New Revision: 905876
>>>>> 
>>>>> URL: http://svn.apache.org/viewvc?rev=905876&view=rev
>>>>> Log:
>>>>> move the java api functions from the existing ebay component to the new ebaystore component: no functional changes
>>>>> 
>>>> 
>>> -- 
>>> Antwebsystems.com: Quality OFBiz services for competitive rates
>>> 
>> 
> -- 
> Antwebsystems.com: Quality OFBiz services for competitive rates
> 


Re: svn commit: r905876 [1/7] - in /ofbiz/trunk: applications/commonext/documents/ specialpurpose/ specialpurpose/ebay/ specialpurpose/ebay/config/ specialpurpose/ebay/data/ specialpurpose/ebay/data/helpdata/ specialpurpose/ebay/entitydef/ specialpurpose/e...

Posted by Hans Bakker <ma...@antwebsystems.com>.
Jacopo,

what we need is a wiki page where people can announce activities and
plans. Not only from committers but also from contributors and perhaps
even users.

I have proposed this before. 

In this case we tried to extend the existing ebay component but found
out that the xml interface could never support the required functions as
we needed them. Please also remember that not all required functions
were known from the start.

Regards,
Hans
 

On Wed, 2010-02-03 at 08:30 +0100, Jacopo Cappellato wrote:
> Hi Hans,
> 
> first of all, thank you for contributing this big amount of code.
> 
> On Feb 3, 2010, at 5:05 AM, Hans Bakker wrote:
> 
> > Hi Scott,
> > 
> > I am also not sure if we need 2 components. That can only be decided by
> > the users of the original Ebay component isn't it? I do not know the
> > user requirements of the original ebay component.
> > 
> 
> Having two components with potentially overlapping features for the same integration in the official trunk will cause maintenance problems and confusion; I guess we will all agree on this.
> I am not asking you to redo your job, it is too late, but... can we agree that from now on, before implementing a new feature in the trunk (or, even worst, before adding a new component) we have to study and understand what already exists and do our best to enhance the existing stuff?
> 
> > Now we moved the new functionality to a separate component it is getting
> > more clear if the old component is still required or not.
> > 
> 
> This is a pain, but we will do this, I can't see another solution now, as soon as you have completed your work: instead of you studying the original ebay component we will have to study your new work and verify if the new component implements all the features covered by the old one and in the same way; if this will not be true... I don't know what we will do.
> 
> Kind regards,
> 
> Jacopo
> 
> 
> > Let us first complete the new component and get it fully tested and then
> > restart this discussion.
> > 
> > Regards,
> > Hans
> > 
> > On Tue, 2010-02-02 at 19:46 -0800, Scott Gray wrote:
> >> Okay so once I saw this I took the 5 minutes necessary to look at eBay's services and start thinking that this commit is a bad idea.
> >> Please correct me if any of the following is wrong:
> >> - When you originally brought this up, you described the problem as one of XML vs. API but I think what you actually meant is eBay SDK vs. using XML directly?
> >> - You mentioned that the API (SDK) provides additional functionality but it appears to me that it simply abstracts the use of raw SOAP or XML when interacting with the actual API?
> >> 
> >> Based on this I'm not sure that we should have separate components but that the XML based component should just be moved to using the SDK (assuming there are only advantages and no disadvantages in doing so).  Doing anything else will just result in twice as much code to maintain with both components doing the same thing (or worse yet, similar things but with huge differences in implementation from the user's perspective).  Converting the existing XML integration to use the SDK will ensure that we have a single solution in place and that no functionality in the existing component is lost.
> >> 
> >> Regards
> >> Scott
> >> 
> >> HotWax Media
> >> http://www.hotwaxmedia.com
> >> 
> >> On 2/02/2010, at 7:16 PM, hansbak@apache.org wrote:
> >> 
> >>> Author: hansbak
> >>> Date: Wed Feb  3 03:16:07 2010
> >>> New Revision: 905876
> >>> 
> >>> URL: http://svn.apache.org/viewvc?rev=905876&view=rev
> >>> Log:
> >>> move the java api functions from the existing ebay component to the new ebaystore component: no functional changes
> >>> 
> >> 
> > -- 
> > Antwebsystems.com: Quality OFBiz services for competitive rates
> > 
> 
-- 
Antwebsystems.com: Quality OFBiz services for competitive rates


Re: svn commit: r905876 [1/7] - in /ofbiz/trunk: applications/commonext/documents/ specialpurpose/ specialpurpose/ebay/ specialpurpose/ebay/config/ specialpurpose/ebay/data/ specialpurpose/ebay/data/helpdata/ specialpurpose/ebay/entitydef/ specialpurpose/e...

Posted by Jacopo Cappellato <ja...@hotwaxmedia.com>.
Hi Hans,

first of all, thank you for contributing this big amount of code.

On Feb 3, 2010, at 5:05 AM, Hans Bakker wrote:

> Hi Scott,
> 
> I am also not sure if we need 2 components. That can only be decided by
> the users of the original Ebay component isn't it? I do not know the
> user requirements of the original ebay component.
> 

Having two components with potentially overlapping features for the same integration in the official trunk will cause maintenance problems and confusion; I guess we will all agree on this.
I am not asking you to redo your job, it is too late, but... can we agree that from now on, before implementing a new feature in the trunk (or, even worst, before adding a new component) we have to study and understand what already exists and do our best to enhance the existing stuff?

> Now we moved the new functionality to a separate component it is getting
> more clear if the old component is still required or not.
> 

This is a pain, but we will do this, I can't see another solution now, as soon as you have completed your work: instead of you studying the original ebay component we will have to study your new work and verify if the new component implements all the features covered by the old one and in the same way; if this will not be true... I don't know what we will do.

Kind regards,

Jacopo


> Let us first complete the new component and get it fully tested and then
> restart this discussion.
> 
> Regards,
> Hans
> 
> On Tue, 2010-02-02 at 19:46 -0800, Scott Gray wrote:
>> Okay so once I saw this I took the 5 minutes necessary to look at eBay's services and start thinking that this commit is a bad idea.
>> Please correct me if any of the following is wrong:
>> - When you originally brought this up, you described the problem as one of XML vs. API but I think what you actually meant is eBay SDK vs. using XML directly?
>> - You mentioned that the API (SDK) provides additional functionality but it appears to me that it simply abstracts the use of raw SOAP or XML when interacting with the actual API?
>> 
>> Based on this I'm not sure that we should have separate components but that the XML based component should just be moved to using the SDK (assuming there are only advantages and no disadvantages in doing so).  Doing anything else will just result in twice as much code to maintain with both components doing the same thing (or worse yet, similar things but with huge differences in implementation from the user's perspective).  Converting the existing XML integration to use the SDK will ensure that we have a single solution in place and that no functionality in the existing component is lost.
>> 
>> Regards
>> Scott
>> 
>> HotWax Media
>> http://www.hotwaxmedia.com
>> 
>> On 2/02/2010, at 7:16 PM, hansbak@apache.org wrote:
>> 
>>> Author: hansbak
>>> Date: Wed Feb  3 03:16:07 2010
>>> New Revision: 905876
>>> 
>>> URL: http://svn.apache.org/viewvc?rev=905876&view=rev
>>> Log:
>>> move the java api functions from the existing ebay component to the new ebaystore component: no functional changes
>>> 
>> 
> -- 
> Antwebsystems.com: Quality OFBiz services for competitive rates
> 


Re: svn commit: r905876 [1/7] - in /ofbiz/trunk: applications/commonext/documents/ specialpurpose/ specialpurpose/ebay/ specialpurpose/ebay/config/ specialpurpose/ebay/data/ specialpurpose/ebay/data/helpdata/ specialpurpose/ebay/entitydef/ specialpurpose/e...

Posted by Hans Bakker <ma...@antwebsystems.com>.
Hi Scott,

I am also not sure if we need 2 components. That can only be decided by
the users of the original Ebay component isn't it? I do not know the
user requirements of the original ebay component.

Now we moved the new functionality to a separate component it is getting
more clear if the old component is still required or not.

Let us first complete the new component and get it fully tested and then
restart this discussion.

Regards,
Hans

On Tue, 2010-02-02 at 19:46 -0800, Scott Gray wrote:
> Okay so once I saw this I took the 5 minutes necessary to look at eBay's services and start thinking that this commit is a bad idea.
> Please correct me if any of the following is wrong:
> - When you originally brought this up, you described the problem as one of XML vs. API but I think what you actually meant is eBay SDK vs. using XML directly?
> - You mentioned that the API (SDK) provides additional functionality but it appears to me that it simply abstracts the use of raw SOAP or XML when interacting with the actual API?
> 
> Based on this I'm not sure that we should have separate components but that the XML based component should just be moved to using the SDK (assuming there are only advantages and no disadvantages in doing so).  Doing anything else will just result in twice as much code to maintain with both components doing the same thing (or worse yet, similar things but with huge differences in implementation from the user's perspective).  Converting the existing XML integration to use the SDK will ensure that we have a single solution in place and that no functionality in the existing component is lost.
> 
> Regards
> Scott
> 
> HotWax Media
> http://www.hotwaxmedia.com
> 
> On 2/02/2010, at 7:16 PM, hansbak@apache.org wrote:
> 
> > Author: hansbak
> > Date: Wed Feb  3 03:16:07 2010
> > New Revision: 905876
> > 
> > URL: http://svn.apache.org/viewvc?rev=905876&view=rev
> > Log:
> > move the java api functions from the existing ebay component to the new ebaystore component: no functional changes
> > 
> 
-- 
Antwebsystems.com: Quality OFBiz services for competitive rates


Re: svn commit: r905876 [1/7] - in /ofbiz/trunk: applications/commonext/documents/ specialpurpose/ specialpurpose/ebay/ specialpurpose/ebay/config/ specialpurpose/ebay/data/ specialpurpose/ebay/data/helpdata/ specialpurpose/ebay/entitydef/ specialpurpose/e

Posted by Tim Ruppert <ti...@hotwaxmedia.com>.
Just wanted to bump this since we're now approaching the middle of the month.  Ashish, if you can point Hans to your writeup I'm sure this will help get this party started.

I'd really like to see this consolidated before the release candidate gets put together in early April - and I'm sure a lot of others feel this way.  Hans, let us know what we can do to help you to document and explain all the differences and reasons that we have another eBay component (obviously outside of the technology choice that drove this initially).

Looking forward to getting this rectified.

Cheers,
Ruppert

On Feb 25, 2010, at 12:25 AM, Tim Ruppert wrote:

> Great - looking forward to hearing more next week - good luck on the rest of it.
> 
> Cheers,
> Ruppert
> 
> On Feb 25, 2010, at 12:19 AM, Hans Bakker wrote:
> 
>> Hi Ruppert,
>> 
>> can at the moment only repeat what i said before...let us first finish
>> it we plan to finish it at the end of this month, more probably next
>> week....
>> 
>> Regards,
>> Hans
>> 
>> On Thu, 2010-02-25 at 00:01 -0700, Tim Ruppert wrote:
>>> Hans, I see you've been busy again in the ebaystore and just wanted to get an update on when we might be able to see what's going on so that the community can help get back to the single ebay component again soon.  I hope things are going well on that new impl!
>>> 
>>> Cheers,
>>> Ruppert
>>> 
>>> On Feb 16, 2010, at 2:04 AM, Tim Ruppert wrote:
>>> 
>>>> Thanks Hans - and please just come with some information so that we, as a group, can try to get this reconciled into one app again.
>>>> 
>>>> Cheers,
>>>> Ruppert
>>>> 
>>>> On Feb 15, 2010, at 7:18 PM, Hans Bakker wrote:
>>>> 
>>>>> Do not worry we are still working on it. This week we will do some more
>>>>> commits. We plan to have this finished the end of this month.
>>>>> 
>>>>> Regards,
>>>>> Hans
>>>>> 
>>>>> On Mon, 2010-02-15 at 08:42 -0800, rohit wrote:
>>>>>> Hi Hans,
>>>>>> 
>>>>>> Just checking if you have reached where you intend with this implementation.
>>>>>> I hope that you have been not put off from developing it further. I have
>>>>>> tried some of the features and think they can be very useful.
>>>>>> 
>>>>>> Thanks,
>>>>>> 
>>>>>> Rohit
>>>>>> 
>>>>> -- 
>>>>> Antwebsystems.com: Quality OFBiz services for competitive rates
>>>>> 
>>>> 
>>> 
>> -- 
>> Antwebsystems.com: Quality OFBiz services for competitive rates
>> 
> 


Re: svn commit: r905876 [1/7] - in /ofbiz/trunk: applications/commonext/documents/ specialpurpose/ specialpurpose/ebay/ specialpurpose/ebay/config/ specialpurpose/ebay/data/ specialpurpose/ebay/data/helpdata/ specialpurpose/ebay/entitydef/ specialpurpose/e

Posted by Tim Ruppert <ti...@hotwaxmedia.com>.
Great - looking forward to hearing more next week - good luck on the rest of it.

Cheers,
Ruppert

On Feb 25, 2010, at 12:19 AM, Hans Bakker wrote:

> Hi Ruppert,
> 
> can at the moment only repeat what i said before...let us first finish
> it we plan to finish it at the end of this month, more probably next
> week....
> 
> Regards,
> Hans
> 
> On Thu, 2010-02-25 at 00:01 -0700, Tim Ruppert wrote:
>> Hans, I see you've been busy again in the ebaystore and just wanted to get an update on when we might be able to see what's going on so that the community can help get back to the single ebay component again soon.  I hope things are going well on that new impl!
>> 
>> Cheers,
>> Ruppert
>> 
>> On Feb 16, 2010, at 2:04 AM, Tim Ruppert wrote:
>> 
>>> Thanks Hans - and please just come with some information so that we, as a group, can try to get this reconciled into one app again.
>>> 
>>> Cheers,
>>> Ruppert
>>> 
>>> On Feb 15, 2010, at 7:18 PM, Hans Bakker wrote:
>>> 
>>>> Do not worry we are still working on it. This week we will do some more
>>>> commits. We plan to have this finished the end of this month.
>>>> 
>>>> Regards,
>>>> Hans
>>>> 
>>>> On Mon, 2010-02-15 at 08:42 -0800, rohit wrote:
>>>>> Hi Hans,
>>>>> 
>>>>> Just checking if you have reached where you intend with this implementation.
>>>>> I hope that you have been not put off from developing it further. I have
>>>>> tried some of the features and think they can be very useful.
>>>>> 
>>>>> Thanks,
>>>>> 
>>>>> Rohit
>>>>> 
>>>> -- 
>>>> Antwebsystems.com: Quality OFBiz services for competitive rates
>>>> 
>>> 
>> 
> -- 
> Antwebsystems.com: Quality OFBiz services for competitive rates
> 


Re: svn commit: r905876 [1/7] - in /ofbiz/trunk: applications/commonext/documents/ specialpurpose/ specialpurpose/ebay/ specialpurpose/ebay/config/ specialpurpose/ebay/data/ specialpurpose/ebay/data/helpdata/ specialpurpose/ebay/entitydef/ specialpurpose/e

Posted by Hans Bakker <ma...@antwebsystems.com>.
Hi Ruppert,

can at the moment only repeat what i said before...let us first finish
it we plan to finish it at the end of this month, more probably next
week....

Regards,
Hans

On Thu, 2010-02-25 at 00:01 -0700, Tim Ruppert wrote:
> Hans, I see you've been busy again in the ebaystore and just wanted to get an update on when we might be able to see what's going on so that the community can help get back to the single ebay component again soon.  I hope things are going well on that new impl!
> 
> Cheers,
> Ruppert
> 
> On Feb 16, 2010, at 2:04 AM, Tim Ruppert wrote:
> 
> > Thanks Hans - and please just come with some information so that we, as a group, can try to get this reconciled into one app again.
> > 
> > Cheers,
> > Ruppert
> > 
> > On Feb 15, 2010, at 7:18 PM, Hans Bakker wrote:
> > 
> >> Do not worry we are still working on it. This week we will do some more
> >> commits. We plan to have this finished the end of this month.
> >> 
> >> Regards,
> >> Hans
> >> 
> >> On Mon, 2010-02-15 at 08:42 -0800, rohit wrote:
> >>> Hi Hans,
> >>> 
> >>> Just checking if you have reached where you intend with this implementation.
> >>> I hope that you have been not put off from developing it further. I have
> >>> tried some of the features and think they can be very useful.
> >>> 
> >>> Thanks,
> >>> 
> >>> Rohit
> >>> 
> >> -- 
> >> Antwebsystems.com: Quality OFBiz services for competitive rates
> >> 
> > 
> 
-- 
Antwebsystems.com: Quality OFBiz services for competitive rates


Re: svn commit: r905876 [1/7] - in /ofbiz/trunk: applications/commonext/documents/ specialpurpose/ specialpurpose/ebay/ specialpurpose/ebay/config/ specialpurpose/ebay/data/ specialpurpose/ebay/data/helpdata/ specialpurpose/ebay/entitydef/ specialpurpose/e

Posted by Tim Ruppert <ti...@hotwaxmedia.com>.
Hans, I see you've been busy again in the ebaystore and just wanted to get an update on when we might be able to see what's going on so that the community can help get back to the single ebay component again soon.  I hope things are going well on that new impl!

Cheers,
Ruppert

On Feb 16, 2010, at 2:04 AM, Tim Ruppert wrote:

> Thanks Hans - and please just come with some information so that we, as a group, can try to get this reconciled into one app again.
> 
> Cheers,
> Ruppert
> 
> On Feb 15, 2010, at 7:18 PM, Hans Bakker wrote:
> 
>> Do not worry we are still working on it. This week we will do some more
>> commits. We plan to have this finished the end of this month.
>> 
>> Regards,
>> Hans
>> 
>> On Mon, 2010-02-15 at 08:42 -0800, rohit wrote:
>>> Hi Hans,
>>> 
>>> Just checking if you have reached where you intend with this implementation.
>>> I hope that you have been not put off from developing it further. I have
>>> tried some of the features and think they can be very useful.
>>> 
>>> Thanks,
>>> 
>>> Rohit
>>> 
>> -- 
>> Antwebsystems.com: Quality OFBiz services for competitive rates
>> 
> 


Re: svn commit: r905876 [1/7] - in /ofbiz/trunk: applications/commonext/documents/ specialpurpose/ specialpurpose/ebay/ specialpurpose/ebay/config/ specialpurpose/ebay/data/ specialpurpose/ebay/data/helpdata/ specialpurpose/ebay/entitydef/ specialpurpose/e

Posted by Tim Ruppert <ti...@hotwaxmedia.com>.
Thanks Hans - and please just come with some information so that we, as a group, can try to get this reconciled into one app again.

Cheers,
Ruppert

On Feb 15, 2010, at 7:18 PM, Hans Bakker wrote:

> Do not worry we are still working on it. This week we will do some more
> commits. We plan to have this finished the end of this month.
> 
> Regards,
> Hans
> 
> On Mon, 2010-02-15 at 08:42 -0800, rohit wrote:
>> Hi Hans,
>> 
>> Just checking if you have reached where you intend with this implementation.
>> I hope that you have been not put off from developing it further. I have
>> tried some of the features and think they can be very useful.
>> 
>> Thanks,
>> 
>> Rohit
>> 
> -- 
> Antwebsystems.com: Quality OFBiz services for competitive rates
> 


Re: svn commit: r905876 [1/7] - in /ofbiz/trunk: applications/commonext/documents/ specialpurpose/ specialpurpose/ebay/ specialpurpose/ebay/config/ specialpurpose/ebay/data/ specialpurpose/ebay/data/helpdata/ specialpurpose/ebay/entitydef/ specialpurpose/e

Posted by Hans Bakker <ma...@antwebsystems.com>.
Do not worry we are still working on it. This week we will do some more
commits. We plan to have this finished the end of this month.

Regards,
Hans

On Mon, 2010-02-15 at 08:42 -0800, rohit wrote:
> Hi Hans,
> 
> Just checking if you have reached where you intend with this implementation.
> I hope that you have been not put off from developing it further. I have
> tried some of the features and think they can be very useful.
> 
> Thanks,
> 
> Rohit
> 
-- 
Antwebsystems.com: Quality OFBiz services for competitive rates


Re: svn commit: r905876 [1/7] - in /ofbiz/trunk: applications/commonext/documents/ specialpurpose/ specialpurpose/ebay/ specialpurpose/ebay/config/ specialpurpose/ebay/data/ specialpurpose/ebay/data/helpdata/ specialpurpose/ebay/entitydef/ specialpurpose/e

Posted by rohit <ro...@yahoo.com>.
Hi Hans,

Just checking if you have reached where you intend with this implementation.
I hope that you have been not put off from developing it further. I have
tried some of the features and think they can be very useful.

Thanks,

Rohit

-- 
View this message in context: http://n4.nabble.com/Re-svn-commit-r905876-1-7-in-ofbiz-trunk-applications-commonext-documents-specialpurpose-specialpurp-tp1460707p1556314.html
Sent from the OFBiz - Dev mailing list archive at Nabble.com.