You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Attila Jeges (Code Review)" <ge...@cloudera.org> on 2019/08/14 18:54:11 UTC

[Impala-ASF-CR] IMPALA-8842: Accommodate HIVE-22046 - Step 2.

Attila Jeges has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/14043 )

Change subject: IMPALA-8842: Accommodate HIVE-22046 - Step 2.
......................................................................

IMPALA-8842: Accommodate HIVE-22046 - Step 2.

HIVE-22046 added 'engine' column to TAB_COL_STATS and PART_COL_STATS
HMS tables. The new column is used to differentiate among column stats
computed by different engines. The related HMS API calls were changed
accordingly.

This change is Step 2 in a series of steps to coordinate the introduction
of HMS API changes to Hive and Impala:

1. Change in Hive.
We push new APIs so Impala can use them. New APIs will simply call old
existing methods so there should not be any change of functionality
there. Since there were many incompatible changes, new APIs are tagged
method_name_V2.

2. Change in Impala.
Push changes to use new methods *V2.

3. Change in Hive
Push patch with complete functionality. *V2 methods contains the new
logic. The old existing methods are not used anymore by Impala at this
point, hence they can be removed. For every method_name_V2, I will
create a corresponding method method_name that calls the former one.

4. Change in Impala
Replace *V2 calls by *.

5. Change in Hive.
Remove *V2 methods from API.

This change also adds exclusions to fe/pom.xml and shaded-deps/pom.xml
to work around the hive hadoop2 dependency.

Change-Id: I9a73f5eeac8e84d63b22aaed5dfbcd8ea39f0af4
---
M bin/impala-config.sh
M fe/pom.xml
M fe/src/compat-hive-2/java/org/apache/impala/compat/MetastoreShim.java
M fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/catalog/local/DirectMetaProvider.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/test/java/org/apache/impala/catalog/CatalogTest.java
M shaded-deps/pom.xml
9 files changed, 106 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/43/14043/3
-- 
To view, visit http://gerrit.cloudera.org:8080/14043
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9a73f5eeac8e84d63b22aaed5dfbcd8ea39f0af4
Gerrit-Change-Number: 14043
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>