You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2022/07/31 22:35:03 UTC
[GitHub] [cordova-android] ath0mas opened a new pull request, #1471: fix: ANDROID_HOME is the new default, to check first and give advice
ath0mas opened a new pull request, #1471:
URL: https://github.com/apache/cordova-android/pull/1471
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
Android
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
cordova-android 11.0.0 reports about `Android SDK: undefined` while `ANDROID_HOME` is set and `ANDROID_SDK_ROOT` is not.
### Description
<!-- Describe your changes in detail -->
```
cordova create hello com.example.hello HelloWorld
cd hello/
cordova platform add android@11.0.0
cordova build
```
with environment variables set for Java (`JAVA_HOME`) and Android (`ANDROID_HOME`, and no more `ANDROID_SDK_ROOT`)
results in a successful build but with wrong reporting during the first steps:
```
Checking Java JDK and Android SDK versions
ANDROID_HOME=C:\my\path\to\android-sdk (recommended setting)
ANDROID_SDK_ROOT=undefined (DEPRECATED)
Using Android SDK: undefined
```
### Testing
<!-- Please describe in detail how you tested your changes. -->
- creating and building a blank project using local clone of my fork of cordova-android
- `npm run test`
### Checklist
- [x] I've run the tests to see all new and existing tests pass
- [x] I added automated test coverage as appropriate for this change
- [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [x] I've updated the documentation if necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] breautek commented on pull request #1471: fix!: ANDROID_HOME is the new default, to check first and give advice
Posted by "breautek (via GitHub)" <gi...@apache.org>.
breautek commented on PR #1471:
URL: https://github.com/apache/cordova-android/pull/1471#issuecomment-1500952181
Final call for review before merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] breautek merged pull request #1471: fix!: ANDROID_HOME is the new default, to check first and give advice
Posted by "breautek (via GitHub)" <gi...@apache.org>.
breautek merged PR #1471:
URL: https://github.com/apache/cordova-android/pull/1471
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-commenter commented on pull request #1471: fix: ANDROID_HOME is the new default, to check first and give advice
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #1471:
URL: https://github.com/apache/cordova-android/pull/1471#issuecomment-1200515170
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1471?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1471](https://codecov.io/gh/apache/cordova-android/pull/1471?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b06f3db) into [master](https://codecov.io/gh/apache/cordova-android/commit/60e3803c67734087b7a6ff8ee8bd3a659cb050f8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (60e3803) will **not change** coverage.
> The diff coverage is `50.00%`.
```diff
@@ Coverage Diff @@
## master #1471 +/- ##
=======================================
Coverage 72.25% 72.25%
=======================================
Files 21 21
Lines 1748 1748
=======================================
Hits 1263 1263
Misses 485 485
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/1471?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [lib/check\_reqs.js](https://codecov.io/gh/apache/cordova-android/pull/1471/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliL2NoZWNrX3JlcXMuanM=) | `71.05% <50.00%> (ø)` | |
Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] breautek commented on pull request #1471: fix!: ANDROID_HOME is the new default, to check first and give advice
Posted by "breautek (via GitHub)" <gi...@apache.org>.
breautek commented on PR #1471:
URL: https://github.com/apache/cordova-android/pull/1471#issuecomment-1501239394
Thank you @ath0mas for helping us keep up with Android tooling standards.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org