You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2022/04/13 23:53:46 UTC
[GitHub] [helix] xyuanlu opened a new pull request, #2035: MaintenanceManagementService improvement - Allow implementation of OperationInterface to return null
xyuanlu opened a new pull request, #2035:
URL: https://github.com/apache/helix/pull/2035
### Issues
- [X] My PR addresses the following Helix issues and references them in the PR description:
#2034
### Description
- [X] Here are some details about my PR, including screenshots of any UI changes:
Maintenance Management service fails silently when user provided OperationInterface returns null in take/freeInstance API.
We should allow user provided OperationInterface to return null.
### Tests
- [X] The following tests are written for this issue:
Modified TestOperationImpl.java.
TestInstanceAccessor will cover null case.
- The following is the result of the "mvn test" command on the appropriate module:
(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)
### Changes that Break Backward Compatibility (Optional)
- My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include:
(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)
### Documentation (Optional)
- In case of new functionality, my PR adds documentation in the following wiki page:
(Link the GitHub wiki you added)
### Commits
- My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] qqu0127 commented on pull request #2035: MaintenanceManagementService improvement - Allow implementation of OperationInterface to return null
Posted by GitBox <gi...@apache.org>.
qqu0127 commented on PR #2035:
URL: https://github.com/apache/helix/pull/2035#issuecomment-1099614107
The impl looks good with minor comments, but here are some general questions on the design.
Could you share more context on why the service silently fail?
Also I'm wondering if a null value makes sense in the first place. Will something like a default or empty value be better?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] junkaixue merged pull request #2035: MaintenanceManagementService improvement - Allow implementation of OperationInterface to return null
Posted by GitBox <gi...@apache.org>.
junkaixue merged PR #2035:
URL: https://github.com/apache/helix/pull/2035
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] junkaixue commented on a diff in pull request #2035: MaintenanceManagementService improvement - Allow implementation of OperationInterface to return null
Posted by GitBox <gi...@apache.org>.
junkaixue commented on code in PR #2035:
URL: https://github.com/apache/helix/pull/2035#discussion_r849983346
##########
helix-rest/src/main/java/org/apache/helix/rest/clusterMaintenanceService/MaintenanceManagementInstanceInfo.java:
##########
@@ -84,11 +85,12 @@ public void mergeResult(MaintenanceManagementInstanceInfo info) {
}
public void mergeResult(MaintenanceManagementInstanceInfo info, boolean nonBlockingFailure) {
- messages.addAll(info.getMessages());
- status =
- (info.isSuccessful() || nonBlockingFailure) && isSuccessful() ? OperationalStatus.SUCCESS
- : OperationalStatus.FAILURE;
- if (info.hasOperationResult()) {
+ if (info != null) {
Review Comment:
All following logic relies on info != null. So why not just do:
if (info == null) {
return;
}
?
But before that, you need to move the status line before this. So status can be updated independently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] xyuanlu commented on pull request #2035: MaintenanceManagementService improvement - Allow implementation of OperationInterface to return null
Posted by GitBox <gi...@apache.org>.
xyuanlu commented on PR #2035:
URL: https://github.com/apache/helix/pull/2035#issuecomment-1099657871
> The impl looks good with minor comments, but here are some general questions on the design. Could you share more context on why the service silently fail? Also I'm wondering if a null value makes sense in the first place. Will something like a default or empty value be better?
Thanks for the reply.
If we get null for MaintenanceManagementInstanceInfo, then in MaintenanceManagementService.takeFreeSingleInstanceHelper() will throw npr exception causing operation failure.
This function execute user implemented interface `OperationInterface`. It should make sense to allow other user to return null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] xyuanlu commented on pull request #2035: MaintenanceManagementService improvement - Allow implementation of OperationInterface to return null
Posted by GitBox <gi...@apache.org>.
xyuanlu commented on PR #2035:
URL: https://github.com/apache/helix/pull/2035#issuecomment-1111540346
This PR is ready to be merged. Approved by @qqu0127 @desaikomal //Thanks!
Commit message:
Allow implementation of OperationInterface to return null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] qqu0127 commented on a diff in pull request #2035: MaintenanceManagementService improvement - Allow implementation of OperationInterface to return null
Posted by GitBox <gi...@apache.org>.
qqu0127 commented on code in PR #2035:
URL: https://github.com/apache/helix/pull/2035#discussion_r850792825
##########
helix-rest/src/main/java/org/apache/helix/rest/clusterMaintenanceService/MaintenanceManagementInstanceInfo.java:
##########
@@ -84,11 +85,12 @@ public void mergeResult(MaintenanceManagementInstanceInfo info) {
}
public void mergeResult(MaintenanceManagementInstanceInfo info, boolean nonBlockingFailure) {
- messages.addAll(info.getMessages());
- status =
- (info.isSuccessful() || nonBlockingFailure) && isSuccessful() ? OperationalStatus.SUCCESS
- : OperationalStatus.FAILURE;
- if (info.hasOperationResult()) {
+ if (info != null) {
+ messages.addAll(info.getMessages());
+ }
+ status = ((info == null || info.isSuccessful() || nonBlockingFailure) && isSuccessful())
Review Comment:
Is `status` a class attribute? Let's follow the naming convention like `_status`, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] xyuanlu commented on a diff in pull request #2035: MaintenanceManagementService improvement - Allow implementation of OperationInterface to return null
Posted by GitBox <gi...@apache.org>.
xyuanlu commented on code in PR #2035:
URL: https://github.com/apache/helix/pull/2035#discussion_r850828303
##########
helix-rest/src/main/java/org/apache/helix/rest/clusterMaintenanceService/MaintenanceManagementInstanceInfo.java:
##########
@@ -84,11 +85,12 @@ public void mergeResult(MaintenanceManagementInstanceInfo info) {
}
public void mergeResult(MaintenanceManagementInstanceInfo info, boolean nonBlockingFailure) {
- messages.addAll(info.getMessages());
- status =
- (info.isSuccessful() || nonBlockingFailure) && isSuccessful() ? OperationalStatus.SUCCESS
- : OperationalStatus.FAILURE;
- if (info.hasOperationResult()) {
+ if (info != null) {
Review Comment:
Good point. Updated.
I think if we get null `info`, we could keep status the same..?
##########
helix-rest/src/main/java/org/apache/helix/rest/clusterMaintenanceService/MaintenanceManagementInstanceInfo.java:
##########
@@ -84,11 +85,12 @@ public void mergeResult(MaintenanceManagementInstanceInfo info) {
}
public void mergeResult(MaintenanceManagementInstanceInfo info, boolean nonBlockingFailure) {
- messages.addAll(info.getMessages());
- status =
- (info.isSuccessful() || nonBlockingFailure) && isSuccessful() ? OperationalStatus.SUCCESS
- : OperationalStatus.FAILURE;
- if (info.hasOperationResult()) {
+ if (info != null) {
+ messages.addAll(info.getMessages());
+ }
+ status = ((info == null || info.isSuccessful() || nonBlockingFailure) && isSuccessful())
Review Comment:
TFTR. Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org