[GitHub] [maven] michael-o commented on a diff in pull request #863: [MNG-7590] Allow to configure resolver by properties in settings.xml

[GitBox <gi...@apache.org>]

michael-o commented on code in PR #863:
URL: https://github.com/apache/maven/pull/863#discussion_r1014831807


##########
maven-core/src/main/java/org/apache/maven/internal/aether/DefaultRepositorySystemSessionFactory.java:
##########
@@ -150,6 +152,8 @@ public DefaultRepositorySystemSession newRepositorySession( MavenExecutionReques
         configProps.put( ConfigurationProperties.USER_AGENT, getUserAgent() );
         configProps.put( ConfigurationProperties.INTERACTIVE, request.isInteractiveMode() );
         configProps.put( "maven.startTime", request.getStartTime() );
+        // First add properties populated from settings.xml
+        configProps.putAll( getConfigFromRequestProfiles( request ) );
         // Resolver's ConfigUtils solely rely on config properties, that is why we need to add both here as well.

Review Comment:
   I think this order also complies with preferred inheritance at point 7: https://cwiki.apache.org/confluence/display/MAVEN/Commandline+inheritance



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org