You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Qifan Chen (Code Review)" <ge...@cloudera.org> on 2022/02/23 22:44:47 UTC
[Impala-ASF-CR] IMPALA-10999 Flakiness in TestAsyncLoadData.test async load
Qifan Chen has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18268
Change subject: IMPALA-10999 Flakiness in TestAsyncLoadData.test_async_load
......................................................................
IMPALA-10999 Flakiness in TestAsyncLoadData.test_async_load
This patch addresses the flakness by allowing RUNNING state to be a
legit exec state returned from execute_query_async_using_client() in
python. This call submits the load query to Impala backend.
The corresponding Impala backend code for beewax protocol is
ImpalaServer::query() which utilizes a wait thread executing
ClientRequestState::Wait() to set the exec state from RUNNING to
FINISH. Sometime, when this wait thread does not run fast to do so,
the returned state can be RUNNING.
The fix is purely a modification to the test itself.
Testing:
1. ran core test successfully
Change-Id: Ic2ac954b0494b7413ce0ec405718fcc354dba9e0
---
M tests/metadata/test_load.py
1 file changed, 11 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/68/18268/1
--
To view, visit http://gerrit.cloudera.org:8080/18268
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic2ac954b0494b7413ce0ec405718fcc354dba9e0
Gerrit-Change-Number: 18268
Gerrit-PatchSet: 1
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
[Impala-ASF-CR] IMPALA-10999 Flakiness in TestAsyncLoadData.test async load
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18268 )
Change subject: IMPALA-10999 Flakiness in TestAsyncLoadData.test_async_load
......................................................................
Patch Set 2:
Build Successful
https://ec2-35-162-169-52.us-west-2.compute.amazonaws.com/job/gerrit-code-review-checks/10201/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18268
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2ac954b0494b7413ce0ec405718fcc354dba9e0
Gerrit-Change-Number: 18268
Gerrit-PatchSet: 2
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 24 Feb 2022 16:11:22 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10999 Flakiness in TestAsyncLoadData.test async load
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18268 )
Change subject: IMPALA-10999 Flakiness in TestAsyncLoadData.test_async_load
......................................................................
Patch Set 4: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7912/
--
To view, visit http://gerrit.cloudera.org:8080/18268
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2ac954b0494b7413ce0ec405718fcc354dba9e0
Gerrit-Change-Number: 18268
Gerrit-PatchSet: 4
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Mon, 07 Mar 2022 18:39:23 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10999 Flakiness in TestAsyncLoadData.test async load
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18268 )
Change subject: IMPALA-10999 Flakiness in TestAsyncLoadData.test_async_load
......................................................................
Patch Set 5:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7916/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/18268
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2ac954b0494b7413ce0ec405718fcc354dba9e0
Gerrit-Change-Number: 18268
Gerrit-PatchSet: 5
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Mon, 07 Mar 2022 23:58:00 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10999 Flakiness in TestAsyncLoadData.test async load
Posted by "Qifan Chen (Code Review)" <ge...@cloudera.org>.
Qifan Chen has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/18268 )
Change subject: IMPALA-10999 Flakiness in TestAsyncLoadData.test_async_load
......................................................................
IMPALA-10999 Flakiness in TestAsyncLoadData.test_async_load
This patch addresses the flakness by allowing RUNNING state to be a
legit exec state returned from execute_query_async_using_client() in
python. This call submits the load query to Impala backend.
The corresponding Impala backend code for the beewax protocol is
ImpalaServer::query() which utilizes a wait thread executing
ClientRequestState::Wait() to set the exec state from RUNNING to
FINISH. Sometime, when this wait thread does not run fast to do so,
the returned state from the main thread is RUNNING.
The fix is purely a modification to the test itself.
Testing:
1. ran core test successfully
Change-Id: Ic2ac954b0494b7413ce0ec405718fcc354dba9e0
---
M tests/metadata/test_load.py
1 file changed, 11 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/68/18268/2
--
To view, visit http://gerrit.cloudera.org:8080/18268
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic2ac954b0494b7413ce0ec405718fcc354dba9e0
Gerrit-Change-Number: 18268
Gerrit-PatchSet: 2
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] IMPALA-10999 Flakiness in TestAsyncLoadData.test async load
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18268 )
Change subject: IMPALA-10999 Flakiness in TestAsyncLoadData.test_async_load
......................................................................
IMPALA-10999 Flakiness in TestAsyncLoadData.test_async_load
This patch addresses the flakness by allowing RUNNING state to be a
legit exec state returned from execute_query_async_using_client() in
python. This call submits the load query to Impala backend.
The corresponding Impala backend code for the beewax protocol is
ImpalaServer::query() which utilizes a wait thread executing
ClientRequestState::Wait() to set the exec state from RUNNING to
FINISH. Sometime, when this wait thread does not run fast to do so,
the returned state from the main thread is RUNNING.
The fix is purely a modification to the test itself.
Testing:
1. ran core test successfully
Change-Id: Ic2ac954b0494b7413ce0ec405718fcc354dba9e0
Reviewed-on: http://gerrit.cloudera.org:8080/18268
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/metadata/test_load.py
1 file changed, 14 insertions(+), 9 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/18268
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic2ac954b0494b7413ce0ec405718fcc354dba9e0
Gerrit-Change-Number: 18268
Gerrit-PatchSet: 6
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] IMPALA-10999 Flakiness in TestAsyncLoadData.test async load
Posted by "Qifan Chen (Code Review)" <ge...@cloudera.org>.
Qifan Chen has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/18268 )
Change subject: IMPALA-10999 Flakiness in TestAsyncLoadData.test_async_load
......................................................................
IMPALA-10999 Flakiness in TestAsyncLoadData.test_async_load
This patch addresses the flakness by allowing RUNNING state to be a
legit exec state returned from execute_query_async_using_client() in
python. This call submits the load query to Impala backend.
The corresponding Impala backend code for the beewax protocol is
ImpalaServer::query() which utilizes a wait thread executing
ClientRequestState::Wait() to set the exec state from RUNNING to
FINISH. Sometime, when this wait thread does not run fast to do so,
the returned state from the main thread is RUNNING.
The fix is purely a modification to the test itself.
Testing:
1. ran core test successfully
Change-Id: Ic2ac954b0494b7413ce0ec405718fcc354dba9e0
---
M tests/metadata/test_load.py
1 file changed, 14 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/68/18268/3
--
To view, visit http://gerrit.cloudera.org:8080/18268
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic2ac954b0494b7413ce0ec405718fcc354dba9e0
Gerrit-Change-Number: 18268
Gerrit-PatchSet: 3
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] IMPALA-10999 Flakiness in TestAsyncLoadData.test async load
Posted by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org>.
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/18268 )
Change subject: IMPALA-10999 Flakiness in TestAsyncLoadData.test_async_load
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18268
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2ac954b0494b7413ce0ec405718fcc354dba9e0
Gerrit-Change-Number: 18268
Gerrit-PatchSet: 3
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 04 Mar 2022 22:25:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10999 Flakiness in TestAsyncLoadData.test async load
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18268 )
Change subject: IMPALA-10999 Flakiness in TestAsyncLoadData.test_async_load
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18268
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2ac954b0494b7413ce0ec405718fcc354dba9e0
Gerrit-Change-Number: 18268
Gerrit-PatchSet: 4
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Mon, 07 Mar 2022 13:43:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10999 Flakiness in TestAsyncLoadData.test async load
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18268 )
Change subject: IMPALA-10999 Flakiness in TestAsyncLoadData.test_async_load
......................................................................
Patch Set 5: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/18268
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2ac954b0494b7413ce0ec405718fcc354dba9e0
Gerrit-Change-Number: 18268
Gerrit-PatchSet: 5
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 08 Mar 2022 04:48:04 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10999 Flakiness in TestAsyncLoadData.test async load
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18268 )
Change subject: IMPALA-10999 Flakiness in TestAsyncLoadData.test_async_load
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/10261/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18268
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2ac954b0494b7413ce0ec405718fcc354dba9e0
Gerrit-Change-Number: 18268
Gerrit-PatchSet: 3
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 04 Mar 2022 22:00:47 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10999 Flakiness in TestAsyncLoadData.test async load
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18268 )
Change subject: IMPALA-10999 Flakiness in TestAsyncLoadData.test_async_load
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7912/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/18268
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2ac954b0494b7413ce0ec405718fcc354dba9e0
Gerrit-Change-Number: 18268
Gerrit-PatchSet: 4
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Mon, 07 Mar 2022 13:43:30 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10999 Flakiness in TestAsyncLoadData.test async load
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18268 )
Change subject: IMPALA-10999 Flakiness in TestAsyncLoadData.test_async_load
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/10217/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18268
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2ac954b0494b7413ce0ec405718fcc354dba9e0
Gerrit-Change-Number: 18268
Gerrit-PatchSet: 1
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 23 Feb 2022 23:12:06 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10999 Flakiness in TestAsyncLoadData.test async load
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18268 )
Change subject: IMPALA-10999 Flakiness in TestAsyncLoadData.test_async_load
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/10223/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18268
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2ac954b0494b7413ce0ec405718fcc354dba9e0
Gerrit-Change-Number: 18268
Gerrit-PatchSet: 2
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 24 Feb 2022 16:15:33 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10999 Flakiness in TestAsyncLoadData.test async load
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18268 )
Change subject: IMPALA-10999 Flakiness in TestAsyncLoadData.test_async_load
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18268
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2ac954b0494b7413ce0ec405718fcc354dba9e0
Gerrit-Change-Number: 18268
Gerrit-PatchSet: 5
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Mon, 07 Mar 2022 23:57:59 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10999 Flakiness in TestAsyncLoadData.test async load
Posted by "Qifan Chen (Code Review)" <ge...@cloudera.org>.
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/18268 )
Change subject: IMPALA-10999 Flakiness in TestAsyncLoadData.test_async_load
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18268/2/tests/metadata/test_load.py
File tests/metadata/test_load.py:
http://gerrit.cloudera.org:8080/#/c/18268/2/tests/metadata/test_load.py@181
PS2, Line 181: self.wait_for_state(handle, finished_state, 10, client=client)
> How do we know that the query eventually will reach finished state?
Yes, your understanding is correct. wait_for_state() guarantees that the query reaches the FINISH state (via finished_state) within 10s or timeout via an exception.
When async ddl is disabled, the execute_query_async_using_client() call compiles and starts the execution of the load command. This step also lunches a wait thread to check the execution completion status (exec state). This thread may run slow and if so, the returned completion status is still RUNNING (hence the assertion).
wait_for_state() also checks the same completion status which must be FINISHED.
--
To view, visit http://gerrit.cloudera.org:8080/18268
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2ac954b0494b7413ce0ec405718fcc354dba9e0
Gerrit-Change-Number: 18268
Gerrit-PatchSet: 2
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 24 Feb 2022 15:50:50 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10999 Flakiness in TestAsyncLoadData.test async load
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18268 )
Change subject: IMPALA-10999 Flakiness in TestAsyncLoadData.test_async_load
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18268/2/tests/metadata/test_load.py
File tests/metadata/test_load.py:
http://gerrit.cloudera.org:8080/#/c/18268/2/tests/metadata/test_load.py@181
PS2, Line 181: self.wait_for_state(handle, finished_state, 10, client=client)
> Yes, your understanding is correct. wait_for_state() guarantees that the qu
Thanks for the explanation!
--
To view, visit http://gerrit.cloudera.org:8080/18268
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2ac954b0494b7413ce0ec405718fcc354dba9e0
Gerrit-Change-Number: 18268
Gerrit-PatchSet: 2
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 24 Feb 2022 17:05:28 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10999 Flakiness in TestAsyncLoadData.test async load
Posted by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org>.
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/18268 )
Change subject: IMPALA-10999 Flakiness in TestAsyncLoadData.test_async_load
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/18268/2/tests/metadata/test_load.py
File tests/metadata/test_load.py:
http://gerrit.cloudera.org:8080/#/c/18268/2/tests/metadata/test_load.py@131
PS2, Line 131: test_async_load
nit: can you add a comment on what this test is verifying? Is the intent to just do a sanity check or to also verify that 2 different behaviors are expected from sync and async mode?
http://gerrit.cloudera.org:8080/#/c/18268/2/tests/metadata/test_load.py@199
PS2, Line 199: exec_end_state == running_state or exec_end_state == finished_state
was the original intent of this test to ensure different behaviour? that is, sync => finished state, async => running state ?
Since sync can now return either, do we need to check any other metric or behavior to verify the difference between the two?
--
To view, visit http://gerrit.cloudera.org:8080/18268
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2ac954b0494b7413ce0ec405718fcc354dba9e0
Gerrit-Change-Number: 18268
Gerrit-PatchSet: 2
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 03 Mar 2022 19:35:36 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10999 Flakiness in TestAsyncLoadData.test async load
Posted by "Qifan Chen (Code Review)" <ge...@cloudera.org>.
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/18268 )
Change subject: IMPALA-10999 Flakiness in TestAsyncLoadData.test_async_load
......................................................................
Patch Set 2:
(2 comments)
Thanks for the comments!
http://gerrit.cloudera.org:8080/#/c/18268/2/tests/metadata/test_load.py
File tests/metadata/test_load.py:
http://gerrit.cloudera.org:8080/#/c/18268/2/tests/metadata/test_load.py@131
PS2, Line 131: test_async_load
> nit: can you add a comment on what this test is verifying? Is the intent to
Done
http://gerrit.cloudera.org:8080/#/c/18268/2/tests/metadata/test_load.py@199
PS2, Line 199: exec_end_state == running_state or exec_end_state == finished_state
> was the original intent of this test to ensure different behaviour? that is
The objective is to make sure load works properly in both the sync and async mode.
The observability aspect tested here helps confirm the expected state (after the load query is submitted) in either mode. In particular, in the sync mode, the exec state can be either running or finished. The exec state is the primitive piece of info available to a client.
--
To view, visit http://gerrit.cloudera.org:8080/18268
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2ac954b0494b7413ce0ec405718fcc354dba9e0
Gerrit-Change-Number: 18268
Gerrit-PatchSet: 2
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 04 Mar 2022 21:40:02 +0000
Gerrit-HasComments: Yes