You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/04/24 19:46:21 UTC

[GitHub] [beam] KevinGG commented on a change in pull request #11507: [BEAM-7923] Support docker screendiff integration tests

KevinGG commented on a change in pull request #11507:
URL: https://github.com/apache/beam/pull/11507#discussion_r414821611



##########
File path: sdks/python/setup.py
##########
@@ -229,6 +229,8 @@ def get_version():
     'selenium>=3.141.0,<4',
     'needle>=0.5.0,<1',
     'chromedriver-binary>=80,<81',
+    # use a fixed version of PIL for different python versions
+    'pillow==7.1.1',

Review comment:
       Python comes with PIL, but different versions of Python has different PIL versions.
   To rule out the difference when taking screenshot, we use a fixed version of PIL explicitly for testing.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org