You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2021/02/15 12:24:25 UTC

[GitHub] [fineract] francisguchie opened a new pull request #1620: FINERACT-1306 fix Reporting meta-data entry not found"

francisguchie opened a new pull request #1620:
URL: https://github.com/apache/fineract/pull/1620


   ## Description
   
   Issue here [FINERACT-1306](https://issues.apache.org/jira/browse/FINERACT-1306)
   
   ## Checklist
   
   Please make sure these boxes are checked before submitting your pull request - thanks!
   
   - [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests
   
   - [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
   
   - [ ] Create/update unit or integration tests for verifying the changes made.
   
   - [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
   
   - [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm with details of any API changes
   
   - [ ] Submission is not a "code dump".  (Large changes can be made "in repository" via a branch.  Ask on the developer mailing list for guidance, if required.)
   
   FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] francisguchie commented on pull request #1620: FINERACT-1306 fix Reporting meta-data entry not found"

Posted by GitBox <gi...@apache.org>.

francisguchie commented on pull request #1620:
URL: https://github.com/apache/fineract/pull/1620#issuecomment-779231555


   @vorburger 
   
   after commit no  ,  we get two errors
   
   1. reportCategoryList.not.found 
   for API :  /fineract-provider/api/v1/runreports/reportCategoryList?R_reportCategory=Fund&genericResultSet=false&parameterType=true[&tenantIdentifier=default|https://localhost:8443/fineract-provider/api/v1/runreports/FullReportsList?genericResultSet=false&parameterType=true&tenantIdentifier=default]
   
   and 
   2. fullReportList.not.found 
   for: API /fineract-provider/api/v1/runreports/FullReportsList?genericResultSet=false&parameterType=true&tenantIdentifier=default).
   
   When we add these two reports (me &  @rrpawar96 ) with names  "ReportCategoryList" and "FullReportList" 
   these 2 errors do not show up. 
   
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] vorburger commented on pull request #1620: FINERACT-1306 fix Reporting meta-data entry not found"

Posted by GitBox <gi...@apache.org>.

vorburger commented on pull request #1620:
URL: https://github.com/apache/fineract/pull/1620#issuecomment-798499484


   I see. #1663 is basically this PR, but "cleaned up", and with a test. @francisguchie would you be willing to close this in favor of that?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] francisguchie closed pull request #1620: FINERACT-1306 fix Reporting meta-data entry not found"

Posted by GitBox <gi...@apache.org>.

francisguchie closed pull request #1620:
URL: https://github.com/apache/fineract/pull/1620


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] ptuomola commented on pull request #1620: FINERACT-1306 fix Reporting meta-data entry not found"

Posted by GitBox <gi...@apache.org>.

ptuomola commented on pull request #1620:
URL: https://github.com/apache/fineract/pull/1620#issuecomment-793353315


   @vorburger I haven't looked at this in detail, but what I think may be happening: the two reports (reportCategoryList and FullReportList) are present in the table stretchy_parameter but NOT in stretchy_report. 
   
   It may be that before your refactoring, this was ok - i.e. the code did not check stretchy_report and was happy if the entry was present in stretchy_parameter. It may be that we are now a bit stricter and require an entry in both? Hence this would "fix" the issue by ensuring these two reports are present in both tables. 
   
   I'm not sure why this PR contains a change to the Spring Framework dependency though. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] vorburger commented on pull request #1620: FINERACT-1306 fix Reporting meta-data entry not found"

Posted by GitBox <gi...@apache.org>.

vorburger commented on pull request #1620:
URL: https://github.com/apache/fineract/pull/1620#issuecomment-779190467


   I don't understand yet how this will fix FINERACT-1306... isn't this an "empty" report? Why is this required?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] francisguchie commented on pull request #1620: FINERACT-1306 fix Reporting meta-data entry not found"

Posted by GitBox <gi...@apache.org>.

francisguchie commented on pull request #1620:
URL: https://github.com/apache/fineract/pull/1620#issuecomment-798576033


   > I see. #1663 is basically this PR, but "cleaned up", and with a test. @francisguchie would you be willing to close this in favor of that?
   
   Thanks @vorburger  for #1663  I am closing this 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org