[GitHub] [incubator-superset] rusackas commented on a change in pull request #9373: Migrating mapbox controls

[GitBox <gi...@apache.org>]

rusackas commented on a change in pull request #9373: Migrating mapbox controls
URL: https://github.com/apache/incubator-superset/pull/9373#discussion_r397495315
 
 

 ##########
 File path: superset-frontend/src/explore/controls.jsx
 ##########
 @@ -191,7 +191,7 @@ const jsFunctionInfo = (
   </div>
 );
 
-function columnChoices(datasource) {
+export function columnChoices(datasource) {
 
 Review comment:
   @kristw just pointing out this export/import... we may want to move this to `utils` or somewhere else that makes more sense.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org