[GitHub] [pulsar] heesung-sn commented on pull request #20677: [fix][broker] Added the skipped message handler for ServiceUnitStateChannel

["heesung-sn (via GitHub)" <gi...@apache.org>]

heesung-sn commented on PR #20677:
URL: https://github.com/apache/pulsar/pull/20677#issuecomment-1613400771

   > This change LGTM, but I think this is a temporary solution. We should refactor it in the future.
   
   The cleaner approach would be to expose `listenSkipedMessage(..) on TableView` or register the TopicCompactionStrategy instance to the TableView. However, since this msg skip concept has not been exposed now, I implemented this in this way. We can refactor this part when the community wants to expose TopicCompactionStrategy to users.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org