You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Keith Wall (JIRA)" <ji...@apache.org> on 2012/09/04 23:22:07 UTC
[jira] [Created] (QPID-4284) Remove system test dependencies on
development and localhost virtual hosts
Keith Wall created QPID-4284:
--------------------------------
Summary: Remove system test dependencies on development and localhost virtual hosts
Key: QPID-4284
URL: https://issues.apache.org/jira/browse/QPID-4284
Project: Qpid
Issue Type: Improvement
Components: Java Broker
Reporter: Keith Wall
Assignee: Keith Wall
Fix For: 0.19
Currently the system tests rely on three virtualhost (namely test, development and localhost) being defined in the system test configuration. This arrangement has the disadvantage that each system test must initialise three virtual hosts and for persistent stores (derby/BDB), this adds significant time to the test run. On the whole, tests use only the 'test' virtualhost.
This change will remove the dependency on the development and localhost virtual hosts. It will also remove the remaining few dependencies on the hardcoded queues "ping" and "queue".
In addition to the time saving, this change will help when we come to eliminate the configuration files entirely.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Updated] (QPID-4284) Remove system test dependencies on
development and localhost virtual hosts
Posted by "Keith Wall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Keith Wall updated QPID-4284:
-----------------------------
Priority: Minor (was: Major)
> Remove system test dependencies on development and localhost virtual hosts
> --------------------------------------------------------------------------
>
> Key: QPID-4284
> URL: https://issues.apache.org/jira/browse/QPID-4284
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
> Reporter: Keith Wall
> Assignee: Robbie Gemmell
> Priority: Minor
> Fix For: 0.19
>
>
> Currently the system tests rely on three virtualhost (namely test, development and localhost) being defined in the system test configuration. This arrangement has the disadvantage that each system test must initialise three virtual hosts and for persistent stores (derby/BDB), this adds significant time to the test run. On the whole, tests use only the 'test' virtualhost.
> This change will remove the dependency on the development and localhost virtual hosts. It will also remove the remaining few dependencies on the hardcoded queues "ping" and "queue".
> In addition to the time saving, this change will help when we come to eliminate the configuration files entirely.
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Assigned] (QPID-4284) Remove system test dependencies on
development and localhost virtual hosts
Posted by "Keith Wall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Keith Wall reassigned QPID-4284:
--------------------------------
Assignee: Robbie Gemmell (was: Keith Wall)
> Remove system test dependencies on development and localhost virtual hosts
> --------------------------------------------------------------------------
>
> Key: QPID-4284
> URL: https://issues.apache.org/jira/browse/QPID-4284
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
> Reporter: Keith Wall
> Assignee: Robbie Gemmell
> Fix For: 0.19
>
> Attachments: 0001-QPID-4284-Remove-system-test-dependencies-on-develop.patch, TEST-org.apache.qpid.test.unit.ack.ClientAcknowledgeTest.testClientAckWithLargeFlusherPeriod-derby-0-9-1.out
>
>
> Currently the system tests rely on three virtualhost (namely test, development and localhost) being defined in the system test configuration. This arrangement has the disadvantage that each system test must initialise three virtual hosts and for persistent stores (derby/BDB), this adds significant time to the test run. On the whole, tests use only the 'test' virtualhost.
> This change will remove the dependency on the development and localhost virtual hosts. It will also remove the remaining few dependencies on the hardcoded queues "ping" and "queue".
> In addition to the time saving, this change will help when we come to eliminate the configuration files entirely.
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Resolved] (QPID-4284) Remove system test dependencies on
development and localhost virtual hosts
Posted by "Robbie Gemmell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robbie Gemmell resolved QPID-4284.
----------------------------------
Resolution: Fixed
Looks good to me.
> Remove system test dependencies on development and localhost virtual hosts
> --------------------------------------------------------------------------
>
> Key: QPID-4284
> URL: https://issues.apache.org/jira/browse/QPID-4284
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
> Reporter: Keith Wall
> Assignee: Robbie Gemmell
> Priority: Minor
> Fix For: 0.19
>
>
> Currently the system tests rely on three virtualhost (namely test, development and localhost) being defined in the system test configuration. This arrangement has the disadvantage that each system test must initialise three virtual hosts and for persistent stores (derby/BDB), this adds significant time to the test run. On the whole, tests use only the 'test' virtualhost.
> This change will remove the dependency on the development and localhost virtual hosts. It will also remove the remaining few dependencies on the hardcoded queues "ping" and "queue".
> In addition to the time saving, this change will help when we come to eliminate the configuration files entirely.
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Updated] (QPID-4284) Remove system test dependencies on
development and localhost virtual hosts
Posted by "Keith Wall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Keith Wall updated QPID-4284:
-----------------------------
Attachment: (was: 0001-QPID-4284-Remove-system-test-dependencies-on-develop.patch)
> Remove system test dependencies on development and localhost virtual hosts
> --------------------------------------------------------------------------
>
> Key: QPID-4284
> URL: https://issues.apache.org/jira/browse/QPID-4284
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
> Reporter: Keith Wall
> Assignee: Robbie Gemmell
> Fix For: 0.19
>
>
> Currently the system tests rely on three virtualhost (namely test, development and localhost) being defined in the system test configuration. This arrangement has the disadvantage that each system test must initialise three virtual hosts and for persistent stores (derby/BDB), this adds significant time to the test run. On the whole, tests use only the 'test' virtualhost.
> This change will remove the dependency on the development and localhost virtual hosts. It will also remove the remaining few dependencies on the hardcoded queues "ping" and "queue".
> In addition to the time saving, this change will help when we come to eliminate the configuration files entirely.
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Updated] (QPID-4284) Remove system test dependencies on
development and localhost virtual hosts
Posted by "Keith Wall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Keith Wall updated QPID-4284:
-----------------------------
Status: Ready To Review (was: In Progress)
> Remove system test dependencies on development and localhost virtual hosts
> --------------------------------------------------------------------------
>
> Key: QPID-4284
> URL: https://issues.apache.org/jira/browse/QPID-4284
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
> Reporter: Keith Wall
> Assignee: Keith Wall
> Fix For: 0.19
>
> Attachments: 0001-QPID-4284-Remove-system-test-dependencies-on-develop.patch, TEST-org.apache.qpid.test.unit.ack.ClientAcknowledgeTest.testClientAckWithLargeFlusherPeriod-derby-0-9-1.out
>
>
> Currently the system tests rely on three virtualhost (namely test, development and localhost) being defined in the system test configuration. This arrangement has the disadvantage that each system test must initialise three virtual hosts and for persistent stores (derby/BDB), this adds significant time to the test run. On the whole, tests use only the 'test' virtualhost.
> This change will remove the dependency on the development and localhost virtual hosts. It will also remove the remaining few dependencies on the hardcoded queues "ping" and "queue".
> In addition to the time saving, this change will help when we come to eliminate the configuration files entirely.
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Updated] (QPID-4284) Remove system test dependencies on
development and localhost virtual hosts
Posted by "Keith Wall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Keith Wall updated QPID-4284:
-----------------------------
Attachment: (was: TEST-org.apache.qpid.test.unit.ack.ClientAcknowledgeTest.testClientAckWithLargeFlusherPeriod-derby-0-9-1.out)
> Remove system test dependencies on development and localhost virtual hosts
> --------------------------------------------------------------------------
>
> Key: QPID-4284
> URL: https://issues.apache.org/jira/browse/QPID-4284
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
> Reporter: Keith Wall
> Assignee: Robbie Gemmell
> Fix For: 0.19
>
>
> Currently the system tests rely on three virtualhost (namely test, development and localhost) being defined in the system test configuration. This arrangement has the disadvantage that each system test must initialise three virtual hosts and for persistent stores (derby/BDB), this adds significant time to the test run. On the whole, tests use only the 'test' virtualhost.
> This change will remove the dependency on the development and localhost virtual hosts. It will also remove the remaining few dependencies on the hardcoded queues "ping" and "queue".
> In addition to the time saving, this change will help when we come to eliminate the configuration files entirely.
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Commented] (QPID-4284) Remove system test dependencies on
development and localhost virtual hosts
Posted by "Keith Wall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13457398#comment-13457398 ]
Keith Wall commented on QPID-4284:
----------------------------------
Patch applied. On my machine, the derby profile is 9 minutes faster (34=>25m) and the bdb store 2 minutes faster (21=>19min)
Robbie, could you please review this commit?
> Remove system test dependencies on development and localhost virtual hosts
> --------------------------------------------------------------------------
>
> Key: QPID-4284
> URL: https://issues.apache.org/jira/browse/QPID-4284
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
> Reporter: Keith Wall
> Assignee: Keith Wall
> Fix For: 0.19
>
> Attachments: 0001-QPID-4284-Remove-system-test-dependencies-on-develop.patch, TEST-org.apache.qpid.test.unit.ack.ClientAcknowledgeTest.testClientAckWithLargeFlusherPeriod-derby-0-9-1.out
>
>
> Currently the system tests rely on three virtualhost (namely test, development and localhost) being defined in the system test configuration. This arrangement has the disadvantage that each system test must initialise three virtual hosts and for persistent stores (derby/BDB), this adds significant time to the test run. On the whole, tests use only the 'test' virtualhost.
> This change will remove the dependency on the development and localhost virtual hosts. It will also remove the remaining few dependencies on the hardcoded queues "ping" and "queue".
> In addition to the time saving, this change will help when we come to eliminate the configuration files entirely.
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Updated] (QPID-4284) Remove system test dependencies on
development and localhost virtual hosts
Posted by "Keith Wall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Keith Wall updated QPID-4284:
-----------------------------
Attachment: TEST-org.apache.qpid.test.unit.ack.ClientAcknowledgeTest.testClientAckWithLargeFlusherPeriod-derby-0-9-1.out
> Remove system test dependencies on development and localhost virtual hosts
> --------------------------------------------------------------------------
>
> Key: QPID-4284
> URL: https://issues.apache.org/jira/browse/QPID-4284
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
> Reporter: Keith Wall
> Assignee: Keith Wall
> Fix For: 0.19
>
> Attachments: 0001-QPID-4284-Remove-system-test-dependencies-on-develop.patch, TEST-org.apache.qpid.test.unit.ack.ClientAcknowledgeTest.testClientAckWithLargeFlusherPeriod-derby-0-9-1.out
>
>
> Currently the system tests rely on three virtualhost (namely test, development and localhost) being defined in the system test configuration. This arrangement has the disadvantage that each system test must initialise three virtual hosts and for persistent stores (derby/BDB), this adds significant time to the test run. On the whole, tests use only the 'test' virtualhost.
> This change will remove the dependency on the development and localhost virtual hosts. It will also remove the remaining few dependencies on the hardcoded queues "ping" and "queue".
> In addition to the time saving, this change will help when we come to eliminate the configuration files entirely.
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Commented] (QPID-4284) Remove system test dependencies on
development and localhost virtual hosts
Posted by "Keith Wall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13451673#comment-13451673 ]
Keith Wall commented on QPID-4284:
----------------------------------
I believe the patch for this change is complete, but running the tests with this patch reveals what I think is an existing problem (Test ClientAcknowledgeTest on the java-dby.0-9-1 profile).
{code}
Testcase: testClientAckWithLargeFlusherPeriod took 4.401 sec
FAILED
Unexpected message is received expected:<2> but was:<1>
junit.framework.AssertionFailedError: Unexpected message is received expected:<2> but was:<1>
at org.apache.qpid.test.unit.ack.ClientAcknowledgeTest.testClientAckWithLargeFlusherPeriod(ClientAcknowledgeTest.java:80)
at org.apache.qpid.test.utils.QpidBrokerTestCase.runBare(QpidBrokerTestCase.java:242)
at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:137)
{code}
It appears to me that the Broker is failing to process the message ack, and for this reason, the wrong message (message 1) is redelivered at restart.
{code}
{code}
> Remove system test dependencies on development and localhost virtual hosts
> --------------------------------------------------------------------------
>
> Key: QPID-4284
> URL: https://issues.apache.org/jira/browse/QPID-4284
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
> Reporter: Keith Wall
> Assignee: Keith Wall
> Fix For: 0.19
>
> Attachments: 0001-QPID-4284-Remove-system-test-dependencies-on-develop.patch, TEST-org.apache.qpid.test.unit.ack.ClientAcknowledgeTest.testClientAckWithLargeFlusherPeriod-derby-0-9-1.out
>
>
> Currently the system tests rely on three virtualhost (namely test, development and localhost) being defined in the system test configuration. This arrangement has the disadvantage that each system test must initialise three virtual hosts and for persistent stores (derby/BDB), this adds significant time to the test run. On the whole, tests use only the 'test' virtualhost.
> This change will remove the dependency on the development and localhost virtual hosts. It will also remove the remaining few dependencies on the hardcoded queues "ping" and "queue".
> In addition to the time saving, this change will help when we come to eliminate the configuration files entirely.
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Updated] (QPID-4284) Remove system test dependencies on
development and localhost virtual hosts
Posted by "Keith Wall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Keith Wall updated QPID-4284:
-----------------------------
Attachment: 0001-QPID-4284-Remove-system-test-dependencies-on-develop.patch
> Remove system test dependencies on development and localhost virtual hosts
> --------------------------------------------------------------------------
>
> Key: QPID-4284
> URL: https://issues.apache.org/jira/browse/QPID-4284
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
> Reporter: Keith Wall
> Assignee: Keith Wall
> Fix For: 0.19
>
> Attachments: 0001-QPID-4284-Remove-system-test-dependencies-on-develop.patch, TEST-org.apache.qpid.test.unit.ack.ClientAcknowledgeTest.testClientAckWithLargeFlusherPeriod-derby-0-9-1.out
>
>
> Currently the system tests rely on three virtualhost (namely test, development and localhost) being defined in the system test configuration. This arrangement has the disadvantage that each system test must initialise three virtual hosts and for persistent stores (derby/BDB), this adds significant time to the test run. On the whole, tests use only the 'test' virtualhost.
> This change will remove the dependency on the development and localhost virtual hosts. It will also remove the remaining few dependencies on the hardcoded queues "ping" and "queue".
> In addition to the time saving, this change will help when we come to eliminate the configuration files entirely.
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Updated] (QPID-4284) Remove system test dependencies on
development and localhost virtual hosts
Posted by "Keith Wall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Keith Wall updated QPID-4284:
-----------------------------
Attachment: (was: 0001-WIP-sync-after-client-ack-ack.patch)
> Remove system test dependencies on development and localhost virtual hosts
> --------------------------------------------------------------------------
>
> Key: QPID-4284
> URL: https://issues.apache.org/jira/browse/QPID-4284
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
> Reporter: Keith Wall
> Assignee: Keith Wall
> Fix For: 0.19
>
> Attachments: 0001-QPID-4284-Remove-system-test-dependencies-on-develop.patch, TEST-org.apache.qpid.test.unit.ack.ClientAcknowledgeTest.testClientAckWithLargeFlusherPeriod-derby-0-9-1.out
>
>
> Currently the system tests rely on three virtualhost (namely test, development and localhost) being defined in the system test configuration. This arrangement has the disadvantage that each system test must initialise three virtual hosts and for persistent stores (derby/BDB), this adds significant time to the test run. On the whole, tests use only the 'test' virtualhost.
> This change will remove the dependency on the development and localhost virtual hosts. It will also remove the remaining few dependencies on the hardcoded queues "ping" and "queue".
> In addition to the time saving, this change will help when we come to eliminate the configuration files entirely.
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Comment Edited] (QPID-4284) Remove system test dependencies
on development and localhost virtual hosts
Posted by "Keith Wall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13451673#comment-13451673 ]
Keith Wall edited comment on QPID-4284 at 9/10/12 7:45 AM:
-----------------------------------------------------------
I believe the patch for this change is complete, but running the tests with this patch reveals what I think is a preexisting problem (Test ClientAcknowledgeTest on the java-dby.0-9-1 profile).
{code}
Testcase: testClientAckWithLargeFlusherPeriod took 4.401 sec
FAILED
Unexpected message is received expected:<2> but was:<1>
junit.framework.AssertionFailedError: Unexpected message is received expected:<2> but was:<1>
at org.apache.qpid.test.unit.ack.ClientAcknowledgeTest.testClientAckWithLargeFlusherPeriod(ClientAcknowledgeTest.java:80)
at org.apache.qpid.test.utils.QpidBrokerTestCase.runBare(QpidBrokerTestCase.java:242)
at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:137)
{code}
The Broker attempt to dequeue message 1 (in response to the message ack) is failing as the test has already started to shutdown the Broker.
{code}
IoReceiver - /127.0.0.1:53680 2012-09-09 19:30:07,064 ERROR [qpid.server.txn.AsyncAutoCommitTransaction] Error during message dequeues
org.apache.qpid.AMQStoreException: Error deleting enqueued message with id 1 for queue ClientAcknowledgeTest-testClientAckWithLargeFlusherPeriod with id b4a8250a-b2e6-32b2-8770-02f76d806777 from database [error code 541: internal error]
(snip)
Caused by: java.sql.SQLException: Java exception: ': org.apache.derby.iapi.error.ShutdownException'.
at org.apache.derby.impl.jdbc.SQLExceptionFactory40.getSQLException(Unknown Source)
{code}
I think this problem was being masked by the other two virtual hosts. The extra time taken to close the two other virtual hosts allowed sufficient time for the transaction to commit. The problem does not occur with 0-10.
was (Author: k-wall):
I believe the patch for this change is complete, but running the tests with this patch reveals what I think is an existing problem (Test ClientAcknowledgeTest on the java-dby.0-9-1 profile).
{code}
Testcase: testClientAckWithLargeFlusherPeriod took 4.401 sec
FAILED
Unexpected message is received expected:<2> but was:<1>
junit.framework.AssertionFailedError: Unexpected message is received expected:<2> but was:<1>
at org.apache.qpid.test.unit.ack.ClientAcknowledgeTest.testClientAckWithLargeFlusherPeriod(ClientAcknowledgeTest.java:80)
at org.apache.qpid.test.utils.QpidBrokerTestCase.runBare(QpidBrokerTestCase.java:242)
at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:137)
{code}
It appears to me that the Broker is failing to process the message ack, and for this reason, the wrong message (message 1) is redelivered at restart.
{code}
{code}
> Remove system test dependencies on development and localhost virtual hosts
> --------------------------------------------------------------------------
>
> Key: QPID-4284
> URL: https://issues.apache.org/jira/browse/QPID-4284
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
> Reporter: Keith Wall
> Assignee: Keith Wall
> Fix For: 0.19
>
> Attachments: 0001-QPID-4284-Remove-system-test-dependencies-on-develop.patch, TEST-org.apache.qpid.test.unit.ack.ClientAcknowledgeTest.testClientAckWithLargeFlusherPeriod-derby-0-9-1.out
>
>
> Currently the system tests rely on three virtualhost (namely test, development and localhost) being defined in the system test configuration. This arrangement has the disadvantage that each system test must initialise three virtual hosts and for persistent stores (derby/BDB), this adds significant time to the test run. On the whole, tests use only the 'test' virtualhost.
> This change will remove the dependency on the development and localhost virtual hosts. It will also remove the remaining few dependencies on the hardcoded queues "ping" and "queue".
> In addition to the time saving, this change will help when we come to eliminate the configuration files entirely.
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Comment Edited] (QPID-4284) Remove system test dependencies
on development and localhost virtual hosts
Posted by "Keith Wall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13453439#comment-13453439 ]
Keith Wall edited comment on QPID-4284 at 9/18/12 8:58 AM:
-----------------------------------------------------------
Proposed patch to resolve the issue described above -- problem described was fixed by QPID-4302
was (Author: k-wall):
Proposed patch to resolve the issue described above.
> Remove system test dependencies on development and localhost virtual hosts
> --------------------------------------------------------------------------
>
> Key: QPID-4284
> URL: https://issues.apache.org/jira/browse/QPID-4284
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
> Reporter: Keith Wall
> Assignee: Keith Wall
> Fix For: 0.19
>
> Attachments: 0001-QPID-4284-Remove-system-test-dependencies-on-develop.patch, TEST-org.apache.qpid.test.unit.ack.ClientAcknowledgeTest.testClientAckWithLargeFlusherPeriod-derby-0-9-1.out
>
>
> Currently the system tests rely on three virtualhost (namely test, development and localhost) being defined in the system test configuration. This arrangement has the disadvantage that each system test must initialise three virtual hosts and for persistent stores (derby/BDB), this adds significant time to the test run. On the whole, tests use only the 'test' virtualhost.
> This change will remove the dependency on the development and localhost virtual hosts. It will also remove the remaining few dependencies on the hardcoded queues "ping" and "queue".
> In addition to the time saving, this change will help when we come to eliminate the configuration files entirely.
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Updated] (QPID-4284) Remove system test dependencies on
development and localhost virtual hosts
Posted by "Keith Wall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Keith Wall updated QPID-4284:
-----------------------------
Attachment: 0001-WIP-sync-after-client-ack-ack.patch
Proposed patch to resolve the issue described above.
> Remove system test dependencies on development and localhost virtual hosts
> --------------------------------------------------------------------------
>
> Key: QPID-4284
> URL: https://issues.apache.org/jira/browse/QPID-4284
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
> Reporter: Keith Wall
> Assignee: Keith Wall
> Fix For: 0.19
>
> Attachments: 0001-QPID-4284-Remove-system-test-dependencies-on-develop.patch, 0001-WIP-sync-after-client-ack-ack.patch, TEST-org.apache.qpid.test.unit.ack.ClientAcknowledgeTest.testClientAckWithLargeFlusherPeriod-derby-0-9-1.out
>
>
> Currently the system tests rely on three virtualhost (namely test, development and localhost) being defined in the system test configuration. This arrangement has the disadvantage that each system test must initialise three virtual hosts and for persistent stores (derby/BDB), this adds significant time to the test run. On the whole, tests use only the 'test' virtualhost.
> This change will remove the dependency on the development and localhost virtual hosts. It will also remove the remaining few dependencies on the hardcoded queues "ping" and "queue".
> In addition to the time saving, this change will help when we come to eliminate the configuration files entirely.
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org