quick fixes

[Johnny Mnemonic <jo...@themnemonic.org>]

Hello

i was checking out the cvs but i had some problems to compile it
when i run the builddtcl.sh script (after editing it) i get errors for the 
VERSION file (missing) but required for the -DDTCL_VERSION=\"`cat VERSION`\"
Am i wrong or the file should be there? I did an echo 0.9.0 > VERSION for 
temp, but the real version should be decided by our dear developer :)
I also have to quick fixes for the src:

--- apache_multipart_buffer.c~  Mon Feb 19 19:37:57 2001
+++ apache_multipart_buffer.c   Mon Feb 19 19:38:55 2001
@@ -182,7 +182,6 @@
  /* finds a boundary */
  int find_boundary(multipart_buffer *self, char *boundary)
  {
-    int len, bound_len = strlen(boundary);
      char *line;

      /* loop thru lines */
--- mod_dtcl.c~ Mon Feb 19 19:37:00 2001
+++ mod_dtcl.c  Mon Feb 19 19:38:55 2001
@@ -872,7 +872,7 @@
  #if THREADED_TCL == 0
      tcl_init_stuff(s, p);
  #endif
-    ap_add_version_component("mod_dtcl");
+    ap_add_version_component("mod_dtcl/" DTCL_VERSION);
  }

  const char *set_script(cmd_parms *cmd, void *dummy, char *arg, char *arg2)

---
(why not to show the mod_tcl version in the apache?)


____________________________________
Johnny Mnemonic©

E-Mail Address:
- johnny@themnemonic.org

Re: quick fixes

["David N. Welton" <da...@apache.org>]

Johnny Mnemonic <jo...@themnemonic.org> writes:

> i was checking out the cvs but i had some problems to compile it
> when i run the builddtcl.sh script (after editing it) i get errors
> for the VERSION file (missing) but required for the
> -DDTCL_VERSION=\"`cat VERSION`\" Am i wrong or the file should be
> there? I did an echo 0.9.0 > VERSION for temp, but the real version
> should be decided by our dear developer :)

Hmm, yeah.  I should probably check out the raw sources more often, so
I don't get confused by the cruft in my own directory:-)

> I also have to quick fixes for the src:

> --- apache_multipart_buffer.c~  Mon Feb 19 19:37:57 2001
> +++ apache_multipart_buffer.c   Mon Feb 19 19:38:55 2001
> @@ -182,7 +182,6 @@
>   /* finds a boundary */
>   int find_boundary(multipart_buffer *self, char *boundary)
>   {
> -    int len, bound_len = strlen(boundary);
>       char *line;
> 
>       /* loop thru lines */

I'll see what they do with this upstream, although it looks ok.  Those
files are taken from the Apache apreq efforts.

> --- mod_dtcl.c~ Mon Feb 19 19:37:00 2001
> +++ mod_dtcl.c  Mon Feb 19 19:38:55 2001
> @@ -872,7 +872,7 @@
>   #if THREADED_TCL == 0
>       tcl_init_stuff(s, p);
>   #endif
> -    ap_add_version_component("mod_dtcl");
> +    ap_add_version_component("mod_dtcl/" DTCL_VERSION);
>   }
> 
>   const char *set_script(cmd_parms *cmd, void *dummy, char *arg, char *arg2)
> 
> ---
> (why not to show the mod_tcl version in the apache?)

I used to do this, but decided that maybe it's best not too.  If there
were ever a big security problem, why show people which sites are
vulnerable?

Thanks!
-- 
David N. Welton
     Personal:           http://www.efn.org/~davidw/  
Free Software:           http://people.debian.org/~davidw/
   Apache Tcl:           http://tcl.apache.org