[GitHub] [hbase] joshelser commented on pull request #1935: HBASE-22146 SpaceQuotaViolationPolicy Disable is not working in Names…

[GitBox <gi...@apache.org>]

joshelser commented on pull request #1935:
URL: https://github.com/apache/hbase/pull/1935#issuecomment-656832955


   > My change removes these QUOTA_FAMILY_USAGE column family for the tables when a namespace quota is deleted and allows the user to insert into the tables in the namespace when the violated space quota is removed.
   
   > But I thought you should fix the problem not in QuotaUtil class, maybe in MasterQuotaManager? Keep QuotaUtil simple and fix this in upper layer.
   
   Thanks for the explanation in https://github.com/apache/hbase/pull/1935#pullrequestreview-439900394, Surbhi. This helps tremendously.
   
   I'm not sure that removing the `u:p` cell is the correct solution. These columns are just tracking the _size_ of the table. In themselves, they aren't controlling anything (if memory serves). Instead, we should know that when we delete the NamespaceQuota, MasterQuotaManager needs to become aware of this (somehow) and remove any SpaceQuotaViolationPolicies that are in effect.
   
   I suspect your fix does work, but for the wrong reason. If you remove the sizes for these tables, the Master will simply think that the table is no longer in validation. If you have a table-level quota also defined (like I commented in-code), I think this change will incorrectly cause that table-level to not be applied.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org