You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Martin Grigorov (JIRA)" <ji...@apache.org> on 2010/10/26 15:46:20 UTC
[jira] Created: (WICKET-3131) Retest all combinations of redirect
policies and render strategies
Retest all combinations of redirect policies and render strategies
------------------------------------------------------------------
Key: WICKET-3131
URL: https://issues.apache.org/jira/browse/WICKET-3131
Project: Wicket
Issue Type: Sub-task
Components: wicket
Affects Versions: 1.5-M2.1
Reporter: Martin Grigorov
While debugging problem "ajax links example - failure handler is not invoked, instead error is reported" in WICKET-3114 I found that using redirect policy "NEVER_REDIRECT" doesn't quite work because the response body is already written when Wicket tries to write the headers (org.apache.wicket.request.handler.render.WebPageRenderer.respond(RequestCycle), around line 203).
So failures in processing Ajax request cannot successfully return http status "500" to wicket-ajax.js.
I think we need to retest all possible combinations of redirect policies and render strategies and add unit tests for them if possible.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-3131) Retest all combinations of redirect
policies and render strategies
Posted by "Jeremy Thomerson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jeremy Thomerson updated WICKET-3131:
-------------------------------------
Fix Version/s: (was: 1.5-M4)
Removing fix versions on things that were marked as fixVersion = (1.4.14 || 1.5-M4), but also weren't fixed (marked "not a problem", "won't fix", etc) so that they don't show up in release notes when in reality they weren't part of the release.
> Retest all combinations of redirect policies and render strategies
> ------------------------------------------------------------------
>
> Key: WICKET-3131
> URL: https://issues.apache.org/jira/browse/WICKET-3131
> Project: Wicket
> Issue Type: Sub-task
> Components: wicket
> Affects Versions: 1.5-M2.1
> Reporter: Martin Grigorov
> Assignee: Martin Grigorov
> Attachments: WICKET-3131.patch
>
>
> While debugging problem "ajax links example - failure handler is not invoked, instead error is reported" in WICKET-3114 I found that using redirect policy "NEVER_REDIRECT" doesn't quite work because the response body is already written when Wicket tries to write the headers (org.apache.wicket.request.handler.render.WebPageRenderer.respond(RequestCycle), around line 203).
> So failures in processing Ajax request cannot successfully return http status "500" to wicket-ajax.js.
> I think we need to retest all possible combinations of redirect policies and render strategies and add unit tests for them if possible.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WICKET-3131) Retest all combinations of redirect
policies and render strategies
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov reassigned WICKET-3131:
---------------------------------------
Assignee: Martin Grigorov
> Retest all combinations of redirect policies and render strategies
> ------------------------------------------------------------------
>
> Key: WICKET-3131
> URL: https://issues.apache.org/jira/browse/WICKET-3131
> Project: Wicket
> Issue Type: Sub-task
> Components: wicket
> Affects Versions: 1.5-M2.1
> Reporter: Martin Grigorov
> Assignee: Martin Grigorov
> Attachments: WICKET-3131.patch
>
>
> While debugging problem "ajax links example - failure handler is not invoked, instead error is reported" in WICKET-3114 I found that using redirect policy "NEVER_REDIRECT" doesn't quite work because the response body is already written when Wicket tries to write the headers (org.apache.wicket.request.handler.render.WebPageRenderer.respond(RequestCycle), around line 203).
> So failures in processing Ajax request cannot successfully return http status "500" to wicket-ajax.js.
> I think we need to retest all possible combinations of redirect policies and render strategies and add unit tests for them if possible.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-3131) Retest all combinations of redirect
policies and render strategies
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov resolved WICKET-3131.
-------------------------------------
Resolution: Not A Problem
Fix Version/s: 1.5-M4
I just retested my biggest application with all render strategies and there are no issues so far.
The attached patch could be ignored because it was fixed with WICKET-3143 (No Exception page are rendered when using ajax)
> Retest all combinations of redirect policies and render strategies
> ------------------------------------------------------------------
>
> Key: WICKET-3131
> URL: https://issues.apache.org/jira/browse/WICKET-3131
> Project: Wicket
> Issue Type: Sub-task
> Components: wicket
> Affects Versions: 1.5-M2.1
> Reporter: Martin Grigorov
> Assignee: Martin Grigorov
> Fix For: 1.5-M4
>
> Attachments: WICKET-3131.patch
>
>
> While debugging problem "ajax links example - failure handler is not invoked, instead error is reported" in WICKET-3114 I found that using redirect policy "NEVER_REDIRECT" doesn't quite work because the response body is already written when Wicket tries to write the headers (org.apache.wicket.request.handler.render.WebPageRenderer.respond(RequestCycle), around line 203).
> So failures in processing Ajax request cannot successfully return http status "500" to wicket-ajax.js.
> I think we need to retest all possible combinations of redirect policies and render strategies and add unit tests for them if possible.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-3131) Retest all combinations of redirect
policies and render strategies
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov updated WICKET-3131:
------------------------------------
Attachment: WICKET-3131.patch
A patch that solves the described problem with status "500".
> Retest all combinations of redirect policies and render strategies
> ------------------------------------------------------------------
>
> Key: WICKET-3131
> URL: https://issues.apache.org/jira/browse/WICKET-3131
> Project: Wicket
> Issue Type: Sub-task
> Components: wicket
> Affects Versions: 1.5-M2.1
> Reporter: Martin Grigorov
> Attachments: WICKET-3131.patch
>
>
> While debugging problem "ajax links example - failure handler is not invoked, instead error is reported" in WICKET-3114 I found that using redirect policy "NEVER_REDIRECT" doesn't quite work because the response body is already written when Wicket tries to write the headers (org.apache.wicket.request.handler.render.WebPageRenderer.respond(RequestCycle), around line 203).
> So failures in processing Ajax request cannot successfully return http status "500" to wicket-ajax.js.
> I think we need to retest all possible combinations of redirect policies and render strategies and add unit tests for them if possible.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.