You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "ANIKKAZI (via GitHub)" <gi...@apache.org> on 2023/04/05 04:07:02 UTC
[GitHub] [commons-fileupload] ANIKKAZI opened a new pull request, #212: Code refactoring
ANIKKAZI opened a new pull request, #212:
URL: https://github.com/apache/commons-fileupload/pull/212
Changes made
- Introduce explaining variable
- extract method
- Pull-up variable .
- rename variables
- move method
- Replace conditional with polymorphism
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-fileupload] jochenw commented on pull request #212: Code refactoring
Posted by "jochenw (via GitHub)" <gi...@apache.org>.
jochenw commented on PR #212:
URL: https://github.com/apache/commons-fileupload/pull/212#issuecomment-1497054707
Also, I am getting Checkstyle errors in the build (see action "Java CI"). Fix those, please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-fileupload] ANIKKAZI closed pull request #212: Code refactoring
Posted by "ANIKKAZI (via GitHub)" <gi...@apache.org>.
ANIKKAZI closed pull request #212: Code refactoring
URL: https://github.com/apache/commons-fileupload/pull/212
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-fileupload] jochenw commented on pull request #212: Code refactoring
Posted by "jochenw (via GitHub)" <gi...@apache.org>.
jochenw commented on PR #212:
URL: https://github.com/apache/commons-fileupload/pull/212#issuecomment-1497052024
From what I can tell, at first glance, this seems to be only code formatting, rather than refactoring.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org