You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Jeanne Waldman (JIRA)" <de...@myfaces.apache.org> on 2008/09/05 19:44:44 UTC

[jira] Created: (TRINIDAD-1216) skinning in a portal returns null for properties and icons

skinning in a portal returns null for properties and icons
----------------------------------------------------------

                 Key: TRINIDAD-1216
                 URL: https://issues.apache.org/jira/browse/TRINIDAD-1216
             Project: MyFaces Trinidad
          Issue Type: Bug
          Components: Skinning
    Affects Versions: 1.2.9-core, 1.0.9-core
            Reporter: Jeanne Waldman
            Assignee: Jeanne Waldman


When we have a portlet producer inside a portal producer, we try to use the skin the consumer is asking for in the producer if the skin's are identical, i.e., the style-sheet-id is the same. When we do that, however, the skin returns null for icons and properties since the patch that added RequestSkinWrapper.

The reason it is doing this is that in CoreRenderingContext's code that returns the matchingSkin, it doesn't wrap that matching skin with a RequestSkinWrapper, which is needed to get the icons and properties. Doing so fixes this problem.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (TRINIDAD-1216) skinning in a portal returns null for properties and icons

Posted by "Jeanne Waldman (JIRA)" <de...@myfaces.apache.org>.
     [ https://issues.apache.org/jira/browse/TRINIDAD-1216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jeanne Waldman resolved TRINIDAD-1216.
--------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.0.10-core
                   1.2.10-core

> skinning in a portal returns null for properties and icons
> ----------------------------------------------------------
>
>                 Key: TRINIDAD-1216
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-1216
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>          Components: Skinning
>    Affects Versions: 1.0.9-core, 1.2.9-core
>            Reporter: Jeanne Waldman
>            Assignee: Jeanne Waldman
>             Fix For: 1.2.10-core, 1.0.10-core
>
>         Attachments: Trinidad1216patch.patch
>
>
> When we have a portlet producer inside a portal producer, we try to use the skin the consumer is asking for in the producer if the skin's are identical, i.e., the style-sheet-id is the same. When we do that, however, the skin returns null for icons and properties since the patch that added RequestSkinWrapper.
> The reason it is doing this is that in CoreRenderingContext's code that returns the matchingSkin, it doesn't wrap that matching skin with a RequestSkinWrapper, which is needed to get the icons and properties. Doing so fixes this problem.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.