You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gluten.apache.org by "PHILO-HE (via GitHub)" <gi...@apache.org> on 2024/03/08 01:43:50 UTC

Re: [PR] [VL] Pass partition id to velox functions [incubator-gluten]

PHILO-HE commented on code in PR #4344:
URL: https://github.com/apache/incubator-gluten/pull/4344#discussion_r1517052078


##########
cpp/velox/jni/VeloxJniWrapper.cc:
##########
@@ -111,6 +111,8 @@ Java_io_glutenproject_vectorized_PlanEvaluatorJniWrapper_nativeValidateWithFailu
 
   // A query context used for function validation.
   velox::core::QueryCtx queryCtx;
+  std::unordered_map<std::string, std::string> configs{{velox::core::QueryConfig::kSparkPartitionId, "0"}};
+  queryCtx.testingOverrideConfigUnsafe(std::move(configs));

Review Comment:
   Seems `testingOverrideConfigUnsafe` should be used in test code only.



##########
cpp/velox/jni/VeloxJniWrapper.cc:
##########
@@ -111,6 +111,8 @@ Java_io_glutenproject_vectorized_PlanEvaluatorJniWrapper_nativeValidateWithFailu
 
   // A query context used for function validation.
   velox::core::QueryCtx queryCtx;
+  std::unordered_map<std::string, std::string> configs{{velox::core::QueryConfig::kSparkPartitionId, "0"}};

Review Comment:
   Do we need to pass this config for validator? Seems if lacked, it doesn't have any impact.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org