[GitHub] [airflow] khalidmammadov commented on pull request #20422: Fix MyPy errors in Apache Providers

[GitBox <gi...@apache.org>]

khalidmammadov commented on pull request #20422:
URL: https://github.com/apache/airflow/pull/20422#issuecomment-999108957


   Hi Jarek,
   
   Since typing is not required for runtime, I have amended it to just below.
   
   |if TYPE_CHECKING: from airflow.utils.context import Context|
   
   Is that OK?
   
   - Did the same in https://github.com/apache/airflow/pull/20409
   
   
   On 21/12/2021 13:13, Jarek Potiuk wrote:
   >
   > Need some review here - anyone has better idea what to do instead of:
   >
   > |if TYPE_CHECKING: from airflow.utils.context import Context else: 
   > Context = MutableMapping[str, Any] |
   >
   > I would like to automatically add it later to all the provider's 
   > executes/pokes to really benefit from the latest TypeDict Context 
   > improvements :D, but maybe we can find a better way ? The problem with 
   > it is we can't rely on the common code in airflow :(
   >
   > —
   > Reply to this email directly, view it on GitHub 
   > <https://github.com/apache/airflow/pull/20422#issuecomment-998768141>, 
   > or unsubscribe 
   > <https://github.com/notifications/unsubscribe-auth/ACYJ3NFYVTDOCSBORMHASA3USB4OLANCNFSM5KNYLA4A>.
   > Triage notifications on the go with GitHub Mobile for iOS 
   > <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> 
   > or Android 
   > <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. 
   >
   > You are receiving this because you were mentioned.Message ID: 
   > ***@***.***>
   >
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org