You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by jbertram <gi...@git.apache.org> on 2015/05/28 15:42:10 UTC

[GitHub] activemq-artemis pull request: More test-suite refactoring

GitHub user jbertram opened a pull request:

    https://github.com/apache/activemq-artemis/pull/4

    More test-suite refactoring

    Lots of work on the test-suite in this commit including:
    - Rename ServiceTestBase to ActiveMQTestBase
    - Make AddressSettings fluent
    - Remove unnecessary tearDown() implementations
    - Use ActiveMQTestBase.create*Locator() instead of
      ActiveMQClient.createServerLocator*(..)
    - Use fluent ServerLocator methods
    - Make sure all ActiveMQServers.newActiveMQServer invocations
      are surrounded with addServer() where appropriate
    - Create a few example tests to be references from hacking-guide
    - Update hacking-guide with more info on writing tests

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jbertram/activemq-artemis hacking_guide

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/4.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4
    
----
commit b399ee13450182b9522302388a0d0a9a72ebedfa
Author: jbertram <jb...@apache.org>
Date:   2015-05-20T17:39:38Z

    More test-suite refactoring
    
    Lots of work on the test-suite in this commit including:
    - Rename ServiceTestBase to ActiveMQTestBase
    - Make AddressSettings fluent
    - Remove unnecessary tearDown() implementations
    - Use ActiveMQTestBase.create*Locator() instead of
      ActiveMQClient.createServerLocator*(..)
    - Use fluent ServerLocator methods
    - Make sure all ActiveMQServers.newActiveMQServer invocations
      are surrounded with addServer() where appropriate
    - Create a few example tests to be references from hacking-guide
    - Update hacking-guide with more info on writing tests

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request: More test-suite refactoring

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/4


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request: More test-suite refactoring

Posted by jbertram <gi...@git.apache.org>.
Github user jbertram commented on the pull request:

    https://github.com/apache/activemq-artemis/pull/4#issuecomment-106316164
  
    I apologize for the size of this commit.
    
    I ran the full test-suite and the only failures were things that were failing previously or things that pass locally.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---