You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by zh...@apache.org on 2020/07/04 16:34:07 UTC

[shardingsphere-elasticjob-lite] branch master updated: Revise #939 (#941)

This is an automated email from the ASF dual-hosted git repository.

zhangliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere-elasticjob-lite.git


The following commit(s) were added to refs/heads/master by this push:
     new 7922809  Revise #939 (#941)
7922809 is described below

commit 7922809152a4f61337e9627309a7187a7f045ed0
Author: Liang Zhang <te...@163.com>
AuthorDate: Sun Jul 5 00:34:01 2020 +0800

    Revise #939 (#941)
---
 docs/content/02-guide/operation-manual.md          | 10 ++++-----
 .../console/controller/JobConfigController.java    |  6 +++---
 .../lite/console/service/JobAPIService.java        |  8 ++++----
 .../console/service/impl/JobAPIServiceImpl.java    |  7 +++----
 .../resources/console/js/status/job/job_config.js  |  4 ++--
 .../lite/lifecycle/api/JobAPIFactory.java          | 10 ++++-----
 ...{JobConfigAPI.java => JobConfigurationAPI.java} | 16 +++++++--------
 ...igAPIImpl.java => JobConfigurationAPIImpl.java} | 20 ++++++++----------
 .../lite/lifecycle/api/JobAPIFactoryTest.java      |  2 +-
 ...lTest.java => JobConfigurationAPIImplTest.java} | 24 +++++++++++-----------
 10 files changed, 52 insertions(+), 55 deletions(-)

diff --git a/docs/content/02-guide/operation-manual.md b/docs/content/02-guide/operation-manual.md
index 6dfa3bb..3df3e70 100644
--- a/docs/content/02-guide/operation-manual.md
+++ b/docs/content/02-guide/operation-manual.md
@@ -11,19 +11,19 @@ next = "/02-guide/customized-hook/"
 
 ### 1. 配置类API
 
-#### `JobSettingsAPI` 作业配置的API
+#### `JobConfigurationAPI` 作业配置的API
 
-##### JobSettings getJobSettings(String jobName) 获取作业设置.
+##### YamlJobConfiguration getJobConfiguration(String jobName) 获取作业设置.
 
 * **Parameters:** jobName — 作业名称
  
 * **Returns:** 作业设置对象
 
-##### void updateJobSettings(JobSettings jobSettings) 更新作业设置.
+##### void updateJobConfiguration(YamlJobConfiguration yamlJobConfiguration) 更新作业设置.
 
-* **Parameters:** jobSettings — 作业设置对象
+* **Parameters:** jobConfiguration — 作业设置对象
 
-##### void removeJobSettings(String jobName) 删除作业设置.
+##### void removeJobConfiguration(String jobName) 删除作业设置.
 
 * **Parameters:** jobName — 作业名称
  
diff --git a/elastic-job-lite-console/src/main/java/org/apache/shardingsphere/elasticjob/lite/console/controller/JobConfigController.java b/elastic-job-lite-console/src/main/java/org/apache/shardingsphere/elasticjob/lite/console/controller/JobConfigController.java
index eaa7ead..3a32ac5 100644
--- a/elastic-job-lite-console/src/main/java/org/apache/shardingsphere/elasticjob/lite/console/controller/JobConfigController.java
+++ b/elastic-job-lite-console/src/main/java/org/apache/shardingsphere/elasticjob/lite/console/controller/JobConfigController.java
@@ -52,7 +52,7 @@ public final class JobConfigController {
      */
     @GetMapping(value = "/{jobName}", produces = MediaType.APPLICATION_JSON)
     public YamlJobConfiguration getJobConfig(@PathVariable("jobName") final String jobName) {
-        return jobAPIService.getJobConfigAPI().getJobConfig(jobName);
+        return jobAPIService.getJobConfigurationAPI().getJobConfiguration(jobName);
     }
     
     /**
@@ -62,7 +62,7 @@ public final class JobConfigController {
      */
     @PutMapping(consumes = MediaType.APPLICATION_JSON)
     public void updateJobConfig(@RequestBody final YamlJobConfiguration yamlJobConfiguration) {
-        jobAPIService.getJobConfigAPI().updateJobConfig(yamlJobConfiguration);
+        jobAPIService.getJobConfigurationAPI().updateJobConfiguration(yamlJobConfiguration);
     }
     
     /**
@@ -72,6 +72,6 @@ public final class JobConfigController {
      */
     @DeleteMapping("/{jobName}")
     public void removeJob(@PathVariable("jobName") final String jobName) {
-        jobAPIService.getJobConfigAPI().removeJobConfig(jobName);
+        jobAPIService.getJobConfigurationAPI().removeJobConfiguration(jobName);
     }
 }
diff --git a/elastic-job-lite-console/src/main/java/org/apache/shardingsphere/elasticjob/lite/console/service/JobAPIService.java b/elastic-job-lite-console/src/main/java/org/apache/shardingsphere/elasticjob/lite/console/service/JobAPIService.java
index 29c4e7c..3e5e48b 100644
--- a/elastic-job-lite-console/src/main/java/org/apache/shardingsphere/elasticjob/lite/console/service/JobAPIService.java
+++ b/elastic-job-lite-console/src/main/java/org/apache/shardingsphere/elasticjob/lite/console/service/JobAPIService.java
@@ -18,7 +18,7 @@
 package org.apache.shardingsphere.elasticjob.lite.console.service;
 
 import org.apache.shardingsphere.elasticjob.lite.lifecycle.api.JobOperateAPI;
-import org.apache.shardingsphere.elasticjob.lite.lifecycle.api.JobConfigAPI;
+import org.apache.shardingsphere.elasticjob.lite.lifecycle.api.JobConfigurationAPI;
 import org.apache.shardingsphere.elasticjob.lite.lifecycle.api.JobStatisticsAPI;
 import org.apache.shardingsphere.elasticjob.lite.lifecycle.api.ServerStatisticsAPI;
 import org.apache.shardingsphere.elasticjob.lite.lifecycle.api.ShardingOperateAPI;
@@ -27,11 +27,11 @@ import org.apache.shardingsphere.elasticjob.lite.lifecycle.api.ShardingStatistic
 public interface JobAPIService {
     
     /**
-     * Job settings API.
+     * Job configuration API.
      *
-     * @return job settings API
+     * @return job configuration API
      */
-    JobConfigAPI getJobConfigAPI();
+    JobConfigurationAPI getJobConfigurationAPI();
     
     /**
      * Job operate API.
diff --git a/elastic-job-lite-console/src/main/java/org/apache/shardingsphere/elasticjob/lite/console/service/impl/JobAPIServiceImpl.java b/elastic-job-lite-console/src/main/java/org/apache/shardingsphere/elasticjob/lite/console/service/impl/JobAPIServiceImpl.java
index 466a151..231333b 100644
--- a/elastic-job-lite-console/src/main/java/org/apache/shardingsphere/elasticjob/lite/console/service/impl/JobAPIServiceImpl.java
+++ b/elastic-job-lite-console/src/main/java/org/apache/shardingsphere/elasticjob/lite/console/service/impl/JobAPIServiceImpl.java
@@ -22,7 +22,7 @@ import org.apache.shardingsphere.elasticjob.lite.console.service.JobAPIService;
 import org.apache.shardingsphere.elasticjob.lite.console.util.SessionRegistryCenterConfiguration;
 import org.apache.shardingsphere.elasticjob.lite.lifecycle.api.JobAPIFactory;
 import org.apache.shardingsphere.elasticjob.lite.lifecycle.api.JobOperateAPI;
-import org.apache.shardingsphere.elasticjob.lite.lifecycle.api.JobConfigAPI;
+import org.apache.shardingsphere.elasticjob.lite.lifecycle.api.JobConfigurationAPI;
 import org.apache.shardingsphere.elasticjob.lite.lifecycle.api.JobStatisticsAPI;
 import org.apache.shardingsphere.elasticjob.lite.lifecycle.api.ServerStatisticsAPI;
 import org.apache.shardingsphere.elasticjob.lite.lifecycle.api.ShardingOperateAPI;
@@ -36,9 +36,9 @@ import org.springframework.stereotype.Service;
 public final class JobAPIServiceImpl implements JobAPIService {
     
     @Override
-    public JobConfigAPI getJobConfigAPI() {
+    public JobConfigurationAPI getJobConfigurationAPI() {
         RegistryCenterConfiguration regCenterConfig = SessionRegistryCenterConfiguration.getRegistryCenterConfiguration();
-        return JobAPIFactory.createJobConfigAPI(regCenterConfig.getZkAddressList(), regCenterConfig.getNamespace(), regCenterConfig.getDigest());
+        return JobAPIFactory.createJobConfigurationAPI(regCenterConfig.getZkAddressList(), regCenterConfig.getNamespace(), regCenterConfig.getDigest());
     }
     
     @Override
@@ -70,5 +70,4 @@ public final class JobAPIServiceImpl implements JobAPIService {
         RegistryCenterConfiguration regCenterConfig = SessionRegistryCenterConfiguration.getRegistryCenterConfiguration();
         return JobAPIFactory.createShardingStatisticsAPI(regCenterConfig.getZkAddressList(), regCenterConfig.getNamespace(), regCenterConfig.getDigest());
     }
-    
 }
diff --git a/elastic-job-lite-console/src/main/resources/console/js/status/job/job_config.js b/elastic-job-lite-console/src/main/resources/console/js/status/job/job_config.js
index a2fcf05..2401915 100644
--- a/elastic-job-lite-console/src/main/resources/console/js/status/job/job_config.js
+++ b/elastic-job-lite-console/src/main/resources/console/js/status/job/job_config.js
@@ -18,7 +18,7 @@
 $(function() {
     tooltipLocale();
     validate();
-    bindSubmitJobSettingsForm();
+    bindSubmitJobConfigurationForm();
     bindResetForm();
 });
 
@@ -42,7 +42,7 @@ function getJobParams() {
     return jobParams;
 }
 
-function bindSubmitJobSettingsForm() {
+function bindSubmitJobConfigurationForm() {
     $("#update-job-info-btn").on("click", function(){
         var bootstrapValidator = $("#job-config-form").data("bootstrapValidator");
         bootstrapValidator.validate();
diff --git a/elastic-job-lite-lifecycle/src/main/java/org/apache/shardingsphere/elasticjob/lite/lifecycle/api/JobAPIFactory.java b/elastic-job-lite-lifecycle/src/main/java/org/apache/shardingsphere/elasticjob/lite/lifecycle/api/JobAPIFactory.java
index 743b5a5..b1a842b 100644
--- a/elastic-job-lite-lifecycle/src/main/java/org/apache/shardingsphere/elasticjob/lite/lifecycle/api/JobAPIFactory.java
+++ b/elastic-job-lite-lifecycle/src/main/java/org/apache/shardingsphere/elasticjob/lite/lifecycle/api/JobAPIFactory.java
@@ -22,7 +22,7 @@ import lombok.NoArgsConstructor;
 import org.apache.shardingsphere.elasticjob.lite.lifecycle.internal.operate.JobOperateAPIImpl;
 import org.apache.shardingsphere.elasticjob.lite.lifecycle.internal.operate.ShardingOperateAPIImpl;
 import org.apache.shardingsphere.elasticjob.lite.lifecycle.internal.reg.RegistryCenterFactory;
-import org.apache.shardingsphere.elasticjob.lite.lifecycle.internal.settings.JobConfigAPIImpl;
+import org.apache.shardingsphere.elasticjob.lite.lifecycle.internal.settings.JobConfigurationAPIImpl;
 import org.apache.shardingsphere.elasticjob.lite.lifecycle.internal.statistics.JobStatisticsAPIImpl;
 import org.apache.shardingsphere.elasticjob.lite.lifecycle.internal.statistics.ServerStatisticsAPIImpl;
 import org.apache.shardingsphere.elasticjob.lite.lifecycle.internal.statistics.ShardingStatisticsAPIImpl;
@@ -34,15 +34,15 @@ import org.apache.shardingsphere.elasticjob.lite.lifecycle.internal.statistics.S
 public final class JobAPIFactory {
     
     /**
-     * Create job settings API.
+     * Create job configuration API.
      *
      * @param connectString registry center connect string
      * @param namespace registry center namespace
      * @param digest registry center digest
-     * @return job settings API
+     * @return job configuration API
      */
-    public static JobConfigAPI createJobConfigAPI(final String connectString, final String namespace, final String digest) {
-        return new JobConfigAPIImpl(RegistryCenterFactory.createCoordinatorRegistryCenter(connectString, namespace, digest));
+    public static JobConfigurationAPI createJobConfigurationAPI(final String connectString, final String namespace, final String digest) {
+        return new JobConfigurationAPIImpl(RegistryCenterFactory.createCoordinatorRegistryCenter(connectString, namespace, digest));
     }
     
     /**
diff --git a/elastic-job-lite-lifecycle/src/main/java/org/apache/shardingsphere/elasticjob/lite/lifecycle/api/JobConfigAPI.java b/elastic-job-lite-lifecycle/src/main/java/org/apache/shardingsphere/elasticjob/lite/lifecycle/api/JobConfigurationAPI.java
similarity index 82%
rename from elastic-job-lite-lifecycle/src/main/java/org/apache/shardingsphere/elasticjob/lite/lifecycle/api/JobConfigAPI.java
rename to elastic-job-lite-lifecycle/src/main/java/org/apache/shardingsphere/elasticjob/lite/lifecycle/api/JobConfigurationAPI.java
index 89b285d..8c4a6a1 100644
--- a/elastic-job-lite-lifecycle/src/main/java/org/apache/shardingsphere/elasticjob/lite/lifecycle/api/JobConfigAPI.java
+++ b/elastic-job-lite-lifecycle/src/main/java/org/apache/shardingsphere/elasticjob/lite/lifecycle/api/JobConfigurationAPI.java
@@ -20,29 +20,29 @@ package org.apache.shardingsphere.elasticjob.lite.lifecycle.api;
 import org.apache.shardingsphere.elasticjob.lite.internal.config.yaml.YamlJobConfiguration;
 
 /**
- * Job settings API.
+ * Job configuration API.
  */
-public interface JobConfigAPI {
-
+public interface JobConfigurationAPI {
+    
     /**
      * get job configuration.
      *
      * @param jobName job name
      * @return job configuration
      */
-    YamlJobConfiguration getJobConfig(String jobName);
-
+    YamlJobConfiguration getJobConfiguration(String jobName);
+    
     /**
      * Update job configuration.
      *
      * @param yamlJobConfiguration job configuration
      */
-    void updateJobConfig(YamlJobConfiguration yamlJobConfiguration);
-
+    void updateJobConfiguration(YamlJobConfiguration yamlJobConfiguration);
+    
     /**
      * Remove job configuration.
      *
      * @param jobName job name
      */
-    void removeJobConfig(String jobName);
+    void removeJobConfiguration(String jobName);
 }
diff --git a/elastic-job-lite-lifecycle/src/main/java/org/apache/shardingsphere/elasticjob/lite/lifecycle/internal/settings/JobConfigAPIImpl.java b/elastic-job-lite-lifecycle/src/main/java/org/apache/shardingsphere/elasticjob/lite/lifecycle/internal/settings/JobConfigurationAPIImpl.java
similarity index 81%
rename from elastic-job-lite-lifecycle/src/main/java/org/apache/shardingsphere/elasticjob/lite/lifecycle/internal/settings/JobConfigAPIImpl.java
rename to elastic-job-lite-lifecycle/src/main/java/org/apache/shardingsphere/elasticjob/lite/lifecycle/internal/settings/JobConfigurationAPIImpl.java
index 931ed4c..6df5299 100644
--- a/elastic-job-lite-lifecycle/src/main/java/org/apache/shardingsphere/elasticjob/lite/lifecycle/internal/settings/JobConfigAPIImpl.java
+++ b/elastic-job-lite-lifecycle/src/main/java/org/apache/shardingsphere/elasticjob/lite/lifecycle/internal/settings/JobConfigurationAPIImpl.java
@@ -22,7 +22,7 @@ import com.google.common.base.Strings;
 import lombok.RequiredArgsConstructor;
 import org.apache.shardingsphere.elasticjob.lite.internal.config.yaml.YamlJobConfiguration;
 import org.apache.shardingsphere.elasticjob.lite.internal.storage.JobNodePath;
-import org.apache.shardingsphere.elasticjob.lite.lifecycle.api.JobConfigAPI;
+import org.apache.shardingsphere.elasticjob.lite.lifecycle.api.JobConfigurationAPI;
 import org.apache.shardingsphere.elasticjob.lite.reg.base.CoordinatorRegistryCenter;
 import org.apache.shardingsphere.elasticjob.lite.util.yaml.YamlEngine;
 
@@ -30,28 +30,26 @@ import org.apache.shardingsphere.elasticjob.lite.util.yaml.YamlEngine;
  * Job Configuration API implementation class.
  */
 @RequiredArgsConstructor
-public final class JobConfigAPIImpl implements JobConfigAPI {
+public final class JobConfigurationAPIImpl implements JobConfigurationAPI {
     
     private final CoordinatorRegistryCenter regCenter;
-
+    
     @Override
-    public YamlJobConfiguration getJobConfig(final String jobName) {
-        JobNodePath jobNodePath = new JobNodePath(jobName);
-        YamlJobConfiguration result = YamlEngine.unmarshal(regCenter.get(jobNodePath.getConfigNodePath()), YamlJobConfiguration.class);
-        return result;
+    public YamlJobConfiguration getJobConfiguration(final String jobName) {
+        return YamlEngine.unmarshal(regCenter.get(new JobNodePath(jobName).getConfigNodePath()), YamlJobConfiguration.class);
     }
-
+    
     @Override
-    public void updateJobConfig(final YamlJobConfiguration yamlJobConfiguration) {
+    public void updateJobConfiguration(final YamlJobConfiguration yamlJobConfiguration) {
         Preconditions.checkArgument(!Strings.isNullOrEmpty(yamlJobConfiguration.getJobName()), "jobName can not be empty.");
         Preconditions.checkArgument(!Strings.isNullOrEmpty(yamlJobConfiguration.getCron()), "cron can not be empty.");
         Preconditions.checkArgument(yamlJobConfiguration.getShardingTotalCount() > 0, "shardingTotalCount should larger than zero.");
         JobNodePath jobNodePath = new JobNodePath(yamlJobConfiguration.getJobName());
         regCenter.update(jobNodePath.getConfigNodePath(), YamlEngine.marshal(yamlJobConfiguration));
     }
-
+    
     @Override
-    public void removeJobConfig(final String jobName) {
+    public void removeJobConfiguration(final String jobName) {
         regCenter.remove("/" + jobName);
     }
 }
diff --git a/elastic-job-lite-lifecycle/src/test/java/org/apache/shardingsphere/elasticjob/lite/lifecycle/api/JobAPIFactoryTest.java b/elastic-job-lite-lifecycle/src/test/java/org/apache/shardingsphere/elasticjob/lite/lifecycle/api/JobAPIFactoryTest.java
index ed7b95a..63eea65 100644
--- a/elastic-job-lite-lifecycle/src/test/java/org/apache/shardingsphere/elasticjob/lite/lifecycle/api/JobAPIFactoryTest.java
+++ b/elastic-job-lite-lifecycle/src/test/java/org/apache/shardingsphere/elasticjob/lite/lifecycle/api/JobAPIFactoryTest.java
@@ -27,7 +27,7 @@ public final class JobAPIFactoryTest extends AbstractEmbedZookeeperBaseTest {
     
     @Test
     public void assertCreateJobConfigAPI() {
-        assertThat(JobAPIFactory.createJobConfigAPI(getConnectionString(), "namespace", null), instanceOf(JobConfigAPI.class));
+        assertThat(JobAPIFactory.createJobConfigurationAPI(getConnectionString(), "namespace", null), instanceOf(JobConfigurationAPI.class));
     }
     
     @Test
diff --git a/elastic-job-lite-lifecycle/src/test/java/org/apache/shardingsphere/elasticjob/lite/lifecycle/internal/settings/JobConfigAPIImplTest.java b/elastic-job-lite-lifecycle/src/test/java/org/apache/shardingsphere/elasticjob/lite/lifecycle/internal/settings/JobConfigurationAPIImplTest.java
similarity index 88%
rename from elastic-job-lite-lifecycle/src/test/java/org/apache/shardingsphere/elasticjob/lite/lifecycle/internal/settings/JobConfigAPIImplTest.java
rename to elastic-job-lite-lifecycle/src/test/java/org/apache/shardingsphere/elasticjob/lite/lifecycle/internal/settings/JobConfigurationAPIImplTest.java
index c6d7dc3..d8e35bc 100644
--- a/elastic-job-lite-lifecycle/src/test/java/org/apache/shardingsphere/elasticjob/lite/lifecycle/internal/settings/JobConfigAPIImplTest.java
+++ b/elastic-job-lite-lifecycle/src/test/java/org/apache/shardingsphere/elasticjob/lite/lifecycle/internal/settings/JobConfigurationAPIImplTest.java
@@ -20,7 +20,7 @@ package org.apache.shardingsphere.elasticjob.lite.lifecycle.internal.settings;
 import org.apache.shardingsphere.elasticjob.lite.executor.type.impl.DataflowJobExecutor;
 import org.apache.shardingsphere.elasticjob.lite.executor.type.impl.ScriptJobExecutor;
 import org.apache.shardingsphere.elasticjob.lite.internal.config.yaml.YamlJobConfiguration;
-import org.apache.shardingsphere.elasticjob.lite.lifecycle.api.JobConfigAPI;
+import org.apache.shardingsphere.elasticjob.lite.lifecycle.api.JobConfigurationAPI;
 import org.apache.shardingsphere.elasticjob.lite.lifecycle.fixture.LifecycleYamlConstants;
 import org.apache.shardingsphere.elasticjob.lite.reg.base.CoordinatorRegistryCenter;
 import org.junit.Before;
@@ -38,22 +38,22 @@ import static org.mockito.Mockito.verify;
 import static org.mockito.Mockito.when;
 
 @RunWith(MockitoJUnitRunner.class)
-public final class JobConfigAPIImplTest {
+public final class JobConfigurationAPIImplTest {
     
-    private JobConfigAPI jobConfigAPI;
+    private JobConfigurationAPI jobConfigAPI;
     
     @Mock
     private CoordinatorRegistryCenter regCenter;
     
     @Before
     public void setUp() {
-        jobConfigAPI = new JobConfigAPIImpl(regCenter);
+        jobConfigAPI = new JobConfigurationAPIImpl(regCenter);
     }
     
     @Test
     public void assertGetDataflowJobConfig() {
         when(regCenter.get("/test_job/config")).thenReturn(LifecycleYamlConstants.getDataflowJobYaml());
-        YamlJobConfiguration actual = jobConfigAPI.getJobConfig("test_job");
+        YamlJobConfiguration actual = jobConfigAPI.getJobConfiguration("test_job");
         assertJobConfig(actual);
         assertThat(actual.getProps().getProperty(DataflowJobExecutor.STREAM_PROCESS_KEY), is("true"));
         verify(regCenter).get("/test_job/config");
@@ -62,7 +62,7 @@ public final class JobConfigAPIImplTest {
     @Test
     public void assertGetScriptJobConfig() {
         when(regCenter.get("/test_job/config")).thenReturn(LifecycleYamlConstants.getScriptJobYaml());
-        YamlJobConfiguration actual = jobConfigAPI.getJobConfig("test_job");
+        YamlJobConfiguration actual = jobConfigAPI.getJobConfiguration("test_job");
         assertJobConfig(actual);
         assertThat(actual.getProps().getProperty(ScriptJobExecutor.SCRIPT_KEY), is("echo"));
         verify(regCenter).get("/test_job/config");
@@ -97,7 +97,7 @@ public final class JobConfigAPIImplTest {
         jobConfiguration.setReconcileIntervalMinutes(10);
         jobConfiguration.setDescription("");
         jobConfiguration.getProps().setProperty(DataflowJobExecutor.STREAM_PROCESS_KEY, "true");
-        jobConfigAPI.updateJobConfig(jobConfiguration);
+        jobConfigAPI.updateJobConfiguration(jobConfiguration);
         verify(regCenter).update("/test_job/config", LifecycleYamlConstants.getDataflowJobYaml());
     }
     
@@ -105,7 +105,7 @@ public final class JobConfigAPIImplTest {
     public void assertUpdateJobConfigIfJobNameIsEmpty() {
         YamlJobConfiguration jobConfiguration = new YamlJobConfiguration();
         jobConfiguration.setJobName("");
-        jobConfigAPI.updateJobConfig(jobConfiguration);
+        jobConfigAPI.updateJobConfiguration(jobConfiguration);
     }
     
     @Test(expected = IllegalArgumentException.class)
@@ -113,7 +113,7 @@ public final class JobConfigAPIImplTest {
         YamlJobConfiguration jobConfiguration = new YamlJobConfiguration();
         jobConfiguration.setJobName("test_job");
         jobConfiguration.setCron("");
-        jobConfigAPI.updateJobConfig(jobConfiguration);
+        jobConfigAPI.updateJobConfiguration(jobConfiguration);
     }
     
     @Test(expected = IllegalArgumentException.class)
@@ -122,12 +122,12 @@ public final class JobConfigAPIImplTest {
         jobConfiguration.setJobName("test_job");
         jobConfiguration.setCron("0/1 * * * * ?");
         jobConfiguration.setShardingTotalCount(0);
-        jobConfigAPI.updateJobConfig(jobConfiguration);
+        jobConfigAPI.updateJobConfiguration(jobConfiguration);
     }
     
     @Test
-    public void assertRemoveJobSettings() {
-        jobConfigAPI.removeJobConfig("test_job");
+    public void assertRemoveJobConfiguration() {
+        jobConfigAPI.removeJobConfiguration("test_job");
         verify(regCenter).remove("/test_job");
     }
 }