You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2018/02/08 11:48:01 UTC

[GitHub] eolivelli commented on a change in pull request #1129: WIP Upgrade JaCoCo and Upgrade Coveralls.io configuration

eolivelli commented on a change in pull request #1129: WIP Upgrade JaCoCo and Upgrade Coveralls.io configuration
URL: https://github.com/apache/bookkeeper/pull/1129#discussion_r166910489
 
 

 ##########
 File path: pom.xml
 ##########
 @@ -389,6 +389,9 @@
                 <groupId>org.eluder.coveralls</groupId>
                 <artifactId>coveralls-maven-plugin</artifactId>
                 <version>4.3.0</version>
+                <configuration>
+                    <sourceDirectories>circe-checksum/target/nar/nar-generated</sourceDirectories>
 
 Review comment:
   Sorry, I have misunderstood your comment.
   I am working on skipping all generated code, it makes no sense to check it

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services