[GitHub] [trafficserver] jrushford commented on a change in pull request #7276: Remove the last remnants of the enable_url_expandomatic

[GitBox <gi...@apache.org>]

jrushford commented on a change in pull request #7276:
URL: https://github.com/apache/trafficserver/pull/7276#discussion_r518917598



##########
File path: proxy/http/HttpTransact.cc
##########
@@ -6564,28 +6511,6 @@ HttpTransact::process_quick_http_filter(State *s, int method)
   }
 }
 
-HttpTransact::HostNameExpansionError_t
-HttpTransact::try_to_expand_host_name(State *s)
-{
-  HTTP_RELEASE_ASSERT(!s->dns_info.lookup_success);
-
-  if (s->dns_info.looking_up == ORIGIN_SERVER) {
-    return EXPANSION_NOT_ALLOWED;
-  } else {
-    //////////////////////////////////////////////////////
-    // we looked up dns of parent proxy, but it failed, //
-    // try lookup of origin server name.                //
-    //////////////////////////////////////////////////////
-    ink_assert(s->dns_info.looking_up == PARENT_PROXY);
-
-    s->dns_info.lookup_name = s->server_info.name;
-    s->dns_info.looking_up  = ORIGIN_SERVER;

Review comment:
       @rob05c and @shinrich I'm not familiar with this expandomatic feature but yeah, this seems like it was wrong to switch over to the origin.  If it could not expand the parent name, the state machine should ask parent selection for a new available parent to try instead of switching over to the origin.  I think a switch to the origin should occur only when the parent list is exhausted.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org