[GitHub] [pinot] klsince commented on a diff in pull request #11020: allow to preload segments with upsert snapshots to speedup table loading

["klsince (via GitHub)" <gi...@apache.org>]

klsince commented on code in PR #11020:
URL: https://github.com/apache/pinot/pull/11020#discussion_r1248858243


##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BaseTableUpsertMetadataManager.java:
##########
@@ -75,6 +115,145 @@ public void init(TableConfig tableConfig, Schema schema, TableDataManager tableD
 
     _enableSnapshot = upsertConfig.isEnableSnapshot();
     _serverMetrics = serverMetrics;
+    _helixManager = helixManager;
+    _preloadExecutor = preloadExecutor;
+    try {
+      if (_enableSnapshot && upsertConfig.isEnablePreload()) {
+        preloadSegments();

Review Comment:
   Good point! The concurrentMap.computeIfAbsent() used to create table data mgr conditionally in InstanceDataMgr is functioning as the lock. This actually reminded me of the logs I observed in my tests.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org