[GitHub] [guacamole-server] mike-jumper commented on a change in pull request #234: GUACAMOLE-630: Expose terminal color/font changes.

[GitBox <gi...@apache.org>]

mike-jumper commented on a change in pull request #234: GUACAMOLE-630: Expose terminal color/font changes.
URL: https://github.com/apache/guacamole-server/pull/234#discussion_r311840120
 
 

 ##########
 File path: src/protocols/kubernetes/argv.h
 ##########
 @@ -37,5 +37,26 @@
  */
 guac_user_argv_handler guac_kubernetes_argv_handler;
 
+/**
+ * Sends the current values of all non-sensitive parameters which may be set
+ * while the connection is running to the given user. Note that the user
+ * receiving these values will not necessarily be able to set new values
+ * themselves if their connection is read-only. This function is provided for
+ * convenience, as it is can be used as the callback for
 
 Review comment:
   I'll switch things from "This function is provided for convenience, as it is can be used as the callback for ..." to "This function can be used as the callback for ...".
   
   The caller can decide for themselves whether it's convenient. ;)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services